Bug 1829382 - use binary search in mozglue blocklist r=handyman

Someday I would like to figure out why this blocklist only works on ASCII strings and the freestanding one works on wide strings, but I'll leave that for another time I guess. This gets us closer to unifying the logic between the two blocklists, which is nice.

I ran the TestDllBlocklist* gtests locally while using the mozglue blocklist and the ones that are expected to pass do indeed pass.

Differential Revision: https://phabricator.services.mozilla.com/D176444

UltraBlame original commit: 169ca1394b2747cb91f95fe618faebef3fb1663e

Author: marco-c

toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp

@@ -2263,7 +2263,7 @@ ShouldBlockBasedOnBlockInfo
 (
 const
 DllBlockInfo
-*
+&
 info
 const
 char
@@ -2312,8 +2312,7 @@ endif
 if
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2343,8 +2342,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2367,8 +2365,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2391,8 +2388,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2418,8 +2414,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2445,8 +2440,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2472,8 +2466,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2499,8 +2492,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2532,8 +2524,7 @@ ALL_VERSIONS
 if
 (
 info
--
->
+.
 mMaxVersion
 !
 =
@@ -2634,8 +2625,7 @@ true
 if
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -2662,8 +2652,7 @@ if
 fVersion
 >
 info
--
->
+.
 mMaxVersion
 )
 {
@@ -2713,8 +2702,7 @@ isOk
 {
 return
 info
--
->
+.
 IsVersionBlocked
 (
 version
@@ -2742,6 +2730,53 @@ return
 true
 ;
 }
+struct
+CaseSensitiveStringComparator
+{
+explicit
+CaseSensitiveStringComparator
+(
+const
+char
+*
+aTarget
+)
+:
+mTarget
+(
+aTarget
+)
+{
+}
+int
+operator
+(
+)
+(
+const
+DllBlockInfo
+&
+aVal
+)
+const
+{
+return
+strcmp
+(
+mTarget
+aVal
+.
+mName
+)
+;
+}
+const
+char
+*
+mTarget
+;
+}
+;
 static
 NTSTATUS
 NTAPI
@@ -3406,28 +3441,93 @@ DECLARE_POINTER_TO_FIRST_DLL_BLOCKLIST_ENTRY
 info
 )
 ;
-while
+DECLARE_DLL_BLOCKLIST_NUM_ENTRIES
+(
+infoNumEntries
+)
+;
+CaseSensitiveStringComparator
+comp
+(
+dllName
+)
+;
+size_t
+match
+=
+LowerBound
 (
 info
--
->
-mName
+0
+infoNumEntries
+comp
+)
+;
+if
+(
+match
+!
+=
+infoNumEntries
 )
 {
+/
+/
+There
+may
+be
+multiple
+entries
+on
+the
+list
+.
+Since
+LowerBound
+(
+)
+returns
+/
+/
+the
+first
+entry
+that
+matches
+(
 if
+there
+are
+any
+matches
+)
+/
+/
+search
+forward
+from
+there
+.
+while
 (
-strcmp
+match
+<
+infoNumEntries
+&
+&
+(
+comp
 (
 info
--
->
-mName
-dllName
+[
+match
+]
 )
 =
 =
 0
 )
+)
 {
 unsigned
 long
@@ -3439,6 +3539,9 @@ if
 ShouldBlockBasedOnBlockInfo
 (
 info
+[
+match
+]
 dllName
 filePath
 fname
@@ -3492,8 +3595,10 @@ DllBlockSet
 Add
 (
 info
--
->
+[
+match
+]
+.
 mName
 fVersion
 )
@@ -3502,13 +3607,13 @@ return
 STATUS_DLL_NOT_FOUND
 ;
 }
-}
-info
 +
 +
+match
 ;
 }
 }
+}
 continue_loading
 :
 #