Bug 1612440 - Separate scene and frame related data in DocumentView. r=gw

DocumentView has a mix of members that affect scene building and memebers that change frame to frame. These need to be updated at different rates and more importantly follow the respective flow of scene and frame transactions, which wasn't done properly before this change.

Depends on D71781

Differential Revision: https://phabricator.services.mozilla.com/D71927

UltraBlame original commit: 4933e4b66edb70f5b8f682abc6025e9f50f14e4b

Author: marco-c

gfx/wr/webrender/src/render_backend.rs

@@ -646,13 +646,63 @@ Deserialize
 [
 derive
 (
+Copy
 Clone
 )
 ]
 pub
 struct
 DocumentView
 {
+scene
+:
+SceneView
+frame
+:
+FrameView
+}
+#
+[
+cfg_attr
+(
+feature
+=
+"
+capture
+"
+derive
+(
+Serialize
+)
+)
+]
+#
+[
+cfg_attr
+(
+feature
+=
+"
+replay
+"
+derive
+(
+Deserialize
+)
+)
+]
+#
+[
+derive
+(
+Copy
+Clone
+)
+]
+pub
+struct
+SceneView
+{
 pub
 device_rect
 :
@@ -662,10 +712,6 @@ layer
 :
 DocumentLayer
 pub
-pan
-:
-DeviceIntPoint
-pub
 device_pixel_ratio
 :
 f32
@@ -674,20 +720,16 @@ page_zoom_factor
 :
 f32
 pub
-pinch_zoom_factor
-:
-f32
-pub
 quality_settings
 :
 QualitySettings
 }
 impl
-DocumentView
+SceneView
 {
 pub
 fn
-accumulated_scale_factor
+accumulated_scale_factor_for_snapping
 (
 &
 self
@@ -708,15 +750,64 @@ device_pixel_ratio
 self
 .
 page_zoom_factor
-*
-self
-.
-pinch_zoom_factor
 )
 }
+}
+#
+[
+cfg_attr
+(
+feature
+=
+"
+capture
+"
+derive
+(
+Serialize
+)
+)
+]
+#
+[
+cfg_attr
+(
+feature
+=
+"
+replay
+"
+derive
+(
+Deserialize
+)
+)
+]
+#
+[
+derive
+(
+Copy
+Clone
+)
+]
+pub
+struct
+FrameView
+{
+pan
+:
+DeviceIntPoint
+pinch_zoom_factor
+:
+f32
+}
+impl
+DocumentView
+{
 pub
 fn
-accumulated_scale_factor_for_snapping
+accumulated_scale_factor
 (
 &
 self
@@ -732,11 +823,21 @@ new
 (
 self
 .
+scene
+.
 device_pixel_ratio
 *
 self
 .
+scene
+.
 page_zoom_factor
+*
+self
+.
+frame
+.
+pinch_zoom_factor
 )
 }
 }
@@ -2193,6 +2294,10 @@ view
 :
 DocumentView
 {
+scene
+:
+SceneView
+{
 device_rect
 :
 size
@@ -2201,24 +2306,11 @@ into
 (
 )
 layer
-pan
-:
-DeviceIntPoint
-:
-:
-zero
-(
-)
 page_zoom_factor
 :
 1
 .
 0
-pinch_zoom_factor
-:
-1
-.
-0
 device_pixel_ratio
 :
 default_device_pixel_ratio
@@ -2231,6 +2323,27 @@ default
 (
 )
 }
+frame
+:
+FrameView
+{
+pan
+:
+DeviceIntPoint
+:
+:
+new
+(
+0
+0
+)
+pinch_zoom_factor
+:
+1
+.
+0
+}
+}
 stamp
 :
 FrameStamp
@@ -2377,6 +2490,8 @@ self
 .
 view
 .
+scene
+.
 device_rect
 .
 size
@@ -2670,6 +2785,8 @@ self
 .
 view
 .
+frame
+.
 pan
 !
 =
@@ -2679,6 +2796,8 @@ self
 .
 view
 .
+frame
+.
 pan
 =
 pan
@@ -2850,6 +2969,8 @@ self
 .
 view
 .
+frame
+.
 pinch_zoom_factor
 !
 =
@@ -2863,6 +2984,8 @@ self
 .
 view
 .
+frame
+.
 pinch_zoom_factor
 =
 factor
@@ -3010,6 +3133,8 @@ self
 .
 view
 .
+frame
+.
 pan
 .
 to_f32
@@ -3083,11 +3208,15 @@ self
 .
 view
 .
+scene
+.
 layer
 self
 .
 view
 .
+scene
+.
 device_rect
 .
 origin
@@ -3170,6 +3299,8 @@ self
 .
 view
 .
+frame
+.
 pan
 .
 to_f32
@@ -4681,6 +4812,8 @@ removed_pipelines
 doc
 .
 view
+.
+scene
 =
 txn
 .
@@ -8543,10 +8676,6 @@ id
 doc
 .
 view
-.
-clone
-(
-)
 )
 )
 .
@@ -9512,10 +9641,6 @@ id
 doc
 .
 view
-.
-clone
-(
-)
 )
 )
 .
@@ -10346,10 +10471,6 @@ doc
 view
 =
 view
-.
-clone
-(
-)
 ;
 doc
 .
@@ -10428,12 +10549,6 @@ new
 (
 )
 view
-:
-view
-.
-clone
-(
-)
 stamp
 :
 FrameStamp
@@ -10717,6 +10832,8 @@ view
 :
 view
 .
+scene
+.
 clone
 (
 )