Bug 1829382 - use binary search in mozglue blocklist r=handyman

Someday I would like to figure out why this blocklist only works on ASCII strings and the freestanding one works on wide strings, but I'll leave that for another time I guess. This gets us closer to unifying the logic between the two blocklists, which is nice.

I ran the TestDllBlocklist* gtests locally while using the mozglue blocklist and the ones that are expected to pass do indeed pass.

Differential Revision: https://phabricator.services.mozilla.com/D176444

UltraBlame original commit: 169ca1394b2747cb91f95fe618faebef3fb1663e

Author: marco-c

toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp

@@ -1585,7 +1585,7 @@ ShouldBlockBasedOnBlockInfo
 (
 const
 DllBlockInfo
-*
+&
 info
 const
 char
@@ -1634,8 +1634,7 @@ endif
 if
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1665,8 +1664,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1689,8 +1687,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1713,8 +1710,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1740,8 +1736,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1767,8 +1762,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1794,8 +1788,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1821,8 +1814,7 @@ if
 (
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1854,8 +1846,7 @@ ALL_VERSIONS
 if
 (
 info
--
->
+.
 mMaxVersion
 !
 =
@@ -1940,8 +1931,7 @@ true
 if
 (
 info
--
->
+.
 mFlags
 &
 DllBlockInfo
@@ -1968,8 +1958,7 @@ if
 fVersion
 >
 info
--
->
+.
 mMaxVersion
 )
 {
@@ -2006,8 +1995,7 @@ isOk
 {
 return
 info
--
->
+.
 IsVersionBlocked
 (
 version
@@ -2024,6 +2012,53 @@ return
 true
 ;
 }
+struct
+CaseSensitiveStringComparator
+{
+explicit
+CaseSensitiveStringComparator
+(
+const
+char
+*
+aTarget
+)
+:
+mTarget
+(
+aTarget
+)
+{
+}
+int
+operator
+(
+)
+(
+const
+DllBlockInfo
+&
+aVal
+)
+const
+{
+return
+strcmp
+(
+mTarget
+aVal
+.
+mName
+)
+;
+}
+const
+char
+*
+mTarget
+;
+}
+;
 static
 NTSTATUS
 NTAPI
@@ -2456,28 +2491,56 @@ DECLARE_POINTER_TO_FIRST_DLL_BLOCKLIST_ENTRY
 info
 )
 ;
-while
+DECLARE_DLL_BLOCKLIST_NUM_ENTRIES
+(
+infoNumEntries
+)
+;
+CaseSensitiveStringComparator
+comp
+(
+dllName
+)
+;
+size_t
+match
+=
+LowerBound
 (
 info
--
->
-mName
+0
+infoNumEntries
+comp
 )
-{
+;
 if
 (
-strcmp
+match
+!
+=
+infoNumEntries
+)
+{
+while
+(
+match
+<
+infoNumEntries
+&
+&
+(
+comp
 (
 info
--
->
-mName
-dllName
+[
+match
+]
 )
 =
 =
 0
 )
+)
 {
 unsigned
 long
@@ -2489,6 +2552,9 @@ if
 ShouldBlockBasedOnBlockInfo
 (
 info
+[
+match
+]
 dllName
 filePath
 fname
@@ -2542,8 +2608,10 @@ DllBlockSet
 Add
 (
 info
--
->
+[
+match
+]
+.
 mName
 fVersion
 )
@@ -2552,13 +2620,13 @@ return
 STATUS_DLL_NOT_FOUND
 ;
 }
-}
-info
 +
 +
+match
 ;
 }
 }
+}
 continue_loading
 :
 #