Tracing (#226)

* bump api

* tracing (wip)

* wip

* mostly working

* small fixes

* wip

* try to fix profile converter

Author: marcellourbani

.vscode/launch.json

@@ -30,6 +30,7 @@
       "address": "localhost",
       "smartStep": true,
       "showAsyncStacks": true,
+      "restart": true,
       "skipFiles": [
         "<node_internals>/**"
       ],

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## [1.7.14] 2024-10-23
+
+### Added
+
+- display performance traces
+
 ## [1.7.12] 2024-09-23
 
 ### Fixed

client/package-lock.json

@@ -81,6 +81,7 @@
     "tmp-promise": "^3.0.3",
     "tough-cookie": "^4.1.2",
     "uuid": "^9.0.0",
+    "v8-inspect-profiler": "^0.1.0",
     "vscode-abap-remote-fs-sharedapi": "file:../modules/sharedapi",
     "vscode-debugadapter": "^1.51.0",
     "vscode-debugprotocol": "^1.51.0",

client/package.json

@@ -127,7 +127,6 @@ export class ClassHierarchyLensProvider implements CodeLensProvider {
   public async provideCodeLenses(doc: TextDocument, token: CancellationToken): Promise<CodeLens[]> {
     const lenses: CodeLens[] = []
     if (doc.uri.scheme !== ADTSCHEME) return lenses
-    const client = getClient(doc.uri.authority)
     const obj = await findAbapObject(doc.uri)
     if (!obj) return lenses
     // TODO stat?

client/src/adt/classhierarchy.ts

@@ -255,8 +255,8 @@ export function createUri(connId: string, path: string, query: string = "") {
   })
 }
 
-export function findAbapObject(uri: Uri) {
-  const file = uriRoot(uri).getNode(uri.path)
+export async function findAbapObject(uri: Uri) {
+  const file = await uriRoot(uri).getNodeAsync(uri.path)
   if (isAbapStat(file)) return file.object
   throw new Error("Not an ABAP object")
 }

client/src/adt/operations/AdtObjectFinder.ts

@@ -4,12 +4,14 @@ import {
   Uri,
   window,
   commands,
-  ProgressLocation
+  ProgressLocation,
+  Position,
+  Range
 } from "vscode"
 import { pickAdtRoot, RemoteManager } from "../config"
-import { caughtToString, log } from "../lib"
+import { caughtToString, lineRange, log, splitAdtUri } from "../lib"
 import { FavouritesProvider, FavItem } from "../views/favourites"
-import { findEditor } from "../langClient"
+import { findEditor, vsCodeUri } from "../langClient"
 import { showHideActivate } from "../listeners"
 import { UnitTestRunner } from "../adt/operations/UnitTestRunner"
 import { selectTransport } from "../adt/AdtTransports"
@@ -80,7 +82,10 @@ export function openObject(connId: string, uri: string) {
     }
   )
 }
-
+interface ShowObjectArgument {
+  connId: string,
+  uri: string
+}
 export class AdtCommands {
   @command(AbapFsCommands.showDocumentation)
   private static async showAbapDoc() {
@@ -152,7 +157,7 @@ export class AdtCommands {
       await window.withProgress(
         { location: ProgressLocation.Window, title: "Activating..." },
         async () => {
-          const obj = findAbapObject(uri)
+          const obj = await findAbapObject(uri)
           // if editor is dirty, save before activate
           if (editor && editor.document.isDirty) {
             const saved = await editor.document.save()
@@ -247,7 +252,15 @@ export class AdtCommands {
       return window.showErrorMessage(caughtToString(e))
     }
   }
-
+  @command(AbapFsCommands.showObject)
+  private static async showObject(arg: ShowObjectArgument) {
+    const p = splitAdtUri(arg.uri)
+    const path = await vsCodeUri(arg.connId, arg.uri, true, true)
+    const uri = Uri.parse(path)
+    const doc = await workspace.openTextDocument(uri)
+    const selection = p.start?.line ? lineRange(p.start?.line + 1) : undefined
+    window.showTextDocument(doc, { selection })
+  }
   @command(AbapFsCommands.runInGui)
   private static async executeAbap() {
     try {

client/src/commands/commands.ts

@@ -76,7 +76,10 @@ export const AbapFsCommands = {
   agitAdd: "abapfs.addAbapGit",
   agitRemove: "abapfs.removeAbapGit",
   agitresetPwd: "abapfs.resetAbapGitPwd",
-  agitBranch: "abapfs.switchBranch"
+  agitBranch: "abapfs.switchBranch",
+  //traces
+  refreshTraces: "abapfs.refreshTraces",
+  deleteTrace: "abapfs.deleteTrace",
 }
 
 export const abapcmds: {

client/src/commands/registry.ts

@@ -32,6 +32,7 @@ import { HttpProvider } from "./editors/httpprovider"
 import { dumpProvider } from "./views/dumps/dumps"
 import { registerAbapDebugger } from "./adt/debugger"
 import { ATCDocumentation } from "./views/abaptestcockpit/documentation"
+import { tracesProvider } from "./views/traces"
 
 export let context: ExtensionContext
 
@@ -72,6 +73,7 @@ export async function activate(ctx: ExtensionContext): Promise<AbapFsApi> {
   sub.push(window.registerTreeDataProvider("abapfs.abapgit", abapGitProvider))
   sub.push(window.registerTreeDataProvider("abapfs.dumps", dumpProvider))
   sub.push(window.registerTreeDataProvider("abapfs.atcFinds", atcProvider))
+  sub.push(window.registerTreeDataProvider("abapfs.traces", tracesProvider))
   sub.push(
     languages.registerCodeLensProvider(
       { language: "abap", scheme: ADTSCHEME },

client/src/extension.ts

@@ -1,4 +1,4 @@
-import { ADTClient, AtcWorkList } from "abap-adt-api"
+import { AtcWorkList } from "abap-adt-api"
 import { Task } from "fp-ts/lib/Task"
 import { commands, Disposable, EventEmitter, Position, TextDocumentContentChangeEvent, ThemeColor, ThemeIcon, TreeDataProvider, TreeItem, TreeItemCollapsibleState, Uri, window } from "vscode"
 import { getClient } from "../../adt/conections"