Rd 864 unified linting config (#201)

* RD-864 Update lint config and migrate eslint config to typescript

* RD-864 Remove unused config file

* RD-864
- Add vite plugin to copy lint config across
- add additional files to .npmignore
- convert lint config to .mjs

* RD-864
- Convert demos eslint config to mjs
- re-add- demos to tsconfig

* RD-924 Rename eslint.config.ts to mjs again (overridden by merge changes)

* RD 924 Fix linting and ts build errors

---------

Co-authored-by: Les Moffat <les.moffat@maptiler.com>

Author: lesbaa

.npmignore

@@ -1,6 +1,7 @@
 docs
 docsmd
 images
+demos
 scripts
 test
 demos
@@ -11,4 +12,6 @@ src
 *.tgz
 .github
 .vscode
-build
+build
+vite.config-*
+vite-setup-tests.ts

demos/eslint.config.ts renamed to demos/eslint.config.mjs

@@ -1,5 +1,7 @@
+// @ts-nocheck
+
 import tseslint from "typescript-eslint";
-import baseConfig from "../eslint.config";
+import baseConfig from "../eslint.config.mjs";
 
 export default tseslint.config(baseConfig, {
   rules: {

eslint.config.ts renamed to eslint.config.mjs

@@ -1,20 +1,8 @@
-// @ts-check
+// @ts-nocheck
 
 import tseslint from "typescript-eslint";
 import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
 
-import { TSESTree } from "@typescript-eslint/utils";
-import { RuleContext } from "@typescript-eslint/utils/dist/ts-eslint";
-
-type Node = TSESTree.ImportDeclaration;
-
-type CustomRuleOptions = {
-  locations: string[];
-  message?: string;
-  fixedLocation?: string;
-  ignoreTypeImports?: boolean;
-};
-
 export default tseslint.config(
   // https://typescript-eslint.io/getting-started/typed-linting/
   tseslint.configs.strictTypeChecked,
@@ -39,7 +27,7 @@ export default tseslint.config(
                 },
               ],
             },
-            create: function (context: RuleContext<"bannedImport", Node[]>) {
+            create: function (context) {
               const filePath = context.getFilename();
               const options = context.options[0] || {
                 "^/(.*)": {
@@ -48,8 +36,8 @@ export default tseslint.config(
               };
 
               return {
-                ImportDeclaration: (node: Node) => {
-                  Object.entries(options).forEach(([bannedImport, config]: [string, CustomRuleOptions]) => {
+                ImportDeclaration: (node) => {
+                  Object.entries(options).forEach(([bannedImport, config]) => {
                     const importLocationRegex = new RegExp(bannedImport);
 
                     if (config.ignoreTypeImports && node.importKind === "type") return;

tsconfig.json

@@ -24,11 +24,19 @@
     "allowSyntheticDefaultImports": true,
     "allowJs": true,
   },
+  "exclude": [
+    "vite.config-*.ts",
+    "vitest-setup-tests.ts",
+    "dist"
+  ],
   "include": [
-    "demos",
+    "vite.config-dev.ts",
+    "vite.config-es.ts",
+    "vite.config-umd.ts",
+    "vite.config-test.ts",
+    "vitest-setup-tests.ts",
     "src",
-    "test",
-    "./vite.config-test.ts",
-    "./vitest-setup-tests.ts"
+    "demos",
+    "test"
   ],
 }

vite.config-es.ts

@@ -2,11 +2,25 @@ import { resolve } from 'path';
 import { defineConfig } from 'vite';
 import dts from 'vite-plugin-dts';
 import packagejson from "./package.json";
+import { copyFileSync } from 'fs';
 
 const isProduction = process.env.NODE_ENV === "production";
 
+function copyLinterConfig() {
+  return {
+    name: 'copy-linter-config',
+    writeBundle() {
+      const sourcePath = resolve(import.meta.dirname, 'eslint.config.mjs');
+      const destPath = resolve(import.meta.dirname, 'dist/eslint.mjs');
+      console.log(`Copying ${sourcePath} to ${destPath}`);
+      copyFileSync(sourcePath, destPath);
+    }
+  }
+}
+
 const plugins = [
   dts({insertTypesEntry: true}),
+  copyLinterConfig(),
 ];
 
 export default defineConfig({
@@ -17,11 +31,12 @@ export default defineConfig({
     outDir: "dist",
     sourcemap: true,
     lib: {
+      
       // Could also be a dictionary or array of multiple entry points
       entry: resolve(__dirname, 'src/index.ts'),
       name: 'maptilersdk',
       // the proper extensions will be added
-      fileName: (format, entryName) => "maptiler-sdk.mjs",
+      fileName: (_, __) => "maptiler-sdk.mjs",
       formats: ['es'],
     },
 

vite.config-umd.ts

@@ -14,7 +14,7 @@ export default defineConfig({
     lib: {
       entry: resolve(__dirname, 'src/index.ts'),
       name: 'maptilersdk',
-      fileName: (format, entryName) => "maptiler-sdk.umd.min.js",
+      fileName: (_, __) => "maptiler-sdk.umd.min.js",
       formats: ['umd'],
     }
   },