Skip to content

Commit f3a4cb1

Browse files
committed
remove elevation settings from tile creator constructor
1 parent d17ffb0 commit f3a4cb1

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

Runtime/Mapbox/BaseModule/Map/TileCreator.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ public class TileCreator : ITileCreator
2424
public UnityMapTile GetTile() => _tilePool.GetObject();
2525
public void PutTile(UnityMapTile tile) => _tilePool.Put(tile);
2626

27-
public TileCreator(UnityContext unityContext, TerrainStrategy terrainStrategy,
28-
ElevationLayerProperties elevationProperties = null, Material[] tileMaterials = null, int cacheSize = 25)
27+
public TileCreator(UnityContext unityContext, Material[] tileMaterials = null, int cacheSize = 25)
2928
{
3029
TileMaterials = tileMaterials;
3130
_unityContext = unityContext;

Runtime/Mapbox/BaseModule/Unity/ModuleBehaviours/TileCreatorBehaviour.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,14 @@ public class TileCreatorBehaviour : MonoBehaviour
1414

1515
[Tooltip("Materials for base map tile mesh and gameobject")]
1616
public Material[] TileMaterials;
17-
18-
[Tooltip("Settings for base map tile mesh")]
19-
public ElevationLayerProperties Settings;
2017

2118
public int CacheSize = 25;
2219

2320
public ITileCreator GetTileCreator(UnityContext unityContext)
2421
{
2522
if (_tileCreator != null) return _tileCreator;
2623

27-
_tileCreator = new TileCreator(unityContext, new ElevatedTerrainStrategy(), Settings, TileMaterials, CacheSize);
24+
_tileCreator = new TileCreator(unityContext, TileMaterials, CacheSize);
2825
return _tileCreator;
2926
}
3027
}

Runtime/Mapbox/Example/Scripts/Map/MapboxMapBehaviour.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ protected virtual MapboxMapVisualizer CreateMapVisualizer(IMapInformation mapInf
145145
{
146146
var tileCreator = _tileCreatorBehaviour != null
147147
? _tileCreatorBehaviour.GetTileCreator(unityContext)
148-
: new TileCreator(unityContext, new ElevatedTerrainStrategy());
148+
: new TileCreator(unityContext);
149149
return new MapboxMapVisualizer(mapInfo, unityContext, tileCreator);
150150
}
151151

Runtime/Mapbox/MapDebug/Scripts/Logging/LoggingMapBehaviour.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ protected virtual MapboxMapVisualizer CreateMapVisualizer(MapInformation mapInfo
159159
{
160160
var tileCreator = _tileCreatorBehaviour != null
161161
? _tileCreatorBehaviour.GetTileCreator(unityContext)
162-
: new TileCreator(unityContext, new ElevatedTerrainStrategy());
162+
: new TileCreator(unityContext);
163163
var mapVis = new LoggingMapVisualizer(mapInfo, unityContext, tileCreator);
164164
_mapLogger.AddLogger(mapVis);
165165
return mapVis;

Tests/Runtime/BaseModule/MapboxMapTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void OneTimeSetUp()
6161
dataManager);
6262

6363
_map = new MapboxMap(mapInfo, unityContext, mapService);
64-
var mapVisualizer = new MapboxMapVisualizer(mapInfo, unityContext, new TileCreator(unityContext, new FlatTerrainStrategy()));
64+
var mapVisualizer = new MapboxMapVisualizer(mapInfo, unityContext, new TileCreator(unityContext));
6565
_map.MapVisualizer = mapVisualizer;
6666
}
6767

0 commit comments

Comments
 (0)