Skip to content

Commit c796879

Browse files
committed
move elevation settings under terrain module stuff again
fix side walls
1 parent c5dfe4e commit c796879

File tree

5 files changed

+23
-23
lines changed

5 files changed

+23
-23
lines changed

Runtime/Mapbox/BaseModule/Data/TerrainStrategies/ElevatedTerrainStrategy.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,15 @@ public override void RegisterTile(UnityMapTile tile, bool createElevatedMesh)
8787
sharedMesh.uv = newMesh.Uvs;
8888
}
8989

90-
if (_elevationOptions.sideWallOptions.isActive)
91-
{
92-
var firstMat = tile.MeshRenderer.materials[0];
93-
tile.MeshRenderer.materials = new Material[2]
94-
{
95-
firstMat,
96-
_elevationOptions.sideWallOptions.wallMaterial
97-
};
98-
}
90+
// if (_elevationOptions.sideWallOptions.isActive)
91+
// {
92+
// var firstMat = tile.MeshRenderer.materials[0];
93+
// tile.MeshRenderer.materials = new Material[2]
94+
// {
95+
// firstMat,
96+
// _elevationOptions.sideWallOptions.wallMaterial
97+
// };
98+
// }
9999

100100
if (createElevatedMesh)
101101
{
@@ -128,7 +128,6 @@ private void CreateElevatedMesh(UnityMapTile tile)
128128

129129
vertices[i].Set(vertices[i].x, elevation, vertices[i].z);
130130
}
131-
132131
mesh.vertices = vertices;
133132
}
134133

@@ -285,8 +284,9 @@ private MeshDataArray CreateBaseMeshSkirts(float size, int sideVertexCount)
285284
mesh.Vertices = _newVertexList.ToArray();
286285
mesh.Normals = _newNormalList.ToArray();
287286
mesh.Uvs = _newUvList.ToArray();
287+
topQuadTris.AddRange(_newTriangleList.ToArray());
288288
mesh.Triangles.Add(topQuadTris.ToArray());
289-
mesh.Triangles.Add(_newTriangleList.ToArray());
289+
//mesh.Triangles.Add(_newTriangleList.ToArray());
290290
return mesh;
291291
}
292292
#endregion

Runtime/Mapbox/BaseModule/Data/TerrainStrategies/FlatTerrainStrategy.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ public override void RegisterTile(UnityMapTile tile, bool createElevatedMesh)
3131

3232
if (meshFilter.sharedMesh.vertexCount != RequiredVertexCount)
3333
{
34-
if (_elevationOptions.sideWallOptions.isActive)
35-
{
36-
var firstMat = tile.MeshRenderer.materials[0];
37-
tile.MeshRenderer.materials = new Material[2]
38-
{
39-
firstMat,
40-
_elevationOptions.sideWallOptions.wallMaterial
41-
};
42-
}
34+
// if (_elevationOptions.sideWallOptions.isActive)
35+
// {
36+
// var firstMat = tile.MeshRenderer.materials[0];
37+
// tile.MeshRenderer.materials = new Material[2]
38+
// {
39+
// firstMat,
40+
// _elevationOptions.sideWallOptions.wallMaterial
41+
// };
42+
// }
4343
// }
4444
//
4545
// if ((int)tile.ElevationType != (int)ElevationLayerType.FlatTerrain)

Runtime/Mapbox/BaseModule/Data/TerrainStrategies/Settings/TerrainSideWallOptions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,5 @@ public class TerrainSideWallOptions
1010
public bool isActive = false;
1111
[Tooltip("Height of side walls.")]
1212
public float wallHeight = 10;
13-
[Tooltip("Unity material to use for side walls.")]
14-
public Material wallMaterial;
1513
}
1614
}

Runtime/Mapbox/ImageModule/Terrain/TerrainLayerModule.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public TerrainLayerModule(Source<TerrainData> source, TerrainLayerModuleSettings
2626
_settings = settings;
2727
_retainedTerrainTiles = new HashSet<CanonicalTileId>();
2828
_rasterSource = source;
29-
_terrainStrategy = new FlatTerrainStrategy(); //new ElevatedTerrainStrategy();
29+
_terrainStrategy = new ElevatedTerrainStrategy();
3030
}
3131

3232
public virtual IEnumerator Initialize()

Runtime/Mapbox/ImageModule/Terrain/TerrainLayerModuleSettings.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ public class TerrainLayerModuleSettings
1717

1818
[Tooltip("Tile outside this range will be rejected.")]
1919
public Vector2 RejectTilesOutsideZoom = new Vector2(12, 16);
20+
21+
public ElevationLayerProperties ElevationLayerProperties;
2022
}
2123
}

0 commit comments

Comments
 (0)