Upgrade Flow to v0.188.0 (#12588)

* Upgrade Flow to v0.188.0

* Revert flow method-unbinding fixes and suppress errors

---------

Co-authored-by: Stepan Kuzmin <stepan.kuzmin@mapbox.com>

Author: davojta

.flowconfig

@@ -30,7 +30,7 @@
 .*/test/build/downstream-flow-fixture/.*
 
 [version]
-0.152.0
+0.188.0
 
 [options]
 

bench/lib/benchmark.js

@@ -97,6 +97,7 @@ class Benchmark {
         return this._end();
     }
 
+    // $FlowFixMe[duplicate-class-member]
     _measureAsync(): Promise<Array<Measurement>> {
         const time = performance.now() - this._start;
         this._elapsed += time;

bench/lib/tile_parser.js

@@ -102,7 +102,7 @@ export default class TileParser {
         return Promise.all([
             createStyle(this.styleJSON),
             fetchTileJSON(mapStub._requestManager, (this.styleJSON.sources[this.sourceID]: any).url)
-        ]).then(([style: Style, tileJSON: TileJSON]) => {
+        ]).then(([style, tileJSON]: [Style, TileJSON]) => {
             this.style = style;
             this.tileJSON = tileJSON;
         });

flow-typed/geojson.js

@@ -27,12 +27,12 @@ declare module "@mapbox/geojson-types" {
         geometries: Array<GeoJSONGeometry>
     };
 
-    declare export type GeoJSONFeature = {
-        type: 'Feature',
-        geometry: ?GeoJSONGeometry,
-        properties: ?{},
-        id?: number | string
-    };
+    declare export interface GeoJSONFeature {
+        type: 'Feature';
+        geometry: ?GeoJSONGeometry;
+        properties: ?{};
+        id?: number | string;
+    }
 
     declare export type GeoJSONFeatureCollection = {
         type: 'FeatureCollection',

package.json

@@ -61,7 +61,7 @@
     "eslint-plugin-html": "^7.1.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsdoc": "^39.6.4",
-    "flow-bin": "0.152.0",
+    "flow-bin": "0.188.0",
     "gl": "6.0.2",
     "glob": "^8.0.3",
     "is-builtin-module": "^3.2.0",

src/data/bucket/circle_bucket.js

@@ -107,6 +107,7 @@ class CircleBucket<Layer: CircleStyleLayer | HeatmapStyleLayer> implements Bucke
             const needGeometry = this.layers[0]._featureFilter.needGeometry;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
 
+            // $FlowFixMe[method-unbinding]
             if (!this.layers[0]._featureFilter.filter(new EvaluationParameters(this.zoom), evaluationFeature, canonical)) continue;
 
             const sortKey = circleSortKey ?

src/data/bucket/fill_bucket.js

@@ -89,6 +89,7 @@ class FillBucket implements Bucket {
             const needGeometry = this.layers[0]._featureFilter.needGeometry;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
 
+            // $FlowFixMe[method-unbinding]
             if (!this.layers[0]._featureFilter.filter(new EvaluationParameters(this.zoom), evaluationFeature, canonical)) continue;
 
             const sortKey = fillSortKey ?

src/data/bucket/fill_extrusion_bucket.js

@@ -243,6 +243,7 @@ class FillExtrusionBucket implements Bucket {
             const needGeometry = this.layers[0]._featureFilter.needGeometry;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
 
+            // $FlowFixMe[method-unbinding]
             if (!this.layers[0]._featureFilter.filter(new EvaluationParameters(this.zoom), evaluationFeature, canonical)) continue;
 
             const bucketFeature: BucketFeature = {

src/data/bucket/line_bucket.js

@@ -146,6 +146,7 @@ class LineBucket implements Bucket {
             const needGeometry = this.layers[0]._featureFilter.needGeometry;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
 
+            // $FlowFixMe[method-unbinding]
             if (!this.layers[0]._featureFilter.filter(new EvaluationParameters(this.zoom), evaluationFeature, canonical)) continue;
 
             const sortKey = lineSortKey ?

src/data/bucket/symbol_bucket.js

@@ -506,6 +506,7 @@ class SymbolBucket implements Bucket {
 
             const needGeometry = layer._featureFilter.needGeometry;
             const evaluationFeature = toEvaluationFeature(feature, needGeometry);
+            // $FlowFixMe[method-unbinding]
             if (!layer._featureFilter.filter(globalProperties, evaluationFeature, canonical)) {
                 continue;
             }