correct script unloading handling

Author: makspll

crates/bevy_mod_scripting_core/src/asset.rs

@@ -252,10 +252,20 @@ pub(crate) fn sync_script_data<P: IntoScriptPluginParams>(
     mut commands: Commands,
 ) {
     for event in events.read() {
+        let metadata = match event {
+            ScriptAssetEvent::Added(script_metadata)
+            | ScriptAssetEvent::Removed(script_metadata)
+            | ScriptAssetEvent::Modified(script_metadata) => script_metadata,
+        };
+
+        if metadata.language != P::LANGUAGE {
+            continue;
+        }
+
         trace!("{}: Received script asset event: {:?}", P::LANGUAGE, event);
         match event {
             // emitted when a new script asset is loaded for the first time
-            ScriptAssetEvent::Added(metadata) | ScriptAssetEvent::Modified(metadata) => {
+            ScriptAssetEvent::Added(_) | ScriptAssetEvent::Modified(_) => {
                 if metadata.language != P::LANGUAGE {
                     trace!(
                         "{}: Script asset with id: {} is for a different langauge than this sync system. Skipping.",
@@ -275,7 +285,7 @@ pub(crate) fn sync_script_data<P: IntoScriptPluginParams>(
                     ));
                 }
             }
-            ScriptAssetEvent::Removed(metadata) => {
+            ScriptAssetEvent::Removed(_) => {
                 info!("{}: Deleting Script: {:?}", P::LANGUAGE, metadata.script_id,);
                 commands.queue(DeleteScript::<P>::new(metadata.script_id.clone()));
             }

crates/bevy_mod_scripting_core/src/handler.rs

@@ -16,7 +16,7 @@ use bevy::{
         system::{Resource, SystemState},
         world::World,
     },
-    log::trace,
+    log::{trace, trace_once},
     prelude::{EventReader, Events, Query, Ref},
 };
 
@@ -127,17 +127,11 @@ pub(crate) fn event_handler_internal<L: IntoCallbackLabel, P: IntoScriptPluginPa
                     }
                     _ => (),
                 }
-                trace!(
-                    "{}: Handling event for script {} on entity {:?}",
-                    P::LANGUAGE,
-                    script_id,
-                    entity
-                );
                 let script = match res_ctxt.scripts.scripts.get(script_id) {
                     Some(s) => s,
                     None => {
-                        trace!(
-                            "{}: Script `{}` on entity `{:?}` is either still loading or doesn't exist, ignoring.",
+                        trace_once!(
+                            "{}: Script `{}` on entity `{:?}` is either still loading or doesn't exist, ignoring until the corresponding script is loaded.",
                             P::LANGUAGE,
                             script_id, entity
                         );