Skip to content

Commit 59d65f8

Browse files
committed
fix test
1 parent d26080b commit 59d65f8

File tree

4 files changed

+23
-3
lines changed

4 files changed

+23
-3
lines changed

assets/tests/add_system/system_cannot_access_unspecified_resource_in_non_exclusive_system__RETURNS.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ function my_non_exclusive_system()
1919
local ResourceType = world.get_type_by_name("TestResource")
2020
assert_throws(function()
2121
local res = world.get_resource(ResourceType)
22-
end, ".*cannot claim access to.*")
22+
local blah = res.blahblah
23+
end, ".*annot claim access to.*")
2324
end
2425

2526

assets/tests/add_system/system_cannot_access_unspecified_resource_in_non_exclusive_system__RETURNS.rhai

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ fn my_non_exclusive_system() {
1313
let ResourceType = world.get_type_by_name.call("TestResource");
1414
assert_throws(|| {
1515
let res = world.get_resource.call(ResourceType);
16-
}, ".*Cannot claim access to.*");
16+
let blah = res.blahblah
17+
}, ".*annot claim access to.*");
1718
}
1819

1920
fn on_test_post_update() {

crates/bevy_mod_scripting_core/src/bindings/access_map.rs

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1219,4 +1219,23 @@ mod test {
12191219
assert!(!subset_access_map.claim_write_access(2));
12201220
assert!(!subset_access_map.claim_global_access());
12211221
}
1222+
1223+
#[test]
1224+
fn subset_map_retains_subset_in_scope() {
1225+
let access_map = AccessMap::default();
1226+
let subset_access_map = SubsetAccessMap {
1227+
inner: access_map,
1228+
subset: Box::new(|id| id == 1),
1229+
};
1230+
1231+
subset_access_map.with_scope(|| {
1232+
assert!(subset_access_map.claim_read_access(1));
1233+
assert!(!subset_access_map.claim_read_access(2));
1234+
assert!(!subset_access_map.claim_write_access(2));
1235+
});
1236+
1237+
assert!(subset_access_map.claim_read_access(1));
1238+
assert!(!subset_access_map.claim_read_access(2));
1239+
assert!(!subset_access_map.claim_write_access(2));
1240+
}
12221241
}

crates/bevy_mod_scripting_core/src/bindings/script_system.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,6 @@ impl<P: IntoScriptPluginParams> System for DynamicScriptSystem<P> {
413413
};
414414

415415
let mut payload = Vec::with_capacity(state.system_params.len());
416-
417416
let guard = if self.exclusive {
418417
// safety: we are an exclusive system, therefore the cell allows us to do this
419418
let world = unsafe { world.world_mut() };

0 commit comments

Comments
 (0)