Merge pull request #197 from mailjet/issue_#53

fix: removed dependency bluebird; small fix for tests

Author: scroll17

mailjet-client.js

@@ -39,7 +39,6 @@ const ACTION = 2
 
 const qs = require('querystring')
 const request = require('superagent')
-const Promise = require('bluebird')
 const _path = require('path')
 const JSONb = require('json-bigint')({ storeAsString: true })
 const version = require('./package.json').version

package-lock.json

@@ -7,7 +7,6 @@
     "test": "test"
   },
   "dependencies": {
-    "bluebird": "^3.5.0",
     "json-bigint": "^1.0.0",
     "qs": "^6.5.0",
     "superagent": "^7.1.1",

package.json

@@ -7,7 +7,6 @@ var Mailjet = require('../mailjet-client')
 var chai = require('chai')
 var expect = chai.expect
 var should = chai.should() // eslint-disable-line no-unused-vars
-var Promise = require('bluebird')
 
 describe('Basic Error Handling', function () {
   API_TOKEN = API_TOKEN || '#invalidToken'
@@ -133,7 +132,7 @@ describe('Basic Error Handling', function () {
         it('check v3 error message', function (done) {
           contact.request()
             .then(function (result) {
-              result.body.should.be.a('object')
+              expect(result.body).should.be.a('object')
               expect(result.response.statusCode).to.equal(200)
               done()
             })
@@ -146,7 +145,7 @@ describe('Basic Error Handling', function () {
         it('check v3 error status code', function (done) {
           contact.request()
             .then(function (result) {
-              result.body.should.be.a('object')
+              expect(result.body).should.be.a('object')
               expect(result.response.statusCode).to.equal(200)
               done()
             })

test/test-error-handling.js

@@ -5,7 +5,6 @@ var Mailjet = require('../mailjet-client')
 var chai = require('chai')
 var expect = chai.expect
 var should = chai.should() // eslint-disable-line no-unused-vars
-var Promise = require('bluebird')
 
 if (typeof API_TOKEN === 'undefined') {
   throw new Error(

test/test-sms.js

@@ -17,7 +17,6 @@ var Mailjet = require('../mailjet-client')
 var chai = require('chai')
 var expect = chai.expect
 var should = chai.should() // eslint-disable-line no-unused-vars
-var Promise = require('bluebird')
 var nock = require('nock')
 
 if (typeof API_KEY === 'undefined' || typeof API_SECRET === 'undefined') {
@@ -69,7 +68,7 @@ describe('Basic Usage', function () {
       it('calls the contact ressource instance whith no parameters', function (done) {
         contact.request()
           .then(function (result) {
-            result.body.should.be.a('object')
+            expect(result.body).should.be.a('object')
             expect(result.response.statusCode).to.equal(200)
             done()
           })
@@ -83,7 +82,7 @@ describe('Basic Usage', function () {
       it('calls the contact ressource instance whith parameters', function (done) {
         var promise = contact.request({Name: 'Guillaume Badi'})
           .then(function (result) {
-            result.body.should.be.a('object')
+            expect(result.body).should.be.a('object')
             expect(result.response.statusCode).to.be.within(200, 201)
             done()
           })
@@ -97,7 +96,7 @@ describe('Basic Usage', function () {
 
       it('calls the contact ressource instance with empty parameters', function (done) {
         contact.request({}).then(function (result) {
-          result.body.should.be.a('object')
+          expect(result.body).should.be.a('object')
           expect(result.response.statusCode).to.be.within(200, 201)
           done()
         })