Skip to content

Commit d6bc770

Browse files
authored
Merge pull request #41 from mailchimp/fix/header-spacing
Ensure consistent header and sub header spacing between block and shortcode output
2 parents fb2b4b8 + e9a2dc7 commit d6bc770

File tree

1 file changed

+20
-3
lines changed

1 file changed

+20
-3
lines changed

mailchimp_widget.php

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ function mailchimp_sf_signup_form( $args = array() ) {
2323

2424
// See if we have valid Merge Vars
2525
if ( ! is_array( $mv ) ) {
26-
echo wp_kses_post( $before_widget );
26+
if ( ! empty( $before_widget ) ) {
27+
echo wp_kses_post( $before_widget );
28+
} else {
29+
echo '<div class="mc_container">';
30+
}
2731
?>
2832
<div class="mc_error_msg">
2933
<?php
@@ -39,12 +43,21 @@ function mailchimp_sf_signup_form( $args = array() ) {
3943
?>
4044
</div>
4145
<?php
42-
echo wp_kses_post( $after_widget );
46+
if ( ! empty( $after_widget ) ) {
47+
echo wp_kses_post( $after_widget );
48+
}
49+
50+
if ( empty( $before_widget ) ) {
51+
echo '</div>';
52+
}
53+
4354
return;
4455
}
4556

4657
if ( ! empty( $before_widget ) ) {
4758
echo wp_kses_post( $before_widget );
59+
} else {
60+
echo '<div class="mc_container">';
4861
}
4962

5063
$header = get_option( 'mc_header_content' );
@@ -72,7 +85,7 @@ function mailchimp_sf_signup_form( $args = array() ) {
7285
}
7386
#mc_subheader {
7487
line-height: 1.25em;
75-
margin-bottom: 18px;
88+
margin: 18px 0;
7689
}
7790
.mc_merge_var {
7891
margin-bottom: 1.0em;
@@ -275,6 +288,10 @@ function mailchimp_sf_signup_form( $args = array() ) {
275288
if ( ! empty( $after_widget ) ) {
276289
echo wp_kses_post( $after_widget );
277290
}
291+
292+
if ( empty( $before_widget ) ) {
293+
echo '</div>';
294+
}
278295
}
279296

280297
/**

0 commit comments

Comments
 (0)