Skip to content

Commit 23112f9

Browse files
iamdharmeshdkotter
andauthored
Apply suggestions from code review
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
1 parent c520dd3 commit 23112f9

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

includes/class-mailchimp-admin.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ public function init() {
3737

3838
/**
3939
* Start the OAuth process.
40+
*
4041
* This function is called via AJAX.
41-
* It start the OAuth process by the calling the oAuth middleware server and responding the response to the front-end.
42+
* It starts the OAuth process by the calling the OAuth middleware server and sending the response to the front-end.
4243
*/
4344
public function start_oauth_process() {
4445
// Validate the nonce and permissions.
@@ -86,8 +87,9 @@ public function start_oauth_process() {
8687

8788
/**
8889
* Finish the OAuth process.
90+
*
8991
* This function is called via AJAX.
90-
* This function finishes the OAuth process by the sending temporary token back to the oAuth server.
92+
* This function finishes the OAuth process by the sending a temporary token back to the OAuth server.
9193
*/
9294
public function finish_oauth_process() {
9395
// Validate the nonce and permissions.

includes/class-mailchimp-data-encryption.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/**
33
* Class responsible for encrypting and decrypting data.
44
*
5-
* @package Mailchimp
5+
* @package Mailchimp
66
*/
77

88
// Exit if accessed directly.
@@ -121,7 +121,7 @@ private function get_default_key() {
121121
return LOGGED_IN_KEY;
122122
}
123123

124-
// If this is reached, you're either not on a live site or have a serious security issue.
124+
// Ideally this default is never used but we have it just in case.
125125
return 'vJgwa_qf0u(k!uir[rB);g;DciNAKuX;+q&`A+z&m6kX3Y|$q.U3:Q>!$)6CA+=O';
126126
}
127127

@@ -141,7 +141,7 @@ private function get_default_salt() {
141141
return LOGGED_IN_SALT;
142142
}
143143

144-
// If this is reached, you're either not on a live site or have a serious security issue.
144+
// Ideally this default is never used but we have it just in case.
145145
return '|qhC}/w6q+$V`H>wM:AtNpg/{s)g<k{F:WMcvJJD[K6c_Kb1OEy^Yx7f|$Ovm+X|';
146146
}
147147
}

views/setup_page.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
</table>
7272
<p class="oauth-error error_msg" style="display:none;"></p>
7373
<div id="login-popup-blocked-modal" style="display:none;">
74-
<p><?php esc_html_e( 'Please allow your browser to show popups for this page.', 'distributor' ); ?></p>
74+
<p><?php esc_html_e( 'Please allow your browser to show popups for this page.', 'mailchimp' ); ?></p>
7575
<div class="footer">
7676
<a href="https://mailchimp.com/help/enable-pop-ups-in-your-browser/"><!--TODO: This link not working fix this. -->
7777
<?php esc_html_e( 'How to Enable Pop-ups in Your Browser', 'mailchimp' ); ?>

0 commit comments

Comments
 (0)