Skip to content

Commit 12c21f4

Browse files
iamdharmeshdkotter
andauthored
Apply suggestions from code review
Co-authored-by: Darin Kotter <darin.kotter@gmail.com>
1 parent aec9ced commit 12c21f4

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

includes/blocks/class-mailchimp-list-subscribe-form-blocks.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
}
1212

1313
/**
14-
* Class Mailchimp_Admin
14+
* Class Mailchimp_List_Subscribe_Form_Blocks
1515
*
16-
* @since 1.6.0
16+
* @since x.x.x
1717
*/
1818
class Mailchimp_List_Subscribe_Form_Blocks {
1919

includes/blocks/mailchimp-form-field/field-markup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22
/**
3-
* Displays a signup form.
3+
* Displays a form field.
44
*
55
* @package Mailchimp
66
*/

includes/blocks/mailchimp/edit.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const SelectListPlaceholder = () => {
2727
icon={Icon}
2828
label={__('Mailchimp Block', 'mailchimp')}
2929
instructions={__(
30-
'Please select the Mailchimp list in block settings sidebar.',
30+
'Please select the Mailchimp list in the block settings sidebar.',
3131
'mailchimp',
3232
)}
3333
/>
@@ -95,7 +95,7 @@ export const BlockEdit = (props) => {
9595
setError('');
9696
setIsLoading(true);
9797

98-
// Fetch data from your API
98+
// Fetch data from API.
9999
apiFetch({ path: `/mailchimp/v1/list-data/${listId}` })
100100
.then((data) => {
101101
if (replaceBlocks) {
@@ -245,7 +245,7 @@ export const BlockEdit = (props) => {
245245
<RichText
246246
className="mailchimp-block__header mc_custom_border_hdr"
247247
tagName="h2"
248-
placeholder={__('Enter a header.', 'mailchimp')}
248+
placeholder={__('Enter a header (optional)', 'mailchimp')}
249249
value={header}
250250
onChange={(header) => setAttributes({ header })}
251251
/>
@@ -255,7 +255,7 @@ export const BlockEdit = (props) => {
255255
<RichText
256256
className="mailchimp-block__sub-header"
257257
tagName="h3"
258-
placeholder={__('Enter a sub header.', 'mailchimp')}
258+
placeholder={__('Enter a sub header (optional)', 'mailchimp')}
259259
value={sub_header}
260260
onChange={(sub_header) => setAttributes({ sub_header })}
261261
/>
@@ -292,7 +292,7 @@ export const BlockEdit = (props) => {
292292
id="mc_signup_submit"
293293
className="button"
294294
tagName="button"
295-
placeholder={__('Enter a button text.', 'mailchimp')}
295+
placeholder={__('Enter button text.', 'mailchimp')}
296296
value={submit_text}
297297
onChange={(submit_text) =>
298298
setAttributes({ submit_text })
@@ -359,12 +359,12 @@ export const BlockEdit = (props) => {
359359
</PanelBody>
360360
<PanelBody title={__('Form Settings', 'mailchimp')} initialOpen={false}>
361361
<ToggleControl
362-
label={__('Double Opt-In', 'mailchimp')}
362+
label={__('Double opt-in', 'mailchimp')}
363363
checked={double_opt_in}
364364
className="mailchimp-double-opt-in"
365365
onChange={() => setAttributes({ double_opt_in: !double_opt_in })}
366366
help={__(
367-
"Before new your subscribers are added via the plugin, they'll need to confirm their email address.",
367+
"Before new subscribers are added to your list, they'll need to confirm their email address.",
368368
'mailchimp',
369369
)}
370370
__nextHasNoMarginBottom
@@ -379,20 +379,20 @@ export const BlockEdit = (props) => {
379379
})
380380
}
381381
help={__(
382-
"If an existing subscriber fills out this form, we will update their information with what's provided.",
382+
"If an existing subscriber submits the form, their information will be updated with what's provided.",
383383
'mailchimp',
384384
)}
385385
__nextHasNoMarginBottom
386386
/>
387387
<ToggleControl
388-
label={__('Include Unsubscribe link', 'mailchimp')}
388+
label={__('Include unsubscribe link', 'mailchimp')}
389389
checked={show_unsubscribe_link}
390390
className="mailchimp-unsubscribe-link"
391391
onChange={() =>
392392
setAttributes({ show_unsubscribe_link: !show_unsubscribe_link })
393393
}
394394
help={__(
395-
"We'll automatically add a link to your list's unsubscribe form.",
395+
"Automatically add a link to your list's unsubscribe form.",
396396
'mailchimp',
397397
)}
398398
__nextHasNoMarginBottom

0 commit comments

Comments
 (0)