feat: allow to pass a lambda to set the title of the editor window

Author: did

app/helpers/maglev/editor_helper.rb

@@ -20,7 +20,14 @@ def api_base_path
     end
 
     def editor_window_title
-      maglev_config.title.presence || 'Maglev - EDITOR'
+      case maglev_config.title
+      when nil
+        'Maglev - EDITOR'
+      when String
+        maglev_config.title
+      when Proc
+        instance_exec(maglev_site, &maglev_config.title)
+      end
     end
 
     def editor_primary_hex_color

app/services/maglev/persist_page.rb

@@ -16,7 +16,6 @@ def call
       ActiveRecord::Base.transaction do
         persist_page!
         persist_site!
-        persist_repositories!
         persist_style!
         page
       end
@@ -46,26 +45,6 @@ def persist_site!
       site.save!
     end
 
-    def persist_repositories!
-      scoped_sections = page_attributes[:sections].each do |section_attributes|
-        type = section_attributes[:type]
-        scope = theme.find_scope(type)
-        next if scope.blank?
-
-        # section 1 (scope = dogs) 
-        # section 2
-        # section 3 (scope = dogs)
-        # section 4 (scope = cats)
-
-        repository = Maglev::SectionRepository.find_or_initialize_by(name: scope)
-        repository.attributes = { sections: [section_attributes] }
-
-        repository.prepare_sections(theme)
-        
-        repository.save!
-      end
-    end
-
     def persist_style!
       return if site_attributes&.dig(:style).blank?
 

lib/generators/maglev/templates/install/config/initializers/maglev.rb

@@ -3,6 +3,7 @@
 Maglev.configure do |config|
   # Title of the Editor window
   # config.title = 'Maglev - Editor'
+  # config.title = ->(site) { "#{site.name} 👋" }
 
   # Logo of the Editor (top left corner).
   # Put your custom logo in the app/assets/images folder of your Rails application.

spec/factories/maglev/themes.rb

@@ -86,15 +86,6 @@
                                                       site_scoped: true,
                                                       settings: [{ label: 'Copyright', id: 'copyright', type: 'text' }],
                                                       blocks: []
-                                                    }.with_indifferent_access),
-                                                    Maglev::Section.build({
-                                                      theme: theme,
-                                                      name: 'Ads',
-                                                      id: 'ads',
-                                                      category: 'features',
-                                                      scope: 'shoes',
-                                                      settings: [{ id: 'title', type: 'text' }],
-                                                      blocks: []
                                                     }.with_indifferent_access)
                                                   ])
     end

spec/helpers/maglev/editor_helper_spec.rb

@@ -34,13 +34,21 @@ def maglev_site; end
       expect(subject).to eq 'Maglev - EDITOR'
     end
 
-    context 'the developer has set a custom title' do
+    context 'the developer has set a custom title (String)' do
       let(:title) { 'My awesome CMS' }
 
       it 'returns the new title' do
         expect(subject).to eq 'My awesome CMS'
       end
     end
+
+    context 'the developer has set a custom title (Proc)' do
+      let(:title) { ->(site) { "#{site.name}!" } }
+
+      it 'returns the new title' do
+        expect(subject).to eq 'My awesome site!'
+      end
+    end
   end
 
   describe '#editor_primary_hex_color' do

spec/services/maglev/persist_page_spec.rb

@@ -30,15 +30,6 @@
     end
   end
 
-  context 'Given one of the sections is tied to a repository' do
-    let!(:page) { create(:page) }
-    let(:page_attributes) { attributes_for(:page, :with_ads) }
-
-    it 'creates a section repository in the DB (since the ads section belongs to a scope)' do
-      expect { subject }.to change(Maglev::Page, :count).by(0).and change(Maglev::SectionRepository, :count).by(1)
-    end
-  end
-
   context 'Given the site attributes are not empty' do
     let(:page) { create(:page) }
     let(:page_attributes) { attributes_for(:page, :with_navbar) }