Re-render graph also when engine is changed

magjac · magjac · commit d3bceb55eb2b · 2018-08-29T06:49:16.000+02:00
Amends d0c44e9
diff --git a/src/Graph.js b/src/Graph.js
@@ -49,6 +49,7 @@ class Graph extends React.Component {
     this.pendingUpdate = false;
     this.rendering = false;
     this.prevFit = null;
+    this.prevEngine = null;
     this.prevDotSrc = '';
   }
 
@@ -91,7 +92,7 @@ class Graph extends React.Component {
     if (this.props.dotSrc.length === 0) {
       return;
     }
-    if (this.props.dotSrc === this.prevDotSrc) {
+    if (this.props.dotSrc === this.prevDotSrc && this.props.engine === this.prevEngine) {
       return;
     }
     if (this.rendering) {
@@ -111,6 +112,7 @@ class Graph extends React.Component {
       this.prevFit = this.props.fit;
     }
     this.prevDotSrc = this.props.dotSrc;
+    this.prevEngine = this.props.engine;
     try {
       this.prelDotGraph = new DotGraph(this.props.dotSrc);
     }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ class Graph extends React.Component {`
`49`	`49`	`this.pendingUpdate = false;`
`50`	`50`	`this.rendering = false;`
`51`	`51`	`this.prevFit = null;`
	`52`	`+ this.prevEngine = null;`
`52`	`53`	`this.prevDotSrc = '';`
`53`	`54`	`}`
`54`	`55`
`@@ -91,7 +92,7 @@ class Graph extends React.Component {`
`91`	`92`	`if (this.props.dotSrc.length === 0) {`
`92`	`93`	`return;`
`93`	`94`	`}`
`94`		`- if (this.props.dotSrc === this.prevDotSrc) {`
	`95`	`+ if (this.props.dotSrc === this.prevDotSrc && this.props.engine === this.prevEngine) {`
`95`	`96`	`return;`
`96`	`97`	`}`
`97`	`98`	`if (this.rendering) {`
`@@ -111,6 +112,7 @@ class Graph extends React.Component {`
`111`	`112`	`this.prevFit = this.props.fit;`
`112`	`113`	`}`
`113`	`114`	`this.prevDotSrc = this.props.dotSrc;`
	`115`	`+ this.prevEngine = this.props.engine;`
`114`	`116`	`try {`
`115`	`117`	`this.prelDotGraph = new DotGraph(this.props.dotSrc);`
`116`	`118`	`}`