Add JSON parsing to File resolver

Author: bbatsche

src/Resolver/File.php

@@ -81,6 +81,16 @@ public function resolve($definition)
             $path = realpath($this->getIterator()->getRootDefinition()->getBasepath() . \DIRECTORY_SEPARATOR . $path);
         }
 
-        return file_get_contents($path);
+        $content = file_get_contents($path);
+
+        if (pathinfo($path, PATHINFO_EXTENSION) == 'json') {
+            $content = json_decode($content, true);
+
+            if (json_last_error() !== JSON_ERROR_NONE) {
+                throw new \RuntimeException('Failed to parse ' . basename($path) . ': ' . json_last_error_msg());
+            }
+        }
+
+        return $content;
     }
 }

test/Resolver/FileTest.php

@@ -42,6 +42,9 @@ protected function setUp(): void
             ->andReturnUsing(function (string $key, Definition $definition) {
                 return $definition->get($key);
             });
+
+        $this->mockIterator->shouldReceive('getRootDefinition->getBasePath')
+            ->andReturn(__DIR__);
     }
 
     public function testIndicator(): void
@@ -86,14 +89,25 @@ public function testIsValid(): void
         verify($this->resolver->isValid($invalidParse))->is()->false();
     }
 
+    public function testJsonException(): void
+    {
+        $this->expectException(\RuntimeException::class);
+        // Omit portion of the error message that comes from buitlin PHP value
+        $this->expectExceptionMessage('Failed to parse invalid.json: ');
+
+        $this->resolver->resolve('./_data/invalid.json');
+    }
+
     public function testResolve(): void
     {
         $definition = new Definition(['file' => './_data/sample.txt']);
 
-        $this->mockIterator->shouldReceive('getRootDefinition->getBasePath')
-            ->andReturn(__DIR__);
-
         verify($this->resolver->resolve('./_data/sample.txt'))->is()->sameAs("This is a sample file.\n");
         verify($this->resolver->resolve($definition))->is()->sameAs("This is a sample file.\n");
     }
+
+    public function testResolveJson(): void
+    {
+        verify($this->resolver->resolve('./_data/sample.json'))->is()->sameAs(['json' => true]);
+    }
 }

test/Resolver/_data/invalid.json

@@ -0,0 +1 @@
+{ 'json': false

test/Resolver/_data/sample.json

@@ -0,0 +1 @@
+{"json": true}