From 3ccbcff79e647026586aa577a0fa16ccb2dc0b68 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 7 Mar 2023 13:42:20 +0000 Subject: [PATCH 1/3] Remove forbidden @author tag --- app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php | 2 -- .../Eav/Block/Adminhtml/Attribute/Edit/Options/Labels.php | 1 - .../Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php | 2 -- .../Adminhtml/System/Config/Source/Inputtype/Validator.php | 2 -- app/code/Magento/Eav/Model/Attribute.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php | 1 - app/code/Magento/Eav/Model/Attribute/Data/Boolean.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Date.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Hidden.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Image.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Multiline.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Multiselect.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Select.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Text.php | 2 -- app/code/Magento/Eav/Model/Attribute/Data/Textarea.php | 2 -- app/code/Magento/Eav/Model/AttributeDataFactory.php | 2 -- app/code/Magento/Eav/Model/Entity/AbstractEntity.php | 1 - .../Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php | 2 -- app/code/Magento/Eav/Model/Entity/Attribute/Set.php | 2 -- .../Eav/Model/Entity/Attribute/Source/AbstractSource.php | 1 - app/code/Magento/Eav/Model/Entity/Attribute/Source/Config.php | 2 -- app/code/Magento/Eav/Model/Form/Type.php | 2 -- app/code/Magento/Eav/Model/ResourceModel/Config.php | 2 -- .../Eav/Model/ResourceModel/Entity/Attribute/Collection.php | 1 - .../Model/ResourceModel/Entity/Attribute/Grid/Collection.php | 2 -- .../Magento/Eav/Model/ResourceModel/Entity/Attribute/Option.php | 2 -- .../Model/ResourceModel/Entity/Attribute/Option/Collection.php | 2 -- .../Eav/Model/ResourceModel/Entity/Attribute/Set/Collection.php | 1 - app/code/Magento/Eav/Model/ResourceModel/Entity/Store.php | 2 -- .../Magento/Eav/Model/ResourceModel/Entity/Type/Collection.php | 2 -- app/code/Magento/Eav/Model/ResourceModel/Form/Attribute.php | 2 -- .../Eav/Model/ResourceModel/Form/Attribute/Collection.php | 1 - app/code/Magento/Eav/Model/ResourceModel/Form/Element.php | 2 -- app/code/Magento/Eav/Model/ResourceModel/Form/Fieldset.php | 2 -- app/code/Magento/Eav/Model/ResourceModel/Form/Type.php | 2 -- .../Magento/Eav/Model/ResourceModel/Form/Type/Collection.php | 2 -- app/code/Magento/Eav/Model/Validator/Attribute/Backend.php | 2 -- app/code/Magento/Eav/Model/Validator/Attribute/Data.php | 2 -- 38 files changed, 69 deletions(-) diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php index 577dac5b0c28b..de443bf00c1d4 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php @@ -7,8 +7,6 @@ /** * Eav Attribute Block with additional js scripts in template - * - * @author Magento Core Team */ class Js extends \Magento\Backend\Block\Template { diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Options/Labels.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Options/Labels.php index ad4b3089d5153..249a81b79a7c8 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Options/Labels.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Options/Labels.php @@ -9,7 +9,6 @@ * Attribute add/edit form options tab * * @api - * @author Magento Core Team * @since 100.0.2 */ class Labels extends \Magento\Backend\Block\Template diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php index b8d1be2019064..f126e4d1885f3 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php @@ -10,8 +10,6 @@ /** * Disable form fields - * - * @author Magento Core Team */ class PropertyLocker { diff --git a/app/code/Magento/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php b/app/code/Magento/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php index 72e40404a2905..ca96e45fa5be2 100644 --- a/app/code/Magento/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php +++ b/app/code/Magento/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php @@ -9,8 +9,6 @@ /** * Validator for check input type value - * - * @author Magento Core Team */ class Validator extends InArray { diff --git a/app/code/Magento/Eav/Model/Attribute.php b/app/code/Magento/Eav/Model/Attribute.php index 40f9a4ae4e934..6ee7df0273771 100644 --- a/app/code/Magento/Eav/Model/Attribute.php +++ b/app/code/Magento/Eav/Model/Attribute.php @@ -9,8 +9,6 @@ * * @method \Magento\Eav\Model\Attribute\Data\AbstractData|null getDataModel() * Get data model linked to attribute or null. - * - * @author Magento Core Team */ namespace Magento\Eav\Model; diff --git a/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php b/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php index 8ee18a68b9923..d20238d65cdfc 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php @@ -20,7 +20,6 @@ * * phpcs:disable Magento2.Classes.AbstractApi * @api - * @author Magento Core Team * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @since 100.0.2 */ diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Boolean.php b/app/code/Magento/Eav/Model/Attribute/Data/Boolean.php index 1ffce236f0443..255261c379bb3 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Boolean.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Boolean.php @@ -7,8 +7,6 @@ /** * EAV Entity Attribute Boolean Data Model - * - * @author Magento Core Team */ class Boolean extends \Magento\Eav\Model\Attribute\Data\Select { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Date.php b/app/code/Magento/Eav/Model/Attribute/Data/Date.php index 9bd155354ac0d..5e289b25642be 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Date.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Date.php @@ -9,8 +9,6 @@ /** * EAV Entity Attribute Date Data Model - * - * @author Magento Core Team */ class Date extends \Magento\Eav\Model\Attribute\Data\AbstractData { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Hidden.php b/app/code/Magento/Eav/Model/Attribute/Data/Hidden.php index a413bd110176e..eebeed788a8e0 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Hidden.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Hidden.php @@ -7,8 +7,6 @@ /** * EAV Entity Attribute Hidden text Data Model - * - * @author Magento Core Team */ class Hidden extends \Magento\Eav\Model\Attribute\Data\Text { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Image.php b/app/code/Magento/Eav/Model/Attribute/Data/Image.php index d61a8b5fda5b1..cb5984048a5b9 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Image.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Image.php @@ -9,8 +9,6 @@ /** * EAV Entity Attribute Image File Data Model - * - * @author Magento Core Team */ class Image extends \Magento\Eav\Model\Attribute\Data\File { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Multiline.php b/app/code/Magento/Eav/Model/Attribute/Data/Multiline.php index c1a2f9dc925e8..1cc45823a5734 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Multiline.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Multiline.php @@ -9,8 +9,6 @@ /** * EAV Entity Attribute Multiply line Data Model - * - * @author Magento Core Team */ class Multiline extends \Magento\Eav\Model\Attribute\Data\Text { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Multiselect.php b/app/code/Magento/Eav/Model/Attribute/Data/Multiselect.php index b926ed4d58656..7aaa7d131a07f 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Multiselect.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Multiselect.php @@ -9,8 +9,6 @@ /** * EAV Entity Attribute Multiply select Data Model - * - * @author Magento Core Team */ class Multiselect extends AbstractData { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Select.php b/app/code/Magento/Eav/Model/Attribute/Data/Select.php index f975f24e97657..e6236f0ccaa90 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Select.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Select.php @@ -9,8 +9,6 @@ /** * EAV Entity Attribute Select Data Model - * - * @author Magento Core Team */ class Select extends \Magento\Eav\Model\Attribute\Data\AbstractData { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Text.php b/app/code/Magento/Eav/Model/Attribute/Data/Text.php index c41a65a6bfd3e..93a38d3229399 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Text.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Text.php @@ -10,8 +10,6 @@ /** * EAV Entity Attribute Text Data Model - * - * @author Magento Core Team */ class Text extends \Magento\Eav\Model\Attribute\Data\AbstractData { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Textarea.php b/app/code/Magento/Eav/Model/Attribute/Data/Textarea.php index 453182bc16eba..7eb30f93cc61e 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Textarea.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Textarea.php @@ -7,8 +7,6 @@ /** * EAV Entity Attribute Text Area Data Model - * - * @author Magento Core Team */ class Textarea extends \Magento\Eav\Model\Attribute\Data\Text { diff --git a/app/code/Magento/Eav/Model/AttributeDataFactory.php b/app/code/Magento/Eav/Model/AttributeDataFactory.php index e5844b093e347..41fc3713b429e 100644 --- a/app/code/Magento/Eav/Model/AttributeDataFactory.php +++ b/app/code/Magento/Eav/Model/AttributeDataFactory.php @@ -8,8 +8,6 @@ /** * EAV Entity Attribute Data Factory - * - * @author Magento Core Team */ class AttributeDataFactory { diff --git a/app/code/Magento/Eav/Model/Entity/AbstractEntity.php b/app/code/Magento/Eav/Model/Entity/AbstractEntity.php index f66ade9435813..78d072d5abaf8 100644 --- a/app/code/Magento/Eav/Model/Entity/AbstractEntity.php +++ b/app/code/Magento/Eav/Model/Entity/AbstractEntity.php @@ -28,7 +28,6 @@ * * phpcs:disable Magento2.Classes.AbstractApi * @api - * @author Magento Core Team * @SuppressWarnings(PHPMD.TooManyFields) * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php index 2c7ea1ab9268e..f1a387420d47e 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php @@ -6,8 +6,6 @@ /** * Entity/Attribute/Model - attribute frontend abstract - * - * @author Magento Core Team */ namespace Magento\Eav\Model\Entity\Attribute\Frontend; diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php index 71c090c359fd4..43a612d19c1a5 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php @@ -13,8 +13,6 @@ * @method \Magento\Eav\Model\Entity\Attribute\Set setAttributeSetName(string $value) * @method int getSortOrder() * @method \Magento\Eav\Model\Entity\Attribute\Set setSortOrder(int $value) - * - * @author Magento Core Team */ namespace Magento\Eav\Model\Entity\Attribute; diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php b/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php index 23b6e8792100c..3ec8c4f5a28ce 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php @@ -10,7 +10,6 @@ * Entity/Attribute/Model - attribute selection source abstract * phpcs:disable Magento2.Classes.AbstractApi * @api - * @author Magento Core Team * @SuppressWarnings(PHPMD.NumberOfChildren) * @since 100.0.2 */ diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Source/Config.php b/app/code/Magento/Eav/Model/Entity/Attribute/Source/Config.php index 3768c2cb49db9..3aecc49390866 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Source/Config.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Source/Config.php @@ -9,8 +9,6 @@ * Entity/Attribute/Model - attribute selection source from configuration * * this class should be abstract, but kept usual for legacy purposes - * - * @author Magento Core Team */ class Config extends \Magento\Eav\Model\Entity\Attribute\Source\AbstractSource { diff --git a/app/code/Magento/Eav/Model/Form/Type.php b/app/code/Magento/Eav/Model/Form/Type.php index 361e3faac7b32..e3d132b74111e 100644 --- a/app/code/Magento/Eav/Model/Form/Type.php +++ b/app/code/Magento/Eav/Model/Form/Type.php @@ -18,8 +18,6 @@ * @method \Magento\Eav\Model\Form\Type setTheme(string $value) * @method int getStoreId() * @method \Magento\Eav\Model\Form\Type setStoreId(int $value) - * - * @author Magento Core Team */ class Type extends \Magento\Framework\Model\AbstractModel { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Config.php b/app/code/Magento/Eav/Model/ResourceModel/Config.php index 2b64550e337f6..39db200f9dc98 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Config.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Config.php @@ -7,8 +7,6 @@ /** * Eav Resource Config model - * - * @author Magento Core Team */ class Config extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php index bcd8f2bb04e69..0db9dd7c91390 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Collection.php @@ -22,7 +22,6 @@ * EAV attribute resource collection * * @api - * @author Magento Core Team * @since 100.0.2 * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Grid/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Grid/Collection.php index bf7521f560cfd..7e960a658ad09 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Grid/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Grid/Collection.php @@ -9,8 +9,6 @@ /** * Eav Resource Attribute Set Collection - * - * @author Magento Core Team */ class Collection extends \Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option.php index a7be59e2c05d5..e6741d3da7fba 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option.php @@ -7,8 +7,6 @@ /** * Entity attribute option resource model - * - * @author Magento Core Team */ class Option extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php index 78351020064cf..b445a990924a5 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php @@ -7,8 +7,6 @@ /** * Entity attribute option collection - * - * @author Magento Core Team */ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Set/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Set/Collection.php index 635eca99a276f..7fe41911c4c0f 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Set/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Set/Collection.php @@ -9,7 +9,6 @@ * Eav Resource Attribute Set Collection * * @api - * @author Magento Core Team * @since 100.0.2 */ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Store.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Store.php index 80d8780b69b38..a4380193610d9 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Store.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Store.php @@ -10,8 +10,6 @@ /** * Eav Entity store resource model - * - * @author Magento Core Team */ class Store extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Type/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Type/Collection.php index bfe0010fa94a1..ab04ed52bf4a7 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Type/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Type/Collection.php @@ -7,8 +7,6 @@ /** * Eav Resource Entity Type Collection Model - * - * @author Magento Core Team */ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute.php index 02349ada390ce..f8a6888bf81de 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute.php @@ -6,8 +6,6 @@ /** * EAV Form Attribute Resource Model - * - * @author Magento Core Team */ namespace Magento\Eav\Model\ResourceModel\Form; diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute/Collection.php index 9438178e56085..24ad2b1d4aa6a 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Attribute/Collection.php @@ -9,7 +9,6 @@ * EAV Form Attribute Resource Collection * * @api - * @author Magento Core Team * @since 100.0.2 */ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Element.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Element.php index e137971199004..96c84685f51c0 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Element.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Element.php @@ -7,8 +7,6 @@ /** * Eav Form Element Resource Model - * - * @author Magento Core Team */ class Element extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Fieldset.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Fieldset.php index ddf8d4c8dede9..277007e80f998 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Fieldset.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Fieldset.php @@ -11,8 +11,6 @@ /** * Eav Form Fieldset Resource Model - * - * @author Magento Core Team */ class Fieldset extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Type.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Type.php index 8259be69ade1d..88df8d667df9b 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Type.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Type.php @@ -10,8 +10,6 @@ /** * Eav Form Type Resource Model - * - * @author Magento Core Team */ class Type extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { diff --git a/app/code/Magento/Eav/Model/ResourceModel/Form/Type/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Form/Type/Collection.php index f336c0c9e109a..034ae6c34c6b7 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Form/Type/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Form/Type/Collection.php @@ -6,8 +6,6 @@ /** * Eav Form Type Resource Collection - * - * @author Magento Core Team */ namespace Magento\Eav\Model\ResourceModel\Form\Type; diff --git a/app/code/Magento/Eav/Model/Validator/Attribute/Backend.php b/app/code/Magento/Eav/Model/Validator/Attribute/Backend.php index 8b8a55ebbb35e..1fcdc757701d8 100644 --- a/app/code/Magento/Eav/Model/Validator/Attribute/Backend.php +++ b/app/code/Magento/Eav/Model/Validator/Attribute/Backend.php @@ -7,8 +7,6 @@ /** * Validation EAV entity via EAV attributes' backend models - * - * @author Magento Core Team */ class Backend extends \Magento\Framework\Validator\AbstractValidator { diff --git a/app/code/Magento/Eav/Model/Validator/Attribute/Data.php b/app/code/Magento/Eav/Model/Validator/Attribute/Data.php index 7b29b9dde6790..3d7770ce8f960 100644 --- a/app/code/Magento/Eav/Model/Validator/Attribute/Data.php +++ b/app/code/Magento/Eav/Model/Validator/Attribute/Data.php @@ -12,8 +12,6 @@ /** * EAV attribute data validator - * - * @author Magento Core Team */ class Data extends \Magento\Framework\Validator\AbstractValidator { From e532b974004e2d283e5e52465a102e626e12e0d6 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 14 Mar 2023 21:14:58 +0000 Subject: [PATCH 2/3] Fix static test failures --- .../Eav/Block/Adminhtml/Attribute/Edit/Js.php | 7 +++--- .../Adminhtml/Attribute/PropertyLocker.php | 2 ++ app/code/Magento/Eav/Model/Attribute.php | 15 ++---------- .../Magento/Eav/Model/Attribute/Data/Date.php | 1 + .../Eav/Model/Attribute/Data/Image.php | 3 +++ .../Eav/Model/AttributeDataFactory.php | 15 ++++++------ .../Attribute/Frontend/AbstractFrontend.php | 1 + .../Eav/Model/Entity/Attribute/Set.php | 24 ++++++++++--------- .../Entity/Attribute/Option/Collection.php | 2 -- 9 files changed, 33 insertions(+), 37 deletions(-) diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php index de443bf00c1d4..bec63d4455dff 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/Edit/Js.php @@ -11,11 +11,8 @@ class Js extends \Magento\Backend\Block\Template { /** - * Js template - * * @var string */ - protected $_template = 'Magento_Eav::attribute/edit/js.phtml'; /** @@ -24,7 +21,7 @@ class Js extends \Magento\Backend\Block\Template private $inputtype; /** - * {@inheritdoc} + * @inheritDoc */ public function __construct( \Magento\Backend\Block\Template\Context $context, @@ -36,6 +33,8 @@ public function __construct( } /** + * Return compatible input types + * * @deprecated 102.0.0 Misspelled method * @see getCompatibleInputTypes */ diff --git a/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php b/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php index f126e4d1885f3..d4dd8837cd6d6 100644 --- a/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php +++ b/app/code/Magento/Eav/Block/Adminhtml/Attribute/PropertyLocker.php @@ -37,6 +37,8 @@ public function __construct( } /** + * Lock form data + * * @param \Magento\Framework\Data\Form $form * @return void */ diff --git a/app/code/Magento/Eav/Model/Attribute.php b/app/code/Magento/Eav/Model/Attribute.php index 6ee7df0273771..00112be5c6f0c 100644 --- a/app/code/Magento/Eav/Model/Attribute.php +++ b/app/code/Magento/Eav/Model/Attribute.php @@ -20,21 +20,10 @@ */ class Attribute extends \Magento\Eav\Model\Entity\Attribute { - /** - * Name of the module - * Override it - */ - //const MODULE_NAME = 'Magento_Eav'; - - /** - * Name of the module - * Override it - */ + /** @var string */ protected $_eventObject = 'attribute'; /** - * Active Website instance - * * @var Website */ protected $_website; @@ -186,7 +175,7 @@ public function getMultilineCount() } /** - * {@inheritdoc} + * @inheritDoc */ public function afterDelete() { diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Date.php b/app/code/Magento/Eav/Model/Attribute/Data/Date.php index 5e289b25642be..e0e8f753cfc3e 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Date.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Date.php @@ -26,6 +26,7 @@ public function extractValue(RequestInterface $request) /** * Validate data + * * Return true or array of errors * * @param array|string $value diff --git a/app/code/Magento/Eav/Model/Attribute/Data/Image.php b/app/code/Magento/Eav/Model/Attribute/Data/Image.php index cb5984048a5b9..d880389ca0f47 100644 --- a/app/code/Magento/Eav/Model/Attribute/Data/Image.php +++ b/app/code/Magento/Eav/Model/Attribute/Data/Image.php @@ -29,6 +29,7 @@ protected function _validateByRules($value) $rules = $this->getAttribute()->getValidateRules(); $localStorage = !$this->_directory->getDriver() instanceof ExtendedDriverInterface; $imageProp = $localStorage + // @phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged,Magento2.Functions.DiscouragedFunction.DiscouragedWithAlternative ? @getimagesize($value['tmp_name']) : $this->_directory->getDriver()->getMetadata($value['tmp_name']); $allowImageTypes = ['gif', 'jpg', 'jpeg', 'png']; @@ -42,8 +43,10 @@ protected function _validateByRules($value) } // modify image name + // phpcs:ignore Magento2.Functions.DiscouragedFunction.DiscouragedWithAlternative $extension = pathinfo($value['name'], PATHINFO_EXTENSION); if ($extension !== $imageProp['extension']) { + // phpcs:ignore Magento2.Functions.DiscouragedFunction.DiscouragedWithAlternative $value['name'] = pathinfo($value['name'], PATHINFO_FILENAME) . '.' . $imageProp['extension']; } diff --git a/app/code/Magento/Eav/Model/AttributeDataFactory.php b/app/code/Magento/Eav/Model/AttributeDataFactory.php index 41fc3713b429e..fb37d9988673d 100644 --- a/app/code/Magento/Eav/Model/AttributeDataFactory.php +++ b/app/code/Magento/Eav/Model/AttributeDataFactory.php @@ -11,16 +11,16 @@ */ class AttributeDataFactory { - const OUTPUT_FORMAT_JSON = 'json'; - const OUTPUT_FORMAT_TEXT = 'text'; - const OUTPUT_FORMAT_HTML = 'html'; - const OUTPUT_FORMAT_PDF = 'pdf'; - const OUTPUT_FORMAT_ONELINE = 'oneline'; - const OUTPUT_FORMAT_ARRAY = 'array'; + public const OUTPUT_FORMAT_JSON = 'json'; + public const OUTPUT_FORMAT_TEXT = 'text'; + public const OUTPUT_FORMAT_HTML = 'html'; + public const OUTPUT_FORMAT_PDF = 'pdf'; + public const OUTPUT_FORMAT_ONELINE = 'oneline'; + public const OUTPUT_FORMAT_ARRAY = 'array'; // available only for multiply attributes - // available only for multiply attributes + /** @var array */ protected $_dataModels = []; /** @@ -48,6 +48,7 @@ public function __construct( /** * Return attribute data model by attribute + * * Set entity to data model (need for work) * * @param \Magento\Eav\Model\Attribute $attribute diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php index f1a387420d47e..564c33e2b4aa3 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php @@ -20,6 +20,7 @@ /** * EAV entity attribute form renderer. * + * @phpcs:ignore Magento2.Classes.AbstractApi.AbstractApi * @api * @since 100.0.2 */ diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php index 43a612d19c1a5..9193712c41cc4 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Set.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Set.php @@ -29,13 +29,13 @@ class Set extends \Magento\Framework\Model\AbstractExtensibleModel implements /**#@+ * Constants */ - const KEY_ATTRIBUTE_SET_ID = 'attribute_set_id'; - const KEY_ATTRIBUTE_SET_NAME = 'attribute_set_name'; - const KEY_SORT_ORDER = 'sort_order'; - const KEY_ENTITY_TYPE_ID = 'entity_type_id'; + public const KEY_ATTRIBUTE_SET_ID = 'attribute_set_id'; + public const KEY_ATTRIBUTE_SET_NAME = 'attribute_set_name'; + public const KEY_SORT_ORDER = 'sort_order'; + public const KEY_ENTITY_TYPE_ID = 'entity_type_id'; /**#@-*/ - /**#@-*/ + /** @var \Magento\Framework\Model\ResourceModel\Db\AbstractDb */ protected $_resource; /** @@ -251,6 +251,8 @@ public function organizeData($data) } /** + * Initialise a group model + * * @param array $group * @return Group */ @@ -381,7 +383,7 @@ protected function _getResource() } /** - * {@inheritdoc} + * @inheritDoc * @codeCoverageIgnoreStart */ public function getAttributeSetId() @@ -390,7 +392,7 @@ public function getAttributeSetId() } /** - * {@inheritdoc} + * @inheritDoc */ public function getAttributeSetName() { @@ -398,7 +400,7 @@ public function getAttributeSetName() } /** - * {@inheritdoc} + * @inheritDoc */ public function getSortOrder() { @@ -406,7 +408,7 @@ public function getSortOrder() } /** - * {@inheritdoc} + * @inheritDoc */ public function getEntityTypeId() { @@ -469,7 +471,7 @@ public function setEntityTypeId($entityTypeId) } /** - * {@inheritdoc} + * @inheritDoc * * @return \Magento\Eav\Api\Data\AttributeSetExtensionInterface|null|null */ @@ -479,7 +481,7 @@ public function getExtensionAttributes() } /** - * {@inheritdoc} + * @inheritDoc * * @param \Magento\Eav\Api\Data\AttributeSetExtensionInterface|null $extensionAttributes * @return $this diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php index b445a990924a5..dceb0794cc9c0 100644 --- a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php +++ b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Option/Collection.php @@ -11,8 +11,6 @@ class Collection extends \Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection { /** - * Option value table - * * @var string */ protected $_optionValueTable; From 56da55e536e295ee8d51477e4d0e1c00ef108d3a Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Sun, 9 Apr 2023 17:12:39 +0100 Subject: [PATCH 3/3] Apply code-review suggestion --- app/code/Magento/Eav/Model/AttributeDataFactory.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/code/Magento/Eav/Model/AttributeDataFactory.php b/app/code/Magento/Eav/Model/AttributeDataFactory.php index fb37d9988673d..a81a3cbbd1ef0 100644 --- a/app/code/Magento/Eav/Model/AttributeDataFactory.php +++ b/app/code/Magento/Eav/Model/AttributeDataFactory.php @@ -18,9 +18,7 @@ class AttributeDataFactory public const OUTPUT_FORMAT_ONELINE = 'oneline'; public const OUTPUT_FORMAT_ARRAY = 'array'; - // available only for multiply attributes - - /** @var array */ + /** @var array available only for multiply attributes */ protected $_dataModels = []; /**