From 4055806750f5c4091002a6b98f6a9f8f99291280 Mon Sep 17 00:00:00 2001
From: in-session <info@in-session.de>
Date: Thu, 30 Jun 2022 11:05:17 +0200
Subject: [PATCH] Disable autocomplete for browser saved password

Here there is a validation error if a password is stored and the register block is integrated as a modal.
Since it is the registry page, it should be a new password either way.

Error:
jquery.validate.js:164 Uncaught TypeError: Cannot read properties of undefined (reading 'settings')
    at jQuery.fn.init.rules (jquery.validate.js:164:63)
    at $.<computed>.<computed>._calculateStrength (password-strength-indicator.js:75:42)
    at $.<computed>.<computed>._calculateStrength (widget.js:132:25)
    at HTMLInputElement.handlerProxy (widget.js:611:7)
    at HTMLInputElement.dispatch (jquery.js:5430:49)
    at elemData.handle (jquery.js:5234:47)

Code Reference:
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#browser_compatibility
---
 .../Customer/view/frontend/templates/form/register.phtml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/code/Magento/Customer/view/frontend/templates/form/register.phtml b/app/code/Magento/Customer/view/frontend/templates/form/register.phtml
index 900be3d20bf22..afeaeee76004c 100644
--- a/app/code/Magento/Customer/view/frontend/templates/form/register.phtml
+++ b/app/code/Magento/Customer/view/frontend/templates/form/register.phtml
@@ -255,7 +255,7 @@ $createAccountButtonViewModel = $block->getData('create_account_button_view_mode
                        data-password-min-character-sets="<?=
                         $escaper->escapeHtmlAttr($block->getRequiredCharacterClassesNumber()) ?>"
                        data-validate="{required:true, 'validate-customer-password':true}"
-                       autocomplete="off">
+                       autocomplete="new-password">
                 <div id="password-strength-meter-container" data-role="password-strength-meter" aria-live="polite">
                     <div id="password-strength-meter" class="password-strength-meter">
                         <?= $escaper->escapeHtml(__('Password Strength')) ?>:
@@ -278,7 +278,7 @@ $createAccountButtonViewModel = $block->getData('create_account_button_view_mode
                        id="password-confirmation"
                        class="input-text"
                        data-validate="{required:true, equalTo:'#password'}"
-                       autocomplete="off">
+                       autocomplete="new-password">
             </div>
         </div>
         <div class="field choice" data-bind="scope: 'showPassword'">