From 5dceaa928ff4fd7331126bb9ccf21b621d8b8108 Mon Sep 17 00:00:00 2001 From: Andrii Kasian Date: Thu, 19 Nov 2020 14:01:37 -0600 Subject: [PATCH 1/3] do not call parent constructor --- app/code/Magento/Captcha/Model/DefaultModel.php | 1 - 1 file changed, 1 deletion(-) diff --git a/app/code/Magento/Captcha/Model/DefaultModel.php b/app/code/Magento/Captcha/Model/DefaultModel.php index cf6950ffe8205..c9a5736f9e245 100644 --- a/app/code/Magento/Captcha/Model/DefaultModel.php +++ b/app/code/Magento/Captcha/Model/DefaultModel.php @@ -117,7 +117,6 @@ public function __construct( Random $randomMath = null, ?UserContextInterface $userContext = null ) { - parent::__construct(); $this->session = $session; $this->captchaData = $captchaData; $this->resLogFactory = $resLogFactory; From 94487285fdfe6d2eac59069437230c86d69fba32 Mon Sep 17 00:00:00 2001 From: engcom-Dash Date: Wed, 13 Nov 2024 15:24:22 +0530 Subject: [PATCH 2/3] 30991: fix copyright tag --- app/code/Magento/Captcha/Model/DefaultModel.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Captcha/Model/DefaultModel.php b/app/code/Magento/Captcha/Model/DefaultModel.php index c9a5736f9e245..42fb8c42ae80d 100644 --- a/app/code/Magento/Captcha/Model/DefaultModel.php +++ b/app/code/Magento/Captcha/Model/DefaultModel.php @@ -1,7 +1,7 @@ Date: Wed, 13 Nov 2024 19:17:29 +0530 Subject: [PATCH 3/3] 30991: fix static failures --- app/code/Magento/Captcha/Model/DefaultModel.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Captcha/Model/DefaultModel.php b/app/code/Magento/Captcha/Model/DefaultModel.php index 42fb8c42ae80d..711ca9da377ca 100644 --- a/app/code/Magento/Captcha/Model/DefaultModel.php +++ b/app/code/Magento/Captcha/Model/DefaultModel.php @@ -25,17 +25,17 @@ class DefaultModel extends \Laminas\Captcha\Image implements \Magento\Captcha\Mo /** * Key in session for captcha code */ - const SESSION_WORD = 'word'; + public const SESSION_WORD = 'word'; /** * Min captcha lengths default value */ - const DEFAULT_WORD_LENGTH_FROM = 3; + public const DEFAULT_WORD_LENGTH_FROM = 3; /** * Max captcha lengths default value */ - const DEFAULT_WORD_LENGTH_TO = 5; + public const DEFAULT_WORD_LENGTH_TO = 5; /** * @var Data @@ -576,7 +576,9 @@ protected function randomSize() */ protected function gc() { + // @codingStandardsIgnoreStart return; // required for static testing to pass + // @codingStandardsIgnoreEnd } /**