From cd2b19ec1ed3148fea5b762f665a9acf1e03c980 Mon Sep 17 00:00:00 2001 From: Dmitry Tsymbal Date: Wed, 8 Jul 2020 15:17:45 +0300 Subject: [PATCH 1/3] Contact Us Form Submitting --- ...efrontContactUsInvalidEmailActionGroup.xml | 17 +++++++++++ .../StorefrontContactUsMessagesSection.xml | 3 +- ...torefrontSubmitContactUsFormFailedTest.xml | 30 +++++++++++++++++++ ...orefrontSubmitContactUsFormSuccessTest.xml | 28 +++++++++++++++++ .../Customer/Test/Mftf/Data/CustomerData.xml | 14 +++++++++ 5 files changed, 91 insertions(+), 1 deletion(-) create mode 100644 app/code/Magento/Contact/Test/Mftf/ActionGroup/AssertStorefrontContactUsInvalidEmailActionGroup.xml create mode 100644 app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml create mode 100644 app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml diff --git a/app/code/Magento/Contact/Test/Mftf/ActionGroup/AssertStorefrontContactUsInvalidEmailActionGroup.xml b/app/code/Magento/Contact/Test/Mftf/ActionGroup/AssertStorefrontContactUsInvalidEmailActionGroup.xml new file mode 100644 index 0000000000000..8dd303c031699 --- /dev/null +++ b/app/code/Magento/Contact/Test/Mftf/ActionGroup/AssertStorefrontContactUsInvalidEmailActionGroup.xml @@ -0,0 +1,17 @@ + + + + + + + + + + + diff --git a/app/code/Magento/Contact/Test/Mftf/Section/StorefrontContactUsMessagesSection.xml b/app/code/Magento/Contact/Test/Mftf/Section/StorefrontContactUsMessagesSection.xml index 0970f1f8f6b20..016a96db828fe 100644 --- a/app/code/Magento/Contact/Test/Mftf/Section/StorefrontContactUsMessagesSection.xml +++ b/app/code/Magento/Contact/Test/Mftf/Section/StorefrontContactUsMessagesSection.xml @@ -9,6 +9,7 @@
- + +
diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml new file mode 100644 index 0000000000000..dac7476e17daa --- /dev/null +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml @@ -0,0 +1,30 @@ + + + + + + + + + + <description value="User should have no possibility submit Contact Form if input data is not valid"/> + <group value="contact"/> + </annotations> + + <actionGroup ref="StorefrontOpenContactUsPageActionGroup" stepKey="navigateContactUsPage"/> + <actionGroup ref="StorefrontFillContactUsFormActionGroup" stepKey="fillContactUsForm"> + <argument name="customer" value="Simple_Customer_With_Invalid_Email"/> + <argument name="contactUsData" value="DefaultContactUsData"/> + </actionGroup> + <actionGroup ref="StorefrontSubmitContactUsFormActionGroup" stepKey="submitContactUsForm"/> + <actionGroup ref="AssertStorefrontContactUsInvalidEmailActionGroup" stepKey="assertErrorMessage"> + <argument name="message" value="Please enter a valid email address (Ex: johndoe@domain.com)."/> + </actionGroup> + </test> +</tests> diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml new file mode 100644 index 0000000000000..d423e650c8a95 --- /dev/null +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + /** + * Copyright © Magento, Inc. All rights reserved. + * See COPYING.txt for license details. + */ +--> + +<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd"> + <test name="StorefrontSubmitContactUsFormSuccessTest"> + <annotations> + <features value="Contact"/> + <stories value="Storefront Contact Us Form"/> + <title value="Submitting Contact Us Form on Storefront"/> + <description value="User should be able successfully submit Contact Us form, if input data is valid"/> + <group value="contact"/> + </annotations> + + <actionGroup ref="StorefrontOpenContactUsPageActionGroup" stepKey="navigateContactUsPage"/> + <actionGroup ref="StorefrontFillContactUsFormActionGroup" stepKey="fillContactUsForm"> + <argument name="customer" value="Simple_US_Customer"/> + <argument name="contactUsData" value="DefaultContactUsData"/> + </actionGroup> + <actionGroup ref="StorefrontSubmitContactUsFormActionGroup" stepKey="submitContactUsForm"/> + <actionGroup ref="AssertMessageContactUsFormActionGroup" stepKey="assertSuccessMessage"/> + </test> +</tests> diff --git a/app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml b/app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml index e176c45a1fa00..2ccf41af20c30 100644 --- a/app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml +++ b/app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml @@ -380,4 +380,18 @@ <requiredEntity type="address">US_Address_CA</requiredEntity> <requiredEntity type="address">US_Address_NY_Not_Default_Address</requiredEntity> </entity> + <entity name="Simple_Customer_With_Invalid_Email" type="customer"> + <data key="group_id">1</data> + <data key="default_billing">true</data> + <data key="default_shipping">true</data> + <data key="email" unique="prefix">John.Doe@</data> + <data key="firstname">John</data> + <data key="lastname">Doe</data> + <data key="fullname">John Doe</data> + <data key="password">pwdTest123!</data> + <data key="store_id">0</data> + <data key="website_id">0</data> + <data key="group">General</data> + <requiredEntity type="address">US_Address_TX</requiredEntity> + </entity> </entities> From bef88fcfba035d1300f2a02eae986388f9bad759 Mon Sep 17 00:00:00 2001 From: engcom-Echo <engcom-vendorworker-echo@adobe.com> Date: Mon, 13 Jul 2020 16:35:41 +0300 Subject: [PATCH 2/3] add testCaseId --- .../Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml | 1 + .../Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml index dac7476e17daa..3e79d5896b80c 100644 --- a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml @@ -15,6 +15,7 @@ <title value="Submitting Contact Us Form on Storefront with invalid user input"/> <description value="User should have no possibility submit Contact Form if input data is not valid"/> <group value="contact"/> + <testCaseId value="MC-35813"/> </annotations> <actionGroup ref="StorefrontOpenContactUsPageActionGroup" stepKey="navigateContactUsPage"/> diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml index d423e650c8a95..a55ee35785176 100644 --- a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml @@ -15,6 +15,7 @@ <title value="Submitting Contact Us Form on Storefront"/> <description value="User should be able successfully submit Contact Us form, if input data is valid"/> <group value="contact"/> + <testCaseId value="MC-35815"/> </annotations> <actionGroup ref="StorefrontOpenContactUsPageActionGroup" stepKey="navigateContactUsPage"/> From 2ca2286181f3e3981a7c48cef3e17acee05cddd2 Mon Sep 17 00:00:00 2001 From: Dmitry Tsymbal <d.tsymbal@atwix.com> Date: Tue, 1 Dec 2020 17:52:36 +0200 Subject: [PATCH 3/3] Adding Annotations --- .../Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml | 1 + .../Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml index 3e79d5896b80c..fbeebebf82740 100644 --- a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormFailedTest.xml @@ -15,6 +15,7 @@ <title value="Submitting Contact Us Form on Storefront with invalid user input"/> <description value="User should have no possibility submit Contact Form if input data is not valid"/> <group value="contact"/> + <severity value="MINOR"></severity> <testCaseId value="MC-35813"/> </annotations> diff --git a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml index a55ee35785176..289a39f8d36fb 100644 --- a/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml +++ b/app/code/Magento/Contact/Test/Mftf/Test/StorefrontSubmitContactUsFormSuccessTest.xml @@ -15,6 +15,7 @@ <title value="Submitting Contact Us Form on Storefront"/> <description value="User should be able successfully submit Contact Us form, if input data is valid"/> <group value="contact"/> + <severity value="MINOR"></severity> <testCaseId value="MC-35815"/> </annotations>