Skip to content

Community themes contain resources for Commerce edition modules #21446

Open
@clockworkgeek

Description

@clockworkgeek

Summary (*)

The three standard themes have several folders which reference modules that do not exist in Community edition. They mostly contain _module.less files and this leads to unused style rules in the deployed CSS. Also it's a little bit annoying.

Examples (*)

The following folders are superfluous:

adminhtml/Magento/backend/Magento_AdvancedCheckout
adminhtml/Magento/backend/Magento_Banner
adminhtml/Magento/backend/Magento_CatalogPermissions
adminhtml/Magento/backend/Magento_CustomerBalance
adminhtml/Magento/backend/Magento_GiftCard
adminhtml/Magento/backend/Magento_GiftRegistry
adminhtml/Magento/backend/Magento_GiftWrapping
adminhtml/Magento/backend/Magento_Reward
adminhtml/Magento/backend/Magento_Rma
adminhtml/Magento/backend/Magento_VersionsCms
adminhtml/Magento/backend/Magento_VisualMerchandiser
frontend/Magento/black/Magento_AdvancedCheckout
frontend/Magento/black/Magento_Banner
frontend/Magento/black/Magento_CatalogEvent
frontend/Magento/black/Magento_GiftCard
frontend/Magento/black/Magento_GiftCardAccount
frontend/Magento/black/Magento_GiftRegistry
frontend/Magento/black/Magento_GiftWrapping
frontend/Magento/black/Magento_Invitation
frontend/Magento/black/Magento_MultipleWishlist
frontend/Magento/black/Magento_Rma
frontend/Magento/black/Magento_VersionsCms
frontend/Magento/luma/Magento_AdvancedCheckout
frontend/Magento/luma/Magento_CustomerBalance
frontend/Magento/luma/Magento_GiftCard
frontend/Magento/luma/Magento_GiftCardAccount
frontend/Magento/luma/Magento_GiftWrapping
frontend/Magento/luma/Magento_Invitation
frontend/Magento/luma/Magento_MultipleWishlist
frontend/Magento/luma/Magento_Reward
frontend/Magento/luma/Magento_Rma

Proposed solution

Move the mentioned resources to the appropriate theme or the modules' own view folders.

Metadata

Metadata

Assignees

Labels

Component: ThemeIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentPriority: P4No current plan to fix. Fixing can be deferred as a logical part of more important work.Progress: PR CreatedIndicates that Pull Request has been created to fix issueReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseSeverity: S4Affects aesthetics, professional look and feel, “quality” or “usability”.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions