Possible Memory Leak in GetProductSalableQtyInterface

[singhalavi]

Preconditions and environment

• Magento version
  Checked in 2.4.3 and 2.4.6 versions, reproducible in both
• Anything else that would help a developer reproduce the bug
  Have around 20k Simple products

Steps to reproduce

Step 1: Fetch Products in batches (using limit and offset)
Step 2: Iterate over the products
Step 3: Fetch SalableQty using GetProductSalableQtyInterface
Step 4: Record the peak memory usage using memory_get_peak_usage(). Observe that the peak memory usage increases slowly after every batch.

Comment out the calls to GetProductSalableQtyInterface and repeat steps 1-4. Observe that the peak memory usage remains the same.

Expected result

Peak Memory used should not increase consistently and should stabilize after few batches.

Actual result

Peak memory increases slowly and ultimately it goes OOM.

Additional information

Example Code

// $productCollectionFactory -> CollectionFactory
// $stockByWebsiteIdResolver -> StockByWebsiteIdResolverInterface
// $getProductSalableQtyInterface -> GetProductSalableQtyInterface

 public function processInventory()
    {
        $collection = $this->productCollectionFactory->create();
        $collection->addAttributeToSelect('*')
            ->addAttributeToFilter('type_id', ProductType::TYPE_SIMPLE)
            ->addStoreFilter($storeId)
            ->setStoreId($storeId);

        $offset = 0;
        $limit = 200;
        do {
            $products = $collection
                ->getSelect()
                ->order(new \Zend_Db_Expr('e.updated_at desc'))
                ->limit($limit, $offset);
            $offset += $limit;
            if (empty($products)) {
                break;
            }
            foreach ($products as $product) {
                $websiteId = (int)$product->getStore()->getWebsiteId();
                $stockId = $this->stockByWebsiteIdResolver->execute($websiteId)->getStockId();
                $qty = $this->getProductSalableQtyInterface->execute(
                    $product->getSku(),
                    $stockId
                );
            }
            gc_collect_cycles();
            echo "Peak Mem ". memory_get_peak_usage() ;
        } while (true);
    }

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @singhalavi. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[singhalavi]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @singhalavi. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @singhalavi, here is your Magento Instance: https://096b84887e71e717ab0a44de4119a7fd.instances-prod.magento-community.engineering
Admin access: https://096b84887e71e717ab0a44de4119a7fd.instances-prod.magento-community.engineering/admin_693b
Login: 4afe218a
Password: 0299fd314a3e

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @singhalavi,

Thank you for the report and collaboration!

Verified the issue on 2.4-develop.
Followed the steps to reproduce and implemented the code in custom module. We are able to get the expected result.
The peak memory kept increasing for every iteration.
Hence confirming the issue.

Please find the custom module used to reproduce this issue.
I38546V.zip

Thank you.