Open
Description
There are several classes under the Magento\Customer
(and one under Magento\Review
) namespace that are requiring Magento\Newsletter
classes, making it impossible to successfully disable/remove the newsletter module, if one uses another solution.
Magento\Customer\Block\Account\Dashboard
Magento\Customer\Block\Account\Dashboard\Info
Magento\Customer\Block\Adminhml\Edit\Tab\Newsletter
Magento\Customer\Block\Adminhml\Edit\Tab\Newsletter\Grid
Magento\Customer\Block\Adminhml\Edit\Tab\Newsletter\Grid\Renderer\Status
Magento\Customer\Controller\Adminhtml\Index
Magento\Customer\Controller\Adminhtml\Index\Cart
Magento\Customer\Controller\Adminhtml\Index\Newsletter
Magento\Customer\Controller\Adminhtml\Index\Save
Magento\Customer\Controller\Adminhtml\Index\Viewfile
Magento\Customer\Controller\Adminhtml\Customer\InvalidateToken
Magento\Review\Block\Customer\ListCustomer
From those classes, several ones are requiring \Magento\Newsletter\Model\SubscriberFactory
but they end up not even using it, basically declaring dependencies to classes that are not needed.
Preconditions
- To a instance of Magento 2.3.3 installed via Composer, add the following section to the
composer.json
:
{
"replace": {
"magento/module-newsletter": "*"
}
}
Steps to reproduce
composer update --lock -vvv
;php bin/magento setup:di:compile
Expected result
- Compilation is successful.
Actual result
Class Magento\Newsletter\Model\SubscriberFactory does not exist
Class Magento\Customer\Controller\Adminhtml\Index\Save\Interceptor generation error: The requested class did not generate properly, because the 'generated' directory permission is read-only. If --- after running the 'bin/magento setup:di:compile' CLI command when the 'generated' directory permission is set to write --- the requested class did not generate properly, then you must add the generated class object to the signature of the related construct method, only.
Metadata
Metadata
Assignees
Labels
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmedA defect with this priority could have functionality issues which are not to expectations.Indicates original Magento version for the Issue report.The issue has been reproduced on latest 2.4-develop branchIssue related to Developer Experience and needs help with Triage to Confirm or Reject it