Skip to content

Commit ffdb308

Browse files
authored
Merge pull request #33771 from andrewbess/bugfix/fixes-for-failed-integration-tests
Fixed flaky integration tests
2 parents be2d156 + 03b3d28 commit ffdb308

File tree

2 files changed

+41
-1
lines changed

2 files changed

+41
-1
lines changed

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/AbstractProductExportImportTestCase.php

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,31 @@ public function testImportExport(array $fixtures, array $skus, array $skippedAtt
124124
$csvFile = $this->executeExportTest($skus, $skippedAttributes);
125125

126126
$this->executeImportReplaceTest($skus, $skippedAttributes, false, $csvFile);
127-
$this->executeImportReplaceTest($skus, $skippedAttributes, true, $csvFile);
128127
$this->executeImportDeleteTest($skus, $csvFile);
129128
}
130129

130+
/**
131+
* Run import/export test with pagination.
132+
*
133+
* @magentoAppArea adminhtml
134+
* @magentoDbIsolation disabled
135+
* @magentoAppIsolation enabled
136+
*
137+
* @param array $fixtures
138+
* @param string[] $skus
139+
* @param string[] $skippedAttributes
140+
* @dataProvider exportImportDataProvider
141+
* @throws \Magento\Framework\Exception\NoSuchEntityException
142+
*/
143+
public function testImportExportWithPagination(array $fixtures, array $skus, array $skippedAttributes = [])
144+
{
145+
$this->fixtures = $fixtures;
146+
$this->executeFixtures($fixtures);
147+
$this->modifyData($skus);
148+
$skippedAttributes = array_merge(self::$skippedAttributes, $skippedAttributes);
149+
$this->executeImportReplaceTest($skus, $skippedAttributes, true);
150+
}
151+
131152
/**
132153
* Provide data for import/export.
133154
*

dev/tests/integration/testsuite/Magento/DownloadableImportExport/Model/DownloadableTest.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,25 @@ public function testImportExport(array $fixtures, array $skus, array $skippedAtt
4949
parent::testImportExport($fixtures, $skus, $skippedAttributes);
5050
}
5151

52+
/**
53+
* Run import/export test with pagination.
54+
*
55+
* @magentoAppArea adminhtml
56+
* @magentoDbIsolation disabled
57+
* @magentoAppIsolation enabled
58+
*
59+
* @param array $fixtures
60+
* @param string[] $skus
61+
* @param string[] $skippedAttributes
62+
* @dataProvider exportImportDataProvider
63+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
64+
*/
65+
public function testImportExportWithPagination(array $fixtures, array $skus, array $skippedAttributes = [])
66+
{
67+
$skippedAttributes = array_merge(self::$skippedAttributes, ['downloadable_links']);
68+
parent::testImportExportWithPagination($fixtures, $skus, $skippedAttributes);
69+
}
70+
5271
/**
5372
* @inheritdoc
5473
*/

0 commit comments

Comments
 (0)