MAGETWO-69261: Magento\Framework\App\ResourceConnection::getTableName does not support index table name switching

Author: Stanislav Idolov

app/code/Magento/Catalog/Model/ResourceModel/Indexer/ActiveTableSwitcher.php

@@ -10,11 +10,11 @@
  */
 class ActiveTableSwitcher
 {
-    /** Suffix for outdated index table. */
-    const OUTDATED_TABLE_SUFFIX = '_outdated';
-
     /** Suffix for replica index table. */
-    const ADDITIONAL_TABLE_SUFFIX = '_replica';
+    private $additionalTableSuffix = '_replica';
+
+    /** Suffix for outdated index table. */
+    private $outdatedTableSuffix = '_outdated';
 
     /**
      * Switch index tables from replica to active.
@@ -25,8 +25,8 @@ class ActiveTableSwitcher
      */
     public function switchTable(\Magento\Framework\DB\Adapter\AdapterInterface $connection, $tableName)
     {
-        $outdatedTableName = $tableName . self::OUTDATED_TABLE_SUFFIX;
-        $replicaTableName = $tableName . self::ADDITIONAL_TABLE_SUFFIX;
+        $outdatedTableName = $tableName . $this->outdatedTableSuffix;
+        $replicaTableName = $tableName . $this->additionalTableSuffix;
 
         $connection->renameTablesBatch(
             [
@@ -52,6 +52,6 @@ public function switchTable(\Magento\Framework\DB\Adapter\AdapterInterface $conn
      */
     public function getAdditionalTableName($tableName)
     {
-        return $tableName . self::ADDITIONAL_TABLE_SUFFIX;
+        return $tableName . $this->additionalTableSuffix;
     }
 }

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Indexer/ActiveTableSwitcherTest.php

@@ -49,7 +49,7 @@ public function testGetAdditionalTableName()
     {
         $tableName = 'table_name';
         $this->assertEquals(
-            $tableName . \Magento\Catalog\Model\ResourceModel\Indexer\ActiveTableSwitcher::ADDITIONAL_TABLE_SUFFIX,
+            $tableName . '_replica',
             $this->model->getAdditionalTableName($tableName)
         );
     }