MAGETWO-27267: Add getTierPrices() to the Product

 -- updated per code review
 -- updated per demo review

Author: Mike Weis

app/code/Magento/Catalog/Api/ProductTierPriceManagementInterface.php

@@ -12,7 +12,7 @@ interface ProductTierPriceManagementInterface
      * Create tier price for product
      *
      * @param string $sku
-     * @param string $customerGroupId
+     * @param string $customerGroupId 'all' can be used to specify 'ALL GROUPS'
      * @param float $price
      * @param float $qty
      * @return boolean
@@ -22,10 +22,10 @@ interface ProductTierPriceManagementInterface
     public function add($sku, $customerGroupId, $price, $qty);
 
     /**
-     * Remove tire price from product
+     * Remove tier price from product
      *
      * @param string $sku
-     * @param string $customerGroupId
+     * @param string $customerGroupId 'all' can be used to specify 'ALL GROUPS'
      * @param float $qty
      * @return boolean
      * @throws \Magento\Framework\Exception\NoSuchEntityException
@@ -34,10 +34,10 @@ public function add($sku, $customerGroupId, $price, $qty);
     public function remove($sku, $customerGroupId, $qty);
 
     /**
-     * Get tire price of product
+     * Get tier price of product
      *
      * @param string $sku
-     * @param string $customerGroupId
+     * @param string $customerGroupId 'all' can be used to specify 'ALL GROUPS'
      * @return \Magento\Catalog\Api\Data\ProductTierPriceInterface[]
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */

app/code/Magento/Catalog/Model/Product.php

@@ -962,15 +962,11 @@ public function getGroupPrice()
     /**
      * Gets list of product group prices
      *
-     * @return \Magento\Catalog\Api\Data\ProductGroupPriceInterface[]|null
+     * @return \Magento\Catalog\Api\Data\ProductGroupPriceInterface[]
      */
     public function getGroupPrices()
     {
-        $groupPrices = $this->getPriceModel()->getGroupPrices($this);
-        if (empty($groupPrices)) {
-            $groupPrices = null;
-        }
-        return $groupPrices;
+        return $this->getPriceModel()->getGroupPrices($this);
     }
 
     /**
@@ -988,15 +984,11 @@ public function setGroupPrices(array $groupPrices = null)
     /**
      * Gets list of product tier prices
      *
-     * @return \Magento\Catalog\Api\Data\ProductTierPriceInterface[]|null
+     * @return \Magento\Catalog\Api\Data\ProductTierPriceInterface[]
      */
     public function getTierPrices()
     {
-        $tierPrices = $this->getPriceModel()->getTierPrices($this);
-        if (empty($tierPrices)) {
-            $tierPrices = null;
-        }
-        return $tierPrices;
+        return $this->getPriceModel()->getTierPrices($this);
     }
 
     /**

app/code/Magento/Catalog/Test/Unit/Model/ProductTest.php

@@ -738,10 +738,10 @@ protected function invokeGetGroupOrTierPrices($originalPrices, $getter)
             ]
         );
 
-        $expectedResultIsNull = (empty($originalPrices) ? true : false);
+        $expectedResultIsEmpty = (empty($originalPrices) ? true : false);
         $groupPrices = $productModel->$getter();
-        $actualResultIsNull = (empty($groupPrices) ? true : false);
-        $this->assertEquals($expectedResultIsNull,$actualResultIsNull );
+        $actualResultIsEmpty = (empty($groupPrices) ? true : false);
+        $this->assertEquals($expectedResultIsEmpty, $actualResultIsEmpty);
     }
 
     /**

dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductRepositoryInterfaceTest.php

@@ -358,9 +358,8 @@ public function testGroupPrices()
             'value' => 2.10,
         ];
         $response[self::KEY_GROUP_PRICES] = $groupPrices;
-        $this->updateProduct($response);
+        $response = $this->updateProduct($response);
 
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
         $this->assertArrayHasKey(self::KEY_GROUP_PRICES, $response);
         $groupPrices = $response[self::KEY_GROUP_PRICES];
         $this->assertNotNull($groupPrices, "UPDATE 1: expected to have group prices");
@@ -373,9 +372,8 @@ public function testGroupPrices()
         // update the product without any mention of group prices; no change expected for group pricing
         $response = $this->getProduct($productData[ProductInterface::SKU]);
         unset($response[self::KEY_GROUP_PRICES]);
-        $this->updateProduct($response);
+        $response = $this->updateProduct($response);
 
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
         $this->assertArrayHasKey(self::KEY_GROUP_PRICES, $response);
         $groupPrices = $response[self::KEY_GROUP_PRICES];
         $this->assertNotNull($groupPrices, "UPDATE 2: expected to have group prices");
@@ -388,10 +386,9 @@ public function testGroupPrices()
         // update the product with empty group prices; expect to have the existing group prices removed
         $response = $this->getProduct($productData[ProductInterface::SKU]);
         $response[self::KEY_GROUP_PRICES] = [];
-        $this->updateProduct($response);
-
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
-        $this->assertArrayNotHasKey(self::KEY_GROUP_PRICES, $response, "expected to not have any 'group_prices' data");
+        $response = $this->updateProduct($response);
+        $this->assertArrayHasKey(self::KEY_GROUP_PRICES, $response, "expected to have the 'group_prices' key");
+        $this->assertEmpty($response[self::KEY_GROUP_PRICES], "expected to have an empty array of 'group_prices'");
 
         // delete the product with group prices; expect that all goes well
         $response = $this->deleteProduct($productData[ProductInterface::SKU]);
@@ -440,9 +437,8 @@ public function testTierPrices()
             'qty' => 12,
         ];
         $response[self::KEY_TIER_PRICES] = $tierPrices;
-        $this->updateProduct($response);
+        $response = $this->updateProduct($response);
 
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
         $this->assertArrayHasKey(self::KEY_TIER_PRICES, $response);
         $tierPrices = $response[self::KEY_TIER_PRICES];
         $this->assertNotNull($tierPrices, "UPDATE 1: expected to have tier prices");
@@ -457,9 +453,8 @@ public function testTierPrices()
         // update the product without any mention of tier prices; no change expected for tier pricing
         $response = $this->getProduct($productData[ProductInterface::SKU]);
         unset($response[self::KEY_TIER_PRICES]);
-        $this->updateProduct($response);
+        $response = $this->updateProduct($response);
 
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
         $this->assertArrayHasKey(self::KEY_TIER_PRICES, $response);
         $tierPrices = $response[self::KEY_TIER_PRICES];
         $this->assertNotNull($tierPrices, "UPDATE 2: expected to have tier prices");
@@ -474,10 +469,9 @@ public function testTierPrices()
         // update the product with empty tier prices; expect to have the existing tier prices removed
         $response = $this->getProduct($productData[ProductInterface::SKU]);
         $response[self::KEY_TIER_PRICES] = [];
-        $this->updateProduct($response);
-
-        $response = $this->getProduct($productData[ProductInterface::SKU]);
-        $this->assertArrayNotHasKey(self::KEY_TIER_PRICES, $response, "expected to not have any 'tier_prices' data");
+        $response = $this->updateProduct($response);
+        $this->assertArrayHasKey(self::KEY_TIER_PRICES, $response, "expected to have the 'tier_prices' key");
+        $this->assertEmpty($response[self::KEY_TIER_PRICES], "expected to have an empty array of 'tier_prices'");
 
         // delete the product with tier prices; expect that all goes well
         $response = $this->deleteProduct($productData[ProductInterface::SKU]);