graphQl-889: base_amount marked as deprecated

Author: Vitaliy Boyko

app/code/Magento/QuoteGraphQl/Model/Resolver/ShippingAddress/AvailableShippingMethods.php

@@ -98,11 +98,8 @@ private function processMoneyTypeData(array $data, string $quoteCurrencyCode, St
             $data['amount'] = ['value' => $data['amount'], 'currency' => $quoteCurrencyCode];
         }
 
-        if (isset($data['base_amount'])) {
-            /** @var Currency $currency */
-            $currency = $store->getBaseCurrency();
-            $data['base_amount'] = ['value' => $data['base_amount'], 'currency' => $currency->getCode()];
-        }
+        /** @deprecated The field should not be used on the storefront */
+        $data['base_amount'] = null;
 
         if (isset($data['price_excl_tax'])) {
             $data['price_excl_tax'] = ['value' => $data['price_excl_tax'], 'currency' => $quoteCurrencyCode];

app/code/Magento/QuoteGraphQl/Model/Resolver/ShippingAddress/SelectedShippingMethod.php

@@ -58,10 +58,8 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
                     'value' => $address->getShippingAmount(),
                     'currency' => $address->getQuote()->getQuoteCurrencyCode(),
                 ],
-                'base_amount' => [
-                    'value' => $address->getBaseShippingAmount(),
-                    'currency' => $currency->getCode(),
-                ],
+                /** @deprecated The field should not be used on the storefront */
+                'base_amount' => null,
             ];
         } else {
             $data = [
@@ -70,6 +68,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
                 'carrier_title' => $carrierTitle,
                 'method_title' => $methodTitle,
                 'amount' => null,
+                /** @deprecated The field should not be used on the storefront */
                 'base_amount' => null,
             ];
         }

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

@@ -244,7 +244,7 @@ type SelectedShippingMethod {
     carrier_title: String
     method_title: String
     amount: Money
-    base_amount: Money
+    base_amount: Money @deprecated(reason: "The field should not be used on the storefront")
 }
 
 type AvailableShippingMethod {
@@ -254,7 +254,7 @@ type AvailableShippingMethod {
     method_title: String @doc(description: "Could be null if method is not available")
     error_message: String
     amount: Money!
-    base_amount: Money @doc(description: "Could be null if method is not available")
+    base_amount: Money @deprecated(reason: "The field should not be used on the storefront")
     price_excl_tax: Money!
     price_incl_tax: Money!
     available: Boolean!

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetAvailableShippingMethodsTest.php

@@ -62,10 +62,6 @@ public function testGetAvailableShippingMethods()
                 'value' => 10,
                 'currency' => 'USD',
             ],
-            'base_amount' => [
-                'value' => 10,
-                'currency' => 'USD',
-            ],
             'carrier_code' => 'flatrate',
             'carrier_title' => 'Flat Rate',
             'error_message' => '',
@@ -176,10 +172,6 @@ private function getQuery(string $maskedQuoteId): string
             value
             currency
           }
-          base_amount {
-            value
-            currency
-          }
           carrier_code
           carrier_title
           error_message

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetSelectedShippingMethodTest.php

@@ -78,14 +78,6 @@ public function testGetSelectedShippingMethod()
         self::assertEquals(10, $amount['value']);
         self::assertArrayHasKey('currency', $amount);
         self::assertEquals('USD', $amount['currency']);
-
-        self::assertArrayHasKey('base_amount', $shippingAddress['selected_shipping_method']);
-        $baseAmount = $shippingAddress['selected_shipping_method']['base_amount'];
-
-        self::assertArrayHasKey('value', $baseAmount);
-        self::assertEquals(10, $baseAmount['value']);
-        self::assertArrayHasKey('currency', $baseAmount);
-        self::assertEquals('USD', $baseAmount['currency']);
     }
 
     /**
@@ -188,7 +180,6 @@ public function testGetGetSelectedShippingMethodIfShippingMethodIsNotSet()
         self::assertNull($shippingAddress['selected_shipping_method']['carrier_title']);
         self::assertNull($shippingAddress['selected_shipping_method']['method_title']);
         self::assertNull($shippingAddress['selected_shipping_method']['amount']);
-        self::assertNull($shippingAddress['selected_shipping_method']['base_amount']);
     }
 
     /**
@@ -240,10 +231,6 @@ private function getQuery(string $maskedQuoteId): string
             value
             currency
         }
-        base_amount {
-            value
-            currency
-        }
       }
     }
   }

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetAvailableShippingMethodsTest.php

@@ -54,10 +54,6 @@ public function testGetAvailableShippingMethods()
                 'value' => 10,
                 'currency' => 'USD',
             ],
-            'base_amount' => [
-                'value' => 10,
-                'currency' => 'USD',
-            ],
             'carrier_code' => 'flatrate',
             'carrier_title' => 'Flat Rate',
             'error_message' => '',
@@ -144,10 +140,6 @@ private function getQuery(string $maskedQuoteId): string
             value
             currency
           }
-          base_amount {
-            value
-            currency
-          }
           carrier_code
           carrier_title
           error_message

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetSelectedShippingMethodTest.php

@@ -70,14 +70,6 @@ public function testGetSelectedShippingMethod()
         self::assertEquals(10, $amount['value']);
         self::assertArrayHasKey('currency', $amount);
         self::assertEquals('USD', $amount['currency']);
-
-        self::assertArrayHasKey('base_amount', $shippingAddress['selected_shipping_method']);
-        $baseAmount = $shippingAddress['selected_shipping_method']['base_amount'];
-
-        self::assertArrayHasKey('value', $baseAmount);
-        self::assertEquals(10, $baseAmount['value']);
-        self::assertArrayHasKey('currency', $baseAmount);
-        self::assertEquals('USD', $baseAmount['currency']);
     }
 
     /**
@@ -158,7 +150,6 @@ public function testGetGetSelectedShippingMethodIfShippingMethodIsNotSet()
         self::assertNull($shippingAddress['selected_shipping_method']['carrier_title']);
         self::assertNull($shippingAddress['selected_shipping_method']['method_title']);
         self::assertNull($shippingAddress['selected_shipping_method']['amount']);
-        self::assertNull($shippingAddress['selected_shipping_method']['base_amount']);
     }
 
     /**
@@ -195,10 +186,6 @@ private function getQuery(string $maskedQuoteId): string
             value
             currency
         }
-        base_amount {
-            value
-            currency
-        }
       }
     }
   }