Skip to content

Commit fdbbef1

Browse files
author
Olga Kopylova
committed
MAGETWO-43452: Ogre sprint 38 contribution to mainline
- moved complex XSD to framework
1 parent 755620a commit fdbbef1

File tree

11 files changed

+14
-45
lines changed

11 files changed

+14
-45
lines changed

app/code/Magento/ProductVideo/etc/view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_ProductVideo:etc/view.xsd">
8+
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ProductVideo/etc/view.xsd">
99
<media>
1010
<videos module="Magento_ProductVideo">
1111
<video id="play_if_base" type="play_if_base">

app/code/Magento/Swatches/etc/view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Catalog:etc/view.xsd">
8+
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Catalog/etc/view.xsd">
99
<media>
1010
<images module="Magento_Catalog">
1111
<image id="swatch_image" type="swatch_image">

app/design/adminhtml/Magento/backend/etc/view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Catalog:etc/view.xsd">
8+
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Catalog/etc/view.xsd">
99
<vars module="Js_Bundle">
1010
<var name="bundle_size">1MB</var>
1111
</vars>

app/design/frontend/Magento/blank/etc/view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Catalog:etc/view.xsd">
8+
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Catalog/etc/view.xsd">
99
<media>
1010
<images module="Magento_Catalog">
1111
<image id="bundled_product_customization_page" type="thumbnail">

app/design/frontend/Magento/luma/etc/view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* See COPYING.txt for license details.
66
*/
77
-->
8-
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Catalog:etc/view.xsd">
8+
<view xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Catalog/etc/view.xsd">
99
<media>
1010
<images module="Magento_Catalog">
1111
<image id="bundled_product_customization_page" type="thumbnail">

dev/tests/static/framework/Magento/TestFramework/Utility/Validator.php

Lines changed: 0 additions & 25 deletions
This file was deleted.

dev/tests/static/testsuite/Magento/Test/Integrity/Xml/SchemaTest.php

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
namespace Magento\Test\Integrity\Xml;
88

99
use Magento\Framework\Component\ComponentRegistrar;
10-
use Magento\Framework\Config\Dom\UrnResolver;
1110

1211
class SchemaTest extends \PHPUnit_Framework_TestCase
1312
{
@@ -36,18 +35,11 @@ function ($filename) {
3635
. 'xsi:noNamespaceSchemaLocation="urn:magento:framework:Relative_Path/something.xsd"'
3736
);
3837

39-
try {
40-
$schemaFile = (new UrnResolver())->getRealPath($schemaLocations[1]);
41-
$this->assertFileExists($schemaFile, "$filename refers to an invalid schema $schemaFile.");
42-
$errors = \Magento\TestFramework\Utility\Validator::validateXml($dom, $schemaFile);
43-
$this->assertEmpty(
44-
$errors,
45-
"Error validating $filename against $schemaFile\n" . print_r($errors, true)
46-
);
47-
} catch (\UnexpectedValueException $e) {
48-
$this->fail($e->getMessage());
49-
}
50-
38+
$errors = \Magento\Framework\Config\Dom::validateDomDocument($dom, $schemaLocations[1]);
39+
$this->assertEmpty(
40+
$errors,
41+
"Error validating $filename against {$schemaLocations[1]}\n" . print_r($errors, true)
42+
);
5143
},
5244
$this->getXmlFiles()
5345
);
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Library contains schema files used to validate XML files in Magento\Catalog module

app/code/Magento/Catalog/etc/view.xsd renamed to lib/internal/Magento/Framework/Catalog/etc/view.xsd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77
-->
88
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">
9-
<xs:redefine schemaLocation="urn:magento:framework:Config/etc/view.xsd">
9+
<xs:redefine schemaLocation="../../Config/etc/view.xsd">
1010
<xs:complexType name="mediaType" mixed="true">
1111
<xs:complexContent>
1212
<xs:extension base="mediaType">
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Library contains schema files used to validate XML files in Magento\ProductVideo module

0 commit comments

Comments
 (0)