Resolved cyclomatic complexity of AssertProductRegularPriceOnStorefront.php

Author: sivaschenko

dev/tests/functional/tests/app/Magento/Wishlist/Test/Constraint/AssertProductRegularPriceOnStorefront.php

@@ -44,44 +44,29 @@ public function processAssert(
         $cmsIndex->getLinksBlock()->openLink('My Account');
         $customerAccountIndex->getAccountMenuBlock()->openMenuItem('My Wish List');
 
-        $isProductVisible = $wishlistIndex->getWishlistBlock()->getProductItemsBlock()->getItemProduct($product)
+        $isProductVisible = $wishlistIndex->getWishlistBlock()
+            ->getProductItemsBlock()
+            ->getItemProduct($product)
             ->isVisible();
         while (!$isProductVisible && $wishlistIndex->getTopToolbar()->nextPage()) {
-            $isProductVisible = $wishlistIndex->getWishlistBlock()->getProductItemsBlock()->getItemProduct($product)
+            $isProductVisible = $wishlistIndex->getWishlistBlock()
+                ->getProductItemsBlock()
+                ->getItemProduct($product)
                 ->isVisible();
         }
 
-        $productRegularPrice = 0;
         if ($product instanceof GroupedProduct) {
-            $associatedProducts = $product->getAssociated();
-
-            /** @var \Magento\Catalog\Test\Fixture\CatalogProductSimple $associatedProduct */
-            foreach ($associatedProducts['products'] as $key => $associatedProduct) {
-                $qty = $associatedProducts['assigned_products'][$key]['qty'];
-                $price = $associatedProduct->getPrice();
-                $productRegularPrice += $qty * $price;
-            }
+            $productRegularPrice = $this->getGroupedProductRegularPrice($product);
         } elseif ($product instanceof BundleProduct) {
-            $bundleSelection = (array)$product->getBundleSelections();
-            foreach ($bundleSelection['products'] as $bundleOption) {
-                $regularBundleProductPrice = 0;
-                /** @var \Magento\Catalog\Test\Fixture\CatalogProductSimple $bundleProduct */
-                foreach ($bundleOption as $bundleProduct) {
-                    $checkoutData = $bundleProduct->getCheckoutData();
-                    $bundleProductPrice = $checkoutData['qty'] * $checkoutData['cartItem']['price'];
-                    if (0 === $regularBundleProductPrice) {
-                        $regularBundleProductPrice = $bundleProductPrice;
-                    } else {
-                        $regularBundleProductPrice = max([$bundleProductPrice, $regularBundleProductPrice]);
-                    }
-                }
-                $productRegularPrice += $regularBundleProductPrice;
-            }
+            $productRegularPrice = $this->getBundleProductRegularPrice($product);
         } else {
-            $productRegularPrice = (float)$product->getPrice();
+            $productRegularPrice = (float) $product->getPrice();
         }
 
-        $productItem = $wishlistIndex->getWishlistBlock()->getProductItemsBlock()->getItemProduct($product);
+        $productItem = $wishlistIndex->getWishlistBlock()
+            ->getProductItemsBlock()
+            ->getItemProduct($product);
+
         $wishListProductRegularPrice = $product instanceof BundleProduct
             ? (float)$productItem->getPrice()
             : (float)$productItem->getRegularPrice();
@@ -106,6 +91,52 @@ public function processAssert(
         );
     }
 
+    /**
+     * Retrieve grouped product regular price
+     *
+     * @param GroupedProduct $product
+     * @return float
+     */
+    private function getGroupedProductRegularPrice(GroupedProduct $product)
+    {
+        $productRegularPrice = 0;
+        $associatedProducts = $product->getAssociated();
+        /** @var \Magento\Catalog\Test\Fixture\CatalogProductSimple $associatedProduct */
+        foreach ($associatedProducts['products'] as $key => $associatedProduct) {
+            $qty = $associatedProducts['assigned_products'][$key]['qty'];
+            $price = $associatedProduct->getPrice();
+            $productRegularPrice += $qty * $price;
+        }
+        return $productRegularPrice;
+    }
+
+    /**
+     * Retrieve bundle product regular price
+     *
+     * @param BundleProduct $product
+     * @return float
+     */
+    private function getBundleProductRegularPrice(BundleProduct $product)
+    {
+        $productRegularPrice = 0;
+        $bundleSelection = (array) $product->getBundleSelections();
+        foreach ($bundleSelection['products'] as $bundleOption) {
+            $regularBundleProductPrice = 0;
+            /** @var \Magento\Catalog\Test\Fixture\CatalogProductSimple $bundleProduct */
+            foreach ($bundleOption as $bundleProduct) {
+                $checkoutData = $bundleProduct->getCheckoutData();
+                $bundleProductPrice = $checkoutData['qty'] * $checkoutData['cartItem']['price'];
+                if (0 === $regularBundleProductPrice) {
+                    $regularBundleProductPrice = $bundleProductPrice;
+                } else {
+                    $regularBundleProductPrice = max([$bundleProductPrice, $regularBundleProductPrice]);
+                }
+            }
+            $productRegularPrice += $regularBundleProductPrice;
+        }
+        return $productRegularPrice;
+    }
+
     /**
      * Returns a string representation of the object.
      *