MAGETWO-87551: Convert existing data install/upgrade scripts

Author: Sergii Kovalenko

setup/src/Magento/Setup/Model/Declaration/Schema/DataSavior/ColumnSavior.php

@@ -7,6 +7,7 @@
 namespace Magento\Setup\Model\Declaration\Schema\DataSavior;
 
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\DB\SelectFactory;
 use Magento\Setup\Model\Declaration\Schema\Dto\Column;
 use Magento\Setup\Model\Declaration\Schema\Dto\ElementInterface;
 use Magento\Setup\Model\Declaration\Schema\Dto\Table;
@@ -36,23 +37,31 @@ class ColumnSavior implements DataSaviorInterface
      */
     private $dumpAccessor;
 
+    /**
+     * @var SelectFactory
+     */
+    private $selectFactory;
+
     /**
      * TableDump constructor.
      * @param ResourceConnection $resourceConnection
      * @param SelectGeneratorFactory $selectGeneratorFactory
      * @param DumpAccessorInterface $dumpAccessor
      * @param UniqueConstraintsResolver $uniqueConstraintsResolver
+     * @param SelectFactory $selectFactory
      */
     public function __construct(
         ResourceConnection $resourceConnection,
         SelectGeneratorFactory $selectGeneratorFactory,
         DumpAccessorInterface $dumpAccessor,
-        UniqueConstraintsResolver $uniqueConstraintsResolver
+        UniqueConstraintsResolver $uniqueConstraintsResolver,
+        SelectFactory $selectFactory
     ) {
         $this->selectGeneratorFactory = $selectGeneratorFactory;
         $this->resourceConnection = $resourceConnection;
         $this->uniqueConstraintsResolver = $uniqueConstraintsResolver;
         $this->dumpAccessor = $dumpAccessor;
+        $this->selectFactory = $selectFactory;
     }
 
     /**
@@ -65,11 +74,8 @@ public function __construct(
     private function prepareColumnSelect(Column $column, array $fieldsToDump)
     {
         $adapter = $this->resourceConnection->getConnection($column->getTable()->getResource());
-        $select = $adapter
-            ->select()
-            ->setPart('disable_staging_preview', true)
-            ->from($column->getTable()->getName(), $fieldsToDump);
-
+        $select = $this->selectFactory->create($adapter);
+        $select->from($column->getTable()->getName(), $fieldsToDump);
         return $select;
     }
 

setup/src/Magento/Setup/Model/Declaration/Schema/DataSavior/TableSavior.php

@@ -7,6 +7,7 @@
 namespace Magento\Setup\Model\Declaration\Schema\DataSavior;
 
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\DB\SelectFactory;
 use Magento\Setup\Model\Declaration\Schema\Dto\ElementInterface;
 use Magento\Setup\Model\Declaration\Schema\Dto\Table;
 
@@ -30,20 +31,28 @@ class TableSavior implements DataSaviorInterface
      */
     private $dumpAccessor;
 
+    /**
+     * @var SelectFactory
+     */
+    private $selectFactory;
+
     /**
      * TableDump constructor.
      * @param ResourceConnection $resourceConnection
      * @param SelectGeneratorFactory $selectGeneratorFactory
      * @param DumpAccessorInterface $dumpAccessor
+     * @param SelectFactory $selectFactory
      */
     public function __construct(
         ResourceConnection $resourceConnection,
         SelectGeneratorFactory $selectGeneratorFactory,
-        DumpAccessorInterface $dumpAccessor
+        DumpAccessorInterface $dumpAccessor,
+        SelectFactory $selectFactory
     ) {
         $this->selectGeneratorFactory = $selectGeneratorFactory;
         $this->resourceConnection = $resourceConnection;
         $this->dumpAccessor = $dumpAccessor;
+        $this->selectFactory = $selectFactory;
     }
 
     /**
@@ -55,11 +64,8 @@ public function __construct(
     private function prepareTableSelect(Table $table)
     {
         $adapter = $this->resourceConnection->getConnection($table->getResource());
-        $select = $adapter
-            ->select()
-            ->setPart('disable_staging_preview', true)
-            ->from($table->getName());
-
+        $select = $this->selectFactory->create($adapter);
+        $select->from($table->getName());
         return $select;
     }
 

setup/src/Magento/Setup/Model/Declaration/Schema/Db/MySQL/DDL/Triggers/MigrateDataFromAnotherTable.php

@@ -7,6 +7,7 @@
 namespace Magento\Setup\Model\Declaration\Schema\Db\MySQL\DDL\Triggers;
 
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\DB\SelectFactory;
 use Magento\Setup\Model\Declaration\Schema\Db\DDLTriggerInterface;
 use Magento\Setup\Model\Declaration\Schema\Dto\Column;
 use Magento\Setup\Model\Declaration\Schema\Dto\ElementInterface;
@@ -27,14 +28,23 @@ class MigrateDataFromAnotherTable implements DDLTriggerInterface
      */
     private $resourceConnection;
 
+    /**
+     * @var SelectFactory
+     */
+    private $selectFactory;
+
     /**
      * Constructor.
      *
      * @param ResourceConnection $resourceConnection
+     * @param SelectFactory $selectFactory
      */
-    public function __construct(ResourceConnection $resourceConnection)
-    {
+    public function __construct(
+        ResourceConnection $resourceConnection,
+        SelectFactory $selectFactory
+    ) {
         $this->resourceConnection = $resourceConnection;
+        $this->selectFactory = $selectFactory;
     }
 
     /**
@@ -59,12 +69,11 @@ public function getCallback(ElementInterface $column)
             $adapter = $this->resourceConnection->getConnection(
                 $column->getTable()->getResource()
             );
-            $select = $adapter->select()
-                ->setPart('disable_staging_preview', true)
-                ->from(
-                    $this->resourceConnection->getTableName($tableMigrateFrom),
-                    [$column->getName() => $columnMigrateFrom]
-                );
+            $select = $this->selectFactory->create($adapter);
+            $select->from(
+                $this->resourceConnection->getTableName($tableMigrateFrom),
+                [$column->getName() => $columnMigrateFrom]
+            );
             //Update only if table exists
             if ($adapter->isTableExists($tableMigrateFrom)) {
                 $adapter->query(