MAGETWO-80319: Remove array indexing by entityId #11086

Volodymyr Kublytskyi · Volodymyr Kublytskyi · commit fd15d4da858a · 2017-09-28T09:00:46.000-05:00
- Merge Pull Request #11086 from thisisandrew/magento2:remove-unnecessary-array-indexing-1 - Merged commits: 1. 505fd9f
diff --git a/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php b/app/code/Magento/Catalog/Model/Indexer/Category/Flat/AbstractAction.php
@@ -369,9 +369,6 @@ protected function getAttributeValues($entityIds, $storeId)
         }
         $values = [];
 
-        foreach ($entityIds as $entityId) {
-            $values[$entityId] = [];
-        }
         $attributes = $this->getAttributes();
         $attributesType = ['varchar', 'int', 'decimal', 'text', 'datetime'];
         foreach ($attributesType as $type) {

Original file line number	Diff line number	Diff line change
`@@ -369,9 +369,6 @@ protected function getAttributeValues($entityIds, $storeId)`
`369`	`369`	`}`
`370`	`370`	`$values = [];`
`371`	`371`
`372`		`- foreach ($entityIds as $entityId) {`
`373`		`- $values[$entityId] = [];`
`374`		`- }`
`375`	`372`	`$attributes = $this->getAttributes();`
`376`	`373`	`$attributesType = ['varchar', 'int', 'decimal', 'text', 'datetime'];`
`377`	`374`	`foreach ($attributesType as $type) {`