34441: static tests failuers fixes

Author: karyna-t

app/code/Magento/CatalogImportExport/Model/Import/Product.php

@@ -54,40 +54,40 @@ class Product extends AbstractEntity
     /**
      * Size of bunch - part of products to save in one step.
      */
-    const BUNCH_SIZE = 20;
+    public const BUNCH_SIZE = 20;
 
     /**
      * Size of bunch to delete attributes of products in one step.
      */
-    const ATTRIBUTE_DELETE_BUNCH = 1000;
+    public const ATTRIBUTE_DELETE_BUNCH = 1000;
 
     /**
      * Pseudo multi line separator in one cell.
      *
      * Can be used as custom option value delimiter or in configurable fields cells.
      */
-    const PSEUDO_MULTI_LINE_SEPARATOR = '|';
+    public const PSEUDO_MULTI_LINE_SEPARATOR = '|';
 
     /**
      * Symbol between Name and Value between Pairs.
      */
-    const PAIR_NAME_VALUE_SEPARATOR = '=';
+    public const PAIR_NAME_VALUE_SEPARATOR = '=';
 
     /**
      * Value that means all entities (e.g. websites, groups etc.)
      */
-    const VALUE_ALL = 'all';
+    public const VALUE_ALL = 'all';
 
     /**
      * Data row scopes.
      */
-    const SCOPE_DEFAULT = 1;
+    public const SCOPE_DEFAULT = 1;
 
-    const SCOPE_WEBSITE = 2;
+    public const SCOPE_WEBSITE = 2;
 
-    const SCOPE_STORE = 0;
+    public const SCOPE_STORE = 0;
 
-    const SCOPE_NULL = -1;
+    public const SCOPE_NULL = -1;
 
     /**
      * Permanent column names.
@@ -99,77 +99,77 @@ class Product extends AbstractEntity
     /**
      * Column product store.
      */
-    const COL_STORE = '_store';
+    public const COL_STORE = '_store';
 
     /**
      * Column product store view code.
      */
-    const COL_STORE_VIEW_CODE = 'store_view_code';
+    public const COL_STORE_VIEW_CODE = 'store_view_code';
 
     /**
      * Column website.
      */
-    const COL_WEBSITE = 'website_code';
+    public const COL_WEBSITE = 'website_code';
 
     /**
      * Column product attribute set.
      */
-    const COL_ATTR_SET = '_attribute_set';
+    public const COL_ATTR_SET = '_attribute_set';
 
     /**
      * Column product type.
      */
-    const COL_TYPE = 'product_type';
+    public const COL_TYPE = 'product_type';
 
     /**
      * Column product category.
      */
-    const COL_CATEGORY = 'categories';
+    public const COL_CATEGORY = 'categories';
 
     /**
      * Column product visibility.
      */
-    const COL_VISIBILITY = 'visibility';
+    public const COL_VISIBILITY = 'visibility';
 
     /**
      * Column product sku.
      */
-    const COL_SKU = 'sku';
+    public const COL_SKU = 'sku';
 
     /**
      * Column product name.
      */
-    const COL_NAME = 'name';
+    public const COL_NAME = 'name';
 
     /**
      * Column product website.
      */
-    const COL_PRODUCT_WEBSITES = '_product_websites';
+    public const COL_PRODUCT_WEBSITES = '_product_websites';
 
     /**
      * Attribute code for media gallery.
      */
-    const MEDIA_GALLERY_ATTRIBUTE_CODE = 'media_gallery';
+    public const MEDIA_GALLERY_ATTRIBUTE_CODE = 'media_gallery';
 
     /**
      * Column media image.
      */
-    const COL_MEDIA_IMAGE = '_media_image';
+    public const COL_MEDIA_IMAGE = '_media_image';
 
     /**
      * Inventory use config label.
      */
-    const INVENTORY_USE_CONFIG = 'Use Config';
+    public const INVENTORY_USE_CONFIG = 'Use Config';
 
     /**
      * Prefix for inventory use config.
      */
-    const INVENTORY_USE_CONFIG_PREFIX = 'use_config_';
+    public const INVENTORY_USE_CONFIG_PREFIX = 'use_config_';
 
     /**
      * Url key attribute code
      */
-    const URL_KEY = 'url_key';
+    public const URL_KEY = 'url_key';
 
     /**
      * @var array
@@ -474,8 +474,6 @@ class Product extends AbstractEntity
     protected $_optionEntity;
 
     /**
-     * Catalog data
-     *
      * @var \Magento\Catalog\Helper\Data
      */
     protected $_catalogData = null;

app/code/Magento/Sales/Model/Order.php

@@ -65,59 +65,59 @@
  */
 class Order extends AbstractModel implements EntityInterface, OrderInterface
 {
-    const ENTITY = 'order';
+    public const ENTITY = 'order';
 
     /**
      * Order states
      */
-    const STATE_NEW = 'new';
+    public const STATE_NEW = 'new';
 
-    const STATE_PENDING_PAYMENT = 'pending_payment';
+    public const STATE_PENDING_PAYMENT = 'pending_payment';
 
-    const STATE_PROCESSING = 'processing';
+    public const STATE_PROCESSING = 'processing';
 
-    const STATE_COMPLETE = 'complete';
+    public const STATE_COMPLETE = 'complete';
 
-    const STATE_CLOSED = 'closed';
+    public const STATE_CLOSED = 'closed';
 
-    const STATE_CANCELED = 'canceled';
+    public const STATE_CANCELED = 'canceled';
 
-    const STATE_HOLDED = 'holded';
+    public const STATE_HOLDED = 'holded';
 
-    const STATE_PAYMENT_REVIEW = 'payment_review';
+    public const STATE_PAYMENT_REVIEW = 'payment_review';
 
     /**
      * Order statuses
      */
-    const STATUS_FRAUD = 'fraud';
+    public const STATUS_FRAUD = 'fraud';
 
     /**
      * Order flags
      */
-    const ACTION_FLAG_CANCEL = 'cancel';
+    public const ACTION_FLAG_CANCEL = 'cancel';
 
-    const ACTION_FLAG_HOLD = 'hold';
+    public const ACTION_FLAG_HOLD = 'hold';
 
-    const ACTION_FLAG_UNHOLD = 'unhold';
+    public const ACTION_FLAG_UNHOLD = 'unhold';
 
-    const ACTION_FLAG_EDIT = 'edit';
+    public const ACTION_FLAG_EDIT = 'edit';
 
-    const ACTION_FLAG_CREDITMEMO = 'creditmemo';
+    public const ACTION_FLAG_CREDITMEMO = 'creditmemo';
 
-    const ACTION_FLAG_INVOICE = 'invoice';
+    public const ACTION_FLAG_INVOICE = 'invoice';
 
-    const ACTION_FLAG_REORDER = 'reorder';
+    public const ACTION_FLAG_REORDER = 'reorder';
 
-    const ACTION_FLAG_SHIP = 'ship';
+    public const ACTION_FLAG_SHIP = 'ship';
 
-    const ACTION_FLAG_COMMENT = 'comment';
+    public const ACTION_FLAG_COMMENT = 'comment';
 
     /**
      * Report date types
      */
-    const REPORT_DATE_TYPE_CREATED = 'created';
+    public const REPORT_DATE_TYPE_CREATED = 'created';
 
-    const REPORT_DATE_TYPE_UPDATED = 'updated';
+    public const REPORT_DATE_TYPE_UPDATED = 'updated';
 
     /**
      * @var string

lib/internal/Magento/Framework/Stdlib/StringUtils.php

@@ -16,7 +16,7 @@ class StringUtils
     /**
      * Default charset
      */
-    const ICONV_CHARSET = 'UTF-8';
+    public const ICONV_CHARSET = 'UTF-8';
 
     /**
      * Capitalize first letters and convert separators if needed