ACP2E-3541: "Something went wrong" error on checkout for inactive company

Author: aplapana

app/code/Magento/Csp/Test/Unit/Plugin/StoreAssetIntegrityHashesTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2024 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 declare(strict_types=1);
 
@@ -62,6 +62,7 @@ protected function setUp(): void
      * Test After Deploy method of plugin
      *
      * @return void
+     * @doesNotPerformAssertions
      */
     public function testAfterDeploy(): void
     {

app/code/Magento/Customer/Test/Unit/Model/AccountManagementApiTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2023 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 declare(strict_types=1);
 
@@ -433,6 +433,8 @@ public function testBeforeCreateAccount(
     ): void {
         if ($willThrowException) {
             $this->expectException(AuthorizationException::class);
+        } else {
+            $this->expectNotToPerformAssertions();
         }
         $this->authorizationMock
             ->expects($this->once())

app/code/Magento/Customer/Test/Unit/Plugin/AsyncRequestCustomerGroupAuthorizationTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2023 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 declare(strict_types=1);
 
@@ -86,6 +86,7 @@ public function testBeforePublishMass(
             [$customer, 'Password1', '']
         ];
         $this->authorizationMock
+            ->expects($this->once())
             ->method('isAllowed')
             ->with('Magento_Customer::manage')
             ->willReturn($isAllowed);

app/code/Magento/Swagger/Test/Unit/Controller/Index/IndexTest.php

@@ -1,7 +1,7 @@
 <?php
-/**
- * Copyright 2015 Adobe
- * All Rights Reserved.
+/***
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 
 declare(strict_types=1);
@@ -67,10 +67,9 @@ protected function setUp(): void
     }
 
     /**
-     * @return void
-     * @throws NotFoundException
+     * @doesNotPerformAssertions
      */
-    public function testExecute(): void
+    public function testExecute()
     {
         $this->pageConfigMock->expects($this->once())
             ->method('addBodyClass')
@@ -96,10 +95,9 @@ public function testDispatchRejectsWhenDisabled()
     }
 
     /**
-     * @return void
-     * @throws NotFoundException
+     * @doesNotPerformAssertions
      */
-    public function testDispatchIsSuccessfulWhenEnabled(): void
+    public function testDispatchIsSuccessfulWhenEnabled()
     {
         $request = self::getMockBuilder(Http::class)
             ->disableOriginalConstructor()

lib/internal/Magento/Framework/Webapi/Test/Unit/InputLimit/DefaultPageSizeSetterTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2021 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 
 declare(strict_types=1);
@@ -38,9 +38,9 @@ protected function setUp(): void
     }
 
     /**
-     * @return void
+     * @doesNotPerformAssertions
      */
-    public function testPageSizeIsNotSetWhenLimitingIsDisabled(): void
+    public function testPageSizeIsNotSetWhenLimitingIsDisabled()
     {
         $this->configProvider->method('isInputLimitingEnabled')
             ->willReturn(false);
@@ -55,9 +55,9 @@ public function testPageSizeIsNotSetWhenLimitingIsDisabled(): void
     }
 
     /**
-     * @return void
+     * @doesNotPerformAssertions
      */
-    public function testPageSizeIsNotSetWhenAlreadySet(): void
+    public function testPageSizeIsNotSetWhenAlreadySet()
     {
         $this->configProvider->method('isInputLimitingEnabled')
             ->willReturn(true);
@@ -72,9 +72,9 @@ public function testPageSizeIsNotSetWhenAlreadySet(): void
     }
 
     /**
-     * @return void
+     * @doesNotPerformAssertions
      */
-    public function testPageSizeIsSetWithPreferredConfigValue(): void
+    public function testPageSizeIsSetWithPreferredConfigValue()
     {
         $this->configProvider->method('isInputLimitingEnabled')
             ->willReturn(true);
@@ -93,9 +93,9 @@ public function testPageSizeIsSetWithPreferredConfigValue(): void
     }
 
     /**
-     * @return void
+     * @doesNotPerformAssertions
      */
-    public function testPageSizeIsSetWithPreferredFallbackValue(): void
+    public function testPageSizeIsSetWithPreferredFallbackValue()
     {
         $this->configProvider->method('isInputLimitingEnabled')
             ->willReturn(true);

lib/internal/Magento/Framework/Webapi/Test/Unit/ServiceInputProcessorTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2014 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 declare(strict_types=1);
 
@@ -415,10 +415,9 @@ public function testArrayOfDataObjectPropertiesIsValidated()
     }
 
     /**
-     * @return void
-     * @throws Exception
+     * @doesNotPerformAssertions
      */
-    public function testDefaultPageSizeSetterIsInvoked(): void
+    public function testDefaultPageSizeSetterIsInvoked()
     {
         $this->defaultPageSizeSetter->expects(self::once())
             ->method('processSearchCriteria')

lib/internal/Magento/Framework/Webapi/Test/Unit/Validator/EntityArrayValidatorTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright 2021 Adobe
- * All Rights Reserved.
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
  */
 
 declare(strict_types=1);
@@ -50,12 +50,9 @@ protected function setUp(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit(): void
+    public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit()
     {
         $this->configMock->expects(self::once())
             ->method('isInputLimitingEnabled')
@@ -69,12 +66,9 @@ public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testFailsDataWhenAboveLimitUsingRouteInputLimit(): void
+    public function testFailsDataWhenAboveLimitUsingRouteInputLimit()
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('Maximum items of type "foo" is 4');
@@ -90,12 +84,9 @@ public function testFailsDataWhenAboveLimitUsingRouteInputLimit(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testAllowsDataWhenBelowLimit(): void
+    public function testAllowsDataWhenBelowLimit()
     {
         $this->configMock->expects(self::once())
             ->method('isInputLimitingEnabled')
@@ -110,12 +101,9 @@ public function testAllowsDataWhenBelowLimit(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testAllowsDataWhenBelowLimitUsingConfig(): void
+    public function testAllowsDataWhenBelowLimitUsingConfig()
     {
         $this->configMock->expects(self::once())
             ->method('isInputLimitingEnabled')
@@ -130,12 +118,9 @@ public function testAllowsDataWhenBelowLimitUsingConfig(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testFailsDataWhenAboveLimit(): void
+    public function testFailsDataWhenAboveLimit()
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('Maximum items of type "foo" is 3');
@@ -152,12 +137,9 @@ public function testFailsDataWhenAboveLimit(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testFailsDataWhenAboveLimitUsingConfig(): void
+    public function testFailsDataWhenAboveLimitUsingConfig()
     {
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('Maximum items of type "foo" is 6');
@@ -174,12 +156,9 @@ public function testFailsDataWhenAboveLimitUsingConfig(): void
     }
 
     /**
-     * @return void
-     * @throws InvalidArgumentException
-     * @throws \Magento\Framework\Exception\FileSystemException
-     * @throws \Magento\Framework\Exception\RuntimeException
+     * @doesNotPerformAssertions
      */
-    public function testAboveLimitWithDisabledLimiting(): void
+    public function testAboveLimitWithDisabledLimiting()
     {
         $this->configMock->expects(self::once())
             ->method('isInputLimitingEnabled')