MCP584: Fix failed Integration tests

Author: aa-kashk

app/code/Magento/Quote/Model/Config.php

@@ -35,7 +35,6 @@ public function __construct(ScopeConfigInterface $config)
      */
     public function isEnabled(): bool
     {
-        #return (bool)$this->config->getValue(self::XML_PATH_INVENTORY_CHECK_ENABLED);
-        return false;
+        return (bool)$this->config->getValue(self::XML_PATH_INVENTORY_CHECK_ENABLED);
     }
 }

dev/tests/integration/testsuite/Magento/Quote/Model/QuoteManagementTest.php

@@ -181,6 +181,7 @@ public function testSubmitWithPurchaseOrderWithException(): void
     /**
      * Tries to create order with product that has child items and one of them was deleted.
      *
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 1
      * @magentoAppArea adminhtml
      * @magentoAppIsolation enabled
      * @magentoDataFixture Magento/Sales/_files/quote_with_bundle.php
@@ -195,9 +196,25 @@ public function testSubmitWithDeletedItem(): void
         $this->cartManagement->placeOrder($quote->getId());
     }
 
+
+    /**
+     * Tries to create order with product that has child items and one of them
+     * was deleted when item data check is disabled on quote load.
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 0
+     * @magentoAppArea adminhtml
+     * @magentoAppIsolation enabled
+     * @magentoDataFixture Magento/Sales/_files/quote_with_bundle.php
+     */
+    public function testSubmitWithDeletedItemWithDisabledInventoryCheck(): void
+    {
+        $this->productRepository->deleteById('simple-2');
+        $quote = $this->getQuoteByReservedOrderId->execute('test01');
+        $this->cartManagement->placeOrder($quote->getId());
+    }
+
     /**
      * Tries to create order with item of stock during checkout.
-     *
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 1
      * @magentoDataFixture Magento/Sales/_files/quote.php
      * @magentoDbIsolation enabled
      */
@@ -209,6 +226,21 @@ public function testSubmitWithItemOutOfStock(): void
         $this->cartManagement->placeOrder($quote->getId());
     }
 
+    /**
+     * Tries to create order with item of stock during checkout
+     * when item data check is disabled on quote load.
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 0
+     * @magentoDataFixture Magento/Sales/_files/quote.php
+     * @magentoDbIsolation enabled
+     */
+    public function testSubmitWithItemOutOfStockWithDisabledInventoryCheck(): void
+    {
+        $this->makeProductOutOfStock('simple');
+        $quote = $this->getQuoteByReservedOrderId->execute('test01');
+        $this->expectExceptionObject(new LocalizedException(__('The shipping method is missing. Select the shipping method and try again.')));
+        $this->cartManagement->placeOrder($quote->getId());
+    }
+
     /**
      * Tries to create an order using quote with empty customer email.
      *

dev/tests/integration/testsuite/Magento/Sales/Model/Service/PaymentFailuresServiceTest.php

@@ -63,6 +63,7 @@ protected function setUp(): void
     }
 
     /**
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 1
      * @magentoDataFixture Magento/Sales/_files/quote_with_two_products_and_customer.php
      * @magentoConfigFixture current_store payment/payflowpro/title Some Title Of The Method
      * @magentoConfigFixture current_store carriers/freeshipping/title Some Shipping Method
@@ -107,4 +108,51 @@ public function testHandlerWithCustomer(): void
 
         $this->assertEquals($expectedVars, $templateVars);
     }
+
+    /**
+     * @magentoConfigFixture cataloginventory/options/enable_inventory_check 0
+     * @magentoDataFixture Magento/Sales/_files/quote_with_two_products_and_customer.php
+     * @magentoConfigFixture current_store payment/payflowpro/title Some Title Of The Method
+     * @magentoConfigFixture current_store carriers/freeshipping/title Some Shipping Method
+     * @magentoDbIsolation enabled
+     * @magentoAppIsolation enabled
+     * @return void
+     */
+    public function testHandlerWithCustomerWithInventoryCheckDisabled(): void
+    {
+        $errorMessage = __('Transaction declined.');
+        $checkoutType = 'custom_checkout';
+
+        $this->quote->load('test01', 'reserved_order_id');
+        $this->cartRepositoryMock->method('get')
+            ->with($this->quote->getId())
+            ->willReturn($this->quote);
+
+        $dateAndTime = 'Nov 22, 2019, 1:00:00 AM';
+        $this->localeDateMock->expects($this->atLeastOnce())->method('formatDateTime')->willReturn($dateAndTime);
+        $this->paymentFailures->handle((int)$this->quote->getId(), $errorMessage->render());
+
+        $paymentReflection = new \ReflectionClass($this->paymentFailures);
+        $templateVarsMethod = $paymentReflection->getMethod('getTemplateVars');
+        $templateVarsMethod->setAccessible(true);
+
+        $templateVars = $templateVarsMethod->invoke($this->paymentFailures, $this->quote, $errorMessage, $checkoutType);
+        $expectedVars = [
+            'reason' => $errorMessage->render(),
+            'checkoutType' => $checkoutType,
+            'dateAndTime' => $dateAndTime,
+            'customer' => 'John Smith',
+            'customerEmail' => 'aaa@aaa.com',
+            'paymentMethod' => 'Some Title Of The Method',
+            'shippingMethod' => 'Some Shipping Method',
+            'items' => 'Simple Product  x 2.0000  USD 10<br />Custom Design Simple Product  x 1.0000  USD 10',
+            'total' => 'USD 30.0000',
+            'billingAddress' => $this->quote->getBillingAddress(),
+            'shippingAddress' => $this->quote->getShippingAddress(),
+            'billingAddressHtml' => $this->quote->getBillingAddress()->format('html'),
+            'shippingAddressHtml' => $this->quote->getShippingAddress()->format('html'),
+        ];
+
+        $this->assertEquals($expectedVars, $templateVars);
+    }
 }