MAGETWO-67566: Add additional information into warning message in BatchSizeManagement

Author: Stanislav Idolov

lib/internal/Magento/Framework/Indexer/BatchSizeManagement.php

@@ -50,11 +50,11 @@ public function ensureBatchSize(\Magento\Framework\DB\Adapter\AdapterInterface $
 
         // Log warning if allocated memory for temp table greater than 20% of innodb_buffer_pool_size
         if ($size > $bufferPoolSize * .2) {
-            $this->logger->warning(new \Magento\Framework\Phrase(
-                'Memory size allocated for the temporary table is more than 20% of innodb_buffer_pool_size. ' .
+            $message = 'Memory size allocated for the temporary table is more than 20% of innodb_buffer_pool_size. ' .
                 'Please update innodb_buffer_pool_size or decrease batch size value '.
-                '(which decreases memory usages for the temporary table).'
-            ));
+                '(which decreases memory usages for the temporary table). ' .
+                'Current batch size: %1; Allocated memory size: %2 bytes; InnoDB buffer pool size: %3 bytes.';
+            $this->logger->warning(new \Magento\Framework\Phrase($message, [$batchSize, $size, $bufferPoolSize]));
         }
 
         if ($maxMemoryTableSize < $size) {

lib/internal/Magento/Framework/Indexer/Test/Unit/BatchSizeManagementTest.php

@@ -60,9 +60,11 @@ public function testEnsureBatchSize()
         $this->loggerMock->expects($this->once())
             ->method('warning')
             ->with(__(
-                'Memory size allocated for the temporary table is more than 20% of innodb_buffer_pool_size. ' .
-                'Please update innodb_buffer_pool_size or decrease batch size value '.
-                '(which decreases memory usages for the temporary table).'
+                "Memory size allocated for the temporary table is more than 20% of innodb_buffer_pool_size. " .
+                "Please update innodb_buffer_pool_size or decrease batch size value ".
+                "(which decreases memory usages for the temporary table). ".
+                "Current batch size: %1; Allocated memory size: %2 bytes; InnoDB buffer pool size: %3 bytes.",
+                [$batchSize, $size, $innodbPollSize]
             ));
 
         $adapterMock->expects($this->at(3))