Skip to content

Commit fb55f24

Browse files
author
Igor Melnikov
committed
MAGETWO-66331: Implement solution to update duplicate rows at once and add environment variable to control batch size
- making envBatchSize parameter optional, fixing formatting
1 parent 4fa0934 commit fb55f24

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

lib/internal/Magento/Framework/DB/FieldDataConverter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ class FieldDataConverter
6262
* @param Generator $queryGenerator
6363
* @param DataConverterInterface $dataConverter
6464
* @param SelectFactory|null $selectFactory
65-
* @param string $envBatchSize
65+
* @param string|null $envBatchSize
6666
*/
6767
public function __construct(
6868
Generator $queryGenerator,
6969
DataConverterInterface $dataConverter,
7070
SelectFactory $selectFactory,
71-
$envBatchSize
71+
$envBatchSize = null
7272
) {
7373
$this->queryGenerator = $queryGenerator;
7474
$this->dataConverter = $dataConverter;

setup/src/Magento/Setup/Model/ObjectManagerProvider.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,10 @@ public function __construct(
5757
public function get()
5858
{
5959
if (null === $this->objectManager) {
60-
$initParams =
61-
array_merge(
62-
$this->serviceLocator->get(InitParamListener::BOOTSTRAP_PARAM),
63-
$_SERVER
64-
);
60+
$initParams = array_merge(
61+
$this->serviceLocator->get(InitParamListener::BOOTSTRAP_PARAM),
62+
$_SERVER
63+
);
6564
$factory = $this->getObjectManagerFactory($initParams);
6665
$this->objectManager = $factory->create($initParams);
6766
if (PHP_SAPI == 'cli') {

0 commit comments

Comments
 (0)