Skip to content

Commit fb4a0ad

Browse files
authored
ENGCOM-3963: Fix for #20527 [Admin] Configurable product variations table cell labels wrong position #20528
2 parents 25e73e4 + d8e1c4c commit fb4a0ad

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

app/code/Magento/ConfigurableProduct/Ui/DataProvider/Product/Form/Modifier/ConfigurablePanel.php

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
*/
66
namespace Magento\ConfigurableProduct\Ui\DataProvider\Product\Form\Modifier;
77

8+
use Magento\Catalog\Model\Locator\LocatorInterface;
89
use Magento\Catalog\Model\Product\Attribute\Backend\Sku;
910
use Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\AbstractModifier;
11+
use Magento\Framework\UrlInterface;
1012
use Magento\Ui\Component\Container;
11-
use Magento\Ui\Component\Form;
1213
use Magento\Ui\Component\DynamicRows;
14+
use Magento\Ui\Component\Form;
1315
use Magento\Ui\Component\Modal;
14-
use Magento\Framework\UrlInterface;
15-
use Magento\Catalog\Model\Locator\LocatorInterface;
1616

1717
/**
1818
* Data provider for Configurable panel
@@ -90,15 +90,15 @@ public function __construct(
9090
}
9191

9292
/**
93-
* {@inheritdoc}
93+
* @inheritdoc
9494
*/
9595
public function modifyData(array $data)
9696
{
9797
return $data;
9898
}
9999

100100
/**
101-
* {@inheritdoc}
101+
* @inheritdoc
102102
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
103103
*/
104104
public function modifyMeta(array $meta)
@@ -197,7 +197,7 @@ public function modifyMeta(array $meta)
197197
'autoRender' => false,
198198
'componentType' => 'insertListing',
199199
'component' => 'Magento_ConfigurableProduct/js'
200-
.'/components/associated-product-insert-listing',
200+
. '/components/associated-product-insert-listing',
201201
'dataScope' => $this->associatedListingPrefix
202202
. static::ASSOCIATED_PRODUCT_LISTING,
203203
'externalProvider' => $this->associatedListingPrefix
@@ -328,14 +328,12 @@ protected function getButtonSet()
328328
'component' => 'Magento_Ui/js/form/components/button',
329329
'actions' => [
330330
[
331-
'targetName' =>
332-
$this->dataScopeName . '.configurableModal',
331+
'targetName' => $this->dataScopeName . '.configurableModal',
333332
'actionName' => 'trigger',
334333
'params' => ['active', true],
335334
],
336335
[
337-
'targetName' =>
338-
$this->dataScopeName . '.configurableModal',
336+
'targetName' => $this->dataScopeName . '.configurableModal',
339337
'actionName' => 'openModal',
340338
],
341339
],
@@ -471,8 +469,7 @@ protected function getRows()
471469
'sku',
472470
__('SKU'),
473471
[
474-
'validation' =>
475-
[
472+
'validation' => [
476473
'required-entry' => true,
477474
'max_text_length' => Sku::SKU_MAX_LENGTH,
478475
],
@@ -577,6 +574,7 @@ protected function getColumn(
577574
'dataType' => Form\Element\DataType\Text::NAME,
578575
'dataScope' => $name,
579576
'visibleIfCanEdit' => false,
577+
'labelVisible' => false,
580578
'imports' => [
581579
'visible' => '!${$.provider}:${$.parentScope}.canEdit'
582580
],
@@ -595,6 +593,7 @@ protected function getColumn(
595593
'component' => 'Magento_Ui/js/form/components/group',
596594
'label' => $label,
597595
'dataScope' => '',
596+
'showLabel' => false
598597
];
599598
$container['children'] = [
600599
$name . '_edit' => $fieldEdit,

0 commit comments

Comments
 (0)