Skip to content

Commit fb42f3a

Browse files
orykhorykh
committed
MTA-1594: Re-factor Functional tests which are not end-to-end
- CR Changes
1 parent 25e030f commit fb42f3a

File tree

4 files changed

+150
-145
lines changed

4 files changed

+150
-145
lines changed

‎dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertMenuProductType.php renamed to ‎dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductTypeOrderOnCreate.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010
use Magento\Catalog\Test\Page\Adminhtml\CatalogProductIndex;
1111

1212
/**
13-
* Assert that order and filling of types on product page equals to incoming data.
13+
* Assert that order and types of product on product page equals to incoming data.
1414
*/
15-
class AssertMenuProductType extends AbstractConstraint
15+
class AssertProductTypeOrderOnCreate extends AbstractConstraint
1616
{
1717
/**
18-
* Assert that order and filling of types on product page equals to incoming data.
18+
* Assert that order and types of product on product page equals to incoming data.
1919
*
2020
* @param CatalogProductIndex $catalogProductIndex
2121
* @param array $menu
2222
* @return void
2323
*/
24-
public function processAssert(CatalogProductIndex $catalogProductIndex, $menu = [])
24+
public function processAssert(CatalogProductIndex $catalogProductIndex, array $menu)
2525
{
2626
$catalogProductIndex->open();
2727
ksort($menu);

‎dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/ValidateOrderOfProductTypeTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818
*/
1919
class ValidateOrderOfProductTypeTest extends Injectable
2020
{
21+
/* tags */
22+
const MVP = 'no';
23+
const DOMAIN = 'MX';
24+
/* end tags */
25+
2126
/**
2227
* Open catalog product index page.
2328
*

‎dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Product/ValidateOrderOfProductTypeTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<variation name="ValidateOrderOfProductTypeTestVariation1">
1111
<data name="menu/0" xsi:type="string">Simple Product</data>
1212
<data name="menu/3" xsi:type="string">Virtual Product</data>
13-
<constraint name="Magento\Catalog\Test\Constraint\AssertMenuProductType" />
13+
<constraint name="Magento\Catalog\Test\Constraint\AssertProductTypeOrderOnCreate" />
1414
</variation>
1515
</testCase>
1616
</config>

‎dev/tests/functional/tests/app/Magento/Catalog/Test/etc/di.xml

Lines changed: 140 additions & 140 deletions
Original file line numberDiff line numberDiff line change
@@ -6,144 +6,144 @@
66
*/
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../lib/internal/Magento/Framework/ObjectManager/etc/config.xsd">
9-
<type name="Magento\Catalog\Test\Constraint\AssertProductInGrid">
10-
<arguments>
11-
<argument name="severity" xsi:type="string">high</argument>
12-
</arguments>
13-
</type>
14-
<type name="Magento\Catalog\Test\Constraint\AssertProductPage">
15-
<arguments>
16-
<argument name="severity" xsi:type="string">middle</argument>
17-
</arguments>
18-
</type>
19-
<type name="Magento\Catalog\Test\Constraint\AssertProductForm">
20-
<arguments>
21-
<argument name="severity" xsi:type="string">high</argument>
22-
</arguments>
23-
</type>
24-
<type name="Magento\Catalog\Test\Constraint\AssertProductIsNotDisplayingOnFrontend">
25-
<arguments>
26-
<argument name="severity" xsi:type="string">high</argument>
27-
</arguments>
28-
</type>
29-
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeSaveMessage">
30-
<arguments>
31-
<argument name="severity" xsi:type="string">high</argument>
32-
</arguments>
33-
</type>
34-
<type name="Magento\Catalog\Test\Constraint\AssertProductCrossSells">
35-
<arguments>
36-
<argument name="severity" xsi:type="string">middle</argument>
37-
</arguments>
38-
</type>
39-
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeSuccessDeleteMessage">
40-
<arguments>
41-
<argument name="severity" xsi:type="string">high</argument>
42-
</arguments>
43-
</type>
44-
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentCrossSells">
45-
<arguments>
46-
<argument name="severity" xsi:type="string">middle</argument>
47-
</arguments>
48-
</type>
49-
<type name="Magento\Catalog\Test\Constraint\AssertProductRelatedProducts">
50-
<arguments>
51-
<argument name="severity" xsi:type="string">middle</argument>
52-
</arguments>
53-
</type>
54-
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeAbsenceInGrid">
55-
<arguments>
56-
<argument name="severity" xsi:type="string">high</argument>
57-
</arguments>
58-
</type>
59-
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentRelatedProducts">
60-
<arguments>
61-
<argument name="severity" xsi:type="string">middle</argument>
62-
</arguments>
63-
</type>
64-
<type name="Magento\Catalog\Test\Constraint\AssertProductUpSells">
65-
<arguments>
66-
<argument name="severity" xsi:type="string">middle</argument>
67-
</arguments>
68-
</type>
69-
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeAbsenceInSearchOnProductForm">
70-
<arguments>
71-
<argument name="severity" xsi:type="string">high</argument>
72-
</arguments>
73-
</type>
74-
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentUpSells">
75-
<arguments>
76-
<argument name="severity" xsi:type="string">middle</argument>
77-
</arguments>
78-
</type>
79-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateSuccessSaveMessage">
80-
<arguments>
81-
<argument name="severity" xsi:type="string">high</argument>
82-
</arguments>
83-
</type>
84-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateForm">
85-
<arguments>
86-
<argument name="severity" xsi:type="string">high</argument>
87-
</arguments>
88-
</type>
89-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateInGrid">
90-
<arguments>
91-
<argument name="severity" xsi:type="string">high</argument>
92-
</arguments>
93-
</type>
94-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateOnProductForm">
95-
<arguments>
96-
<argument name="severity" xsi:type="string">high</argument>
97-
</arguments>
98-
</type>
99-
<type name="Magento\Catalog\Test\Constraint\AssertAbsenceDeleteAttributeButton">
100-
<arguments>
101-
<argument name="severity" xsi:type="string">high</argument>
102-
</arguments>
103-
</type>
104-
<type name="Magento\Catalog\Test\Constraint\AssertProductCompareSuccessAddMessage">
105-
<arguments>
106-
<argument name="severity" xsi:type="string">high</argument>
107-
</arguments>
108-
</type>
109-
<type name="Magento\Catalog\Test\Constraint\AssertProductCompareSuccessRemoveAllProductsMessage">
110-
<arguments>
111-
<argument name="severity" xsi:type="string">high</argument>
112-
</arguments>
113-
</type>
114-
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateMessage">
115-
<arguments>
116-
<argument name="severity" xsi:type="string">high</argument>
117-
</arguments>
118-
</type>
119-
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateIsNotDisplayingOnFrontend">
120-
<arguments>
121-
<argument name="severity" xsi:type="string">high</argument>
122-
</arguments>
123-
</type>
124-
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateForm">
125-
<arguments>
126-
<argument name="severity" xsi:type="string">high</argument>
127-
</arguments>
128-
</type>
129-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateGroupOnProductForm">
130-
<arguments>
131-
<argument name="severity" xsi:type="string">high</argument>
132-
</arguments>
133-
</type>
134-
<type name="Magento\Catalog\Test\Constraint\AssertUsedSuperAttributeImpossibleDeleteMessages">
135-
<arguments>
136-
<argument name="severity" xsi:type="string">high</argument>
137-
</arguments>
138-
</type>
139-
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateSuccessDeleteMessage">
140-
<arguments>
141-
<argument name="severity" xsi:type="string">high</argument>
142-
</arguments>
143-
</type>
144-
<type name="Magento\Catalog\Test\Constraint\AssertMenuProductType">
145-
<arguments>
146-
<argument name="severity" xsi:type="string">high</argument>
147-
</arguments>
148-
</type>
9+
<type name="Magento\Catalog\Test\Constraint\AssertProductInGrid">
10+
<arguments>
11+
<argument name="severity" xsi:type="string">high</argument>
12+
</arguments>
13+
</type>
14+
<type name="Magento\Catalog\Test\Constraint\AssertProductPage">
15+
<arguments>
16+
<argument name="severity" xsi:type="string">middle</argument>
17+
</arguments>
18+
</type>
19+
<type name="Magento\Catalog\Test\Constraint\AssertProductForm">
20+
<arguments>
21+
<argument name="severity" xsi:type="string">high</argument>
22+
</arguments>
23+
</type>
24+
<type name="Magento\Catalog\Test\Constraint\AssertProductIsNotDisplayingOnFrontend">
25+
<arguments>
26+
<argument name="severity" xsi:type="string">high</argument>
27+
</arguments>
28+
</type>
29+
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeSaveMessage">
30+
<arguments>
31+
<argument name="severity" xsi:type="string">high</argument>
32+
</arguments>
33+
</type>
34+
<type name="Magento\Catalog\Test\Constraint\AssertProductCrossSells">
35+
<arguments>
36+
<argument name="severity" xsi:type="string">middle</argument>
37+
</arguments>
38+
</type>
39+
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeSuccessDeleteMessage">
40+
<arguments>
41+
<argument name="severity" xsi:type="string">high</argument>
42+
</arguments>
43+
</type>
44+
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentCrossSells">
45+
<arguments>
46+
<argument name="severity" xsi:type="string">middle</argument>
47+
</arguments>
48+
</type>
49+
<type name="Magento\Catalog\Test\Constraint\AssertProductRelatedProducts">
50+
<arguments>
51+
<argument name="severity" xsi:type="string">middle</argument>
52+
</arguments>
53+
</type>
54+
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeAbsenceInGrid">
55+
<arguments>
56+
<argument name="severity" xsi:type="string">high</argument>
57+
</arguments>
58+
</type>
59+
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentRelatedProducts">
60+
<arguments>
61+
<argument name="severity" xsi:type="string">middle</argument>
62+
</arguments>
63+
</type>
64+
<type name="Magento\Catalog\Test\Constraint\AssertProductUpSells">
65+
<arguments>
66+
<argument name="severity" xsi:type="string">middle</argument>
67+
</arguments>
68+
</type>
69+
<type name="Magento\Catalog\Test\Constraint\AssertProductAttributeAbsenceInSearchOnProductForm">
70+
<arguments>
71+
<argument name="severity" xsi:type="string">high</argument>
72+
</arguments>
73+
</type>
74+
<type name="Magento\Catalog\Test\Constraint\AssertProductAbsentUpSells">
75+
<arguments>
76+
<argument name="severity" xsi:type="string">middle</argument>
77+
</arguments>
78+
</type>
79+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateSuccessSaveMessage">
80+
<arguments>
81+
<argument name="severity" xsi:type="string">high</argument>
82+
</arguments>
83+
</type>
84+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateForm">
85+
<arguments>
86+
<argument name="severity" xsi:type="string">high</argument>
87+
</arguments>
88+
</type>
89+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateInGrid">
90+
<arguments>
91+
<argument name="severity" xsi:type="string">high</argument>
92+
</arguments>
93+
</type>
94+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateOnProductForm">
95+
<arguments>
96+
<argument name="severity" xsi:type="string">high</argument>
97+
</arguments>
98+
</type>
99+
<type name="Magento\Catalog\Test\Constraint\AssertAbsenceDeleteAttributeButton">
100+
<arguments>
101+
<argument name="severity" xsi:type="string">high</argument>
102+
</arguments>
103+
</type>
104+
<type name="Magento\Catalog\Test\Constraint\AssertProductCompareSuccessAddMessage">
105+
<arguments>
106+
<argument name="severity" xsi:type="string">high</argument>
107+
</arguments>
108+
</type>
109+
<type name="Magento\Catalog\Test\Constraint\AssertProductCompareSuccessRemoveAllProductsMessage">
110+
<arguments>
111+
<argument name="severity" xsi:type="string">high</argument>
112+
</arguments>
113+
</type>
114+
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateMessage">
115+
<arguments>
116+
<argument name="severity" xsi:type="string">high</argument>
117+
</arguments>
118+
</type>
119+
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateIsNotDisplayingOnFrontend">
120+
<arguments>
121+
<argument name="severity" xsi:type="string">high</argument>
122+
</arguments>
123+
</type>
124+
<type name="Magento\Catalog\Test\Constraint\AssertProductDuplicateForm">
125+
<arguments>
126+
<argument name="severity" xsi:type="string">high</argument>
127+
</arguments>
128+
</type>
129+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateGroupOnProductForm">
130+
<arguments>
131+
<argument name="severity" xsi:type="string">high</argument>
132+
</arguments>
133+
</type>
134+
<type name="Magento\Catalog\Test\Constraint\AssertUsedSuperAttributeImpossibleDeleteMessages">
135+
<arguments>
136+
<argument name="severity" xsi:type="string">high</argument>
137+
</arguments>
138+
</type>
139+
<type name="Magento\Catalog\Test\Constraint\AssertProductTemplateSuccessDeleteMessage">
140+
<arguments>
141+
<argument name="severity" xsi:type="string">high</argument>
142+
</arguments>
143+
</type>
144+
<type name="Magento\Catalog\Test\Constraint\AssertProductTypeOrderOnCreate">
145+
<arguments>
146+
<argument name="severity" xsi:type="string">high</argument>
147+
</arguments>
148+
</type>
149149
</config>

0 commit comments

Comments
 (0)