Skip to content

Commit fa0f4cd

Browse files
🔃 [EngCom] Public Pull Requests - 2.1-develop
Accepted Public Pull Requests: - #15436: [Backport] Removed redundant else statement (by @rogyar) - #15444: [Backport] Added language translation for message string (by @yogeshks)
2 parents fe8a459 + cffef6f commit fa0f4cd

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

app/code/Magento/AdminNotification/Controller/Adminhtml/System/Message/ListAction.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ public function execute()
6161
if (empty($result)) {
6262
$result[] = [
6363
'severity' => (string)\Magento\Framework\Notification\MessageInterface::SEVERITY_NOTICE,
64-
'text' => 'You have viewed and resolved all recent system notices. '
65-
. 'Please refresh the web page to clear the notice alert.',
64+
'text' => __(
65+
'You have viewed and resolved all recent system notices. '
66+
. 'Please refresh the web page to clear the notice alert.'
67+
)
6668
];
6769
}
6870
$this->getResponse()->representJson($this->jsonHelper->jsonEncode($result));

app/code/Magento/AdminNotification/i18n/en_US.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,4 @@ Severity,Severity
4949
"Date Added","Date Added"
5050
Message,Message
5151
Actions,Actions
52+
"You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert.","You have viewed and resolved all recent system notices. Please refresh the web page to clear the notice alert."

app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,8 @@ protected function _getSuperAttributeId($productId, $attributeId)
246246
{
247247
if (isset($this->_productSuperAttrs["{$productId}_{$attributeId}"])) {
248248
return $this->_productSuperAttrs["{$productId}_{$attributeId}"];
249-
} else {
250-
return null;
251249
}
250+
return null;
252251
}
253252

254253
/**

0 commit comments

Comments
 (0)