ENGCOM-3081: Fix for parsing attribute options labels, when & used. #18354

magento-engcom-team · magento-engcom-team · commit f9d1f9a22d74 · 2018-10-03T07:18:23.000-05:00
- Merge Pull Request #18354 from bartoszkubicki/magento2:preserve-&-in-attribute-option-label - Merged commits: 1. e6dc188
diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Attribute/Save.php
@@ -327,7 +327,8 @@ private function preprocessOptionsData(&$data)
             $serializedOptions = json_decode($data['serialized_options'], JSON_OBJECT_AS_ARRAY);
             foreach ($serializedOptions as $serializedOption) {
                 $option = [];
-                parse_str($serializedOption, $option);
+                $serializedOptionWithParsedAmpersand = str_replace('&', '%26', $serializedOption);
+                parse_str($serializedOptionWithParsedAmpersand, $option);
                 $data = array_replace_recursive($data, $option);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,8 @@ private function preprocessOptionsData(&$data)`
`327`	`327`	`$serializedOptions = json_decode($data['serialized_options'], JSON_OBJECT_AS_ARRAY);`
`328`	`328`	`foreach ($serializedOptions as $serializedOption) {`
`329`	`329`	`$option = [];`
`330`		`- parse_str($serializedOption, $option);`
	`330`	`+ $serializedOptionWithParsedAmpersand = str_replace('&', '%26', $serializedOption);`
	`331`	`+ parse_str($serializedOptionWithParsedAmpersand, $option);`
`331`	`332`	`$data = array_replace_recursive($data, $option);`
`332`	`333`	`}`
`333`	`334`	`}`