MAGETWO-68949: [Github] "We Can't Place The Order" error #9455

- Fixed the bug
- Added unit test

Author: isavchuk-magento

app/code/Magento/Paypal/Model/Api/Nvp.php

@@ -1285,6 +1285,15 @@ protected function _handleCallErrors($response)
         );
         $this->_logger->critical($exceptionLogMessage);
 
+        /**
+         * The response code 10415 'Transaction has already been completed for this token'
+         * must not fails place order. The old Paypal interface does not lock 'Send' button
+         * it may result to re-send data.
+         */
+        if (in_array((string)ProcessableException::API_TRANSACTION_HAS_BEEN_COMPLETED, $this->_callErrors)) {
+            return;
+        }
+
         $exceptionPhrase = __('PayPal gateway has rejected request. %1', $errorMessages);
 
         /** @var \Magento\Framework\Exception\LocalizedException $exception */

app/code/Magento/Paypal/Model/Api/ProcessableException.php

@@ -29,6 +29,7 @@ class ProcessableException extends LocalizedException
     const API_MAXIMUM_AMOUNT_FILTER_DECLINE = 10538;
     const API_OTHER_FILTER_DECLINE = 10539;
     const API_ADDRESS_MATCH_FAIL = 10736;
+    const API_TRANSACTION_HAS_BEEN_COMPLETED = 10415;
     /**#@-*/
 
     /**

app/code/Magento/Paypal/Test/Unit/Model/Api/NvpTest.php

@@ -216,4 +216,30 @@ public function testGetDebugReplacePrivateDataKeys()
         $debugReplacePrivateDataKeys = $this->_invokeNvpProperty($this->model, '_debugReplacePrivateDataKeys');
         $this->assertEquals($debugReplacePrivateDataKeys, $this->model->getDebugReplacePrivateDataKeys());
     }
+
+    /**
+     * Tests case if obtained response with code 10415 'Transaction has already
+     * been completed for this token'. It must does not throws the exception and
+     * must returns response array.
+     */
+    public function testCallTransactionHasBeenCompleted ()
+    {
+        $response =    "\r\n" . 'ACK[7]=Failure&L_ERRORCODE0[5]=10415'
+            . '&L_SHORTMESSAGE0[8]=Message.&L_LONGMESSAGE0[15]=Long%20Message.';
+        $processableErrors =[10415];
+        $this->curl->expects($this->once())
+            ->method('read')
+            ->will($this->returnValue($response));
+        $this->model->setProcessableErrors($processableErrors);
+        $this->customLoggerMock->expects($this->once())
+            ->method('debug');
+        $expectedResponse = [
+            'ACK' => 'Failure',
+            'L_ERRORCODE0' => '10415',
+            'L_SHORTMESSAGE0' => 'Message.',
+            'L_LONGMESSAGE0' => 'Long Message.'
+        ];
+
+        $this->assertEquals($expectedResponse, $this->model->call('some method', ['data' => 'some data']));
+    }
 }