Skip to content

Commit f8be711

Browse files
committed
MC-33499: Grid Filter not working for Scheduled Export when selected any kind of Entity Type
1 parent 5c43107 commit f8be711

File tree

4 files changed

+20
-7
lines changed

4 files changed

+20
-7
lines changed

app/code/Magento/CatalogImportExport/Model/Export/Product.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,9 @@ public function filterAttributeCollection(\Magento\Eav\Model\ResourceModel\Entit
15481548
{
15491549
$validTypes = array_keys($this->_productTypeModels);
15501550
$validTypes = array_combine($validTypes, $validTypes);
1551-
$collection->addFieldToFilter('attribute_code', ['nin' => $this->_bannedAttributes]);
1551+
if (!empty($this->_bannedAttributes)) {
1552+
$collection->addFieldToFilter('attribute_code', ['nin' => $this->_bannedAttributes]);
1553+
}
15521554
foreach (parent::filterAttributeCollection($collection) as $attribute) {
15531555
$attrApplyTo = $attribute->getApplyTo();
15541556
$attrApplyTo = array_combine($attrApplyTo, $attrApplyTo);

app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,4 +429,15 @@ public function prepareCollection(\Magento\Framework\Data\Collection $collection
429429
$this->setCollection($collection);
430430
return $this->getCollection();
431431
}
432+
433+
protected function _prepareCollection()
434+
{
435+
if ($this->getCollection()) {
436+
if ($this->getCollection()->isLoaded()) {
437+
$this->getCollection()->clear();
438+
}
439+
}
440+
441+
return parent::_prepareCollection();
442+
}
432443
}

app/code/Magento/ImportExport/Model/Export/AbstractEntity.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -378,11 +378,8 @@ public function getAttributeCollection()
378378
*/
379379
public function filterAttributeCollection(\Magento\Framework\Data\Collection $collection)
380380
{
381-
/** @var $attribute \Magento\Eav\Model\Entity\Attribute\AbstractAttribute */
382-
foreach ($collection as $attribute) {
383-
if (in_array($attribute->getAttributeCode(), $this->_disabledAttributes)) {
384-
$collection->removeItemByKey($attribute->getId());
385-
}
381+
if (!empty($this->_disabledAttributes)) {
382+
$collection->addFieldToFilter('attribute_code', ['nin' => $this->_disabledAttributes]);
386383
}
387384

388385
return $collection;

app/code/Magento/ImportExport/Model/Export/Entity/AbstractEntity.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,10 @@ abstract public function export();
389389
*/
390390
public function filterAttributeCollection(\Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection $collection)
391391
{
392-
return $collection->addFieldToFilter('attribute_code', ['nin' => $this->_disabledAttrs]);
392+
if (!empty($this->_disabledAttrs)) {
393+
$collection->addFieldToFilter('attribute_code', ['nin' => $this->_disabledAttrs]);
394+
}
395+
return $collection;
393396
}
394397

395398
/**

0 commit comments

Comments
 (0)