Merge pull request #20 from magento-lynx/MC-41897

MC-41897: Fix jQuery.fn.bind()

Author: sivaschenko

app/code/Magento/CatalogInventory/Block/Adminhtml/Form/Field/Stock.php

@@ -256,8 +256,8 @@ protected function _getJs($quantityFieldId, $inStockFieldId)
                         };
                         $.each(fieldsAssociations, function(generalTabField, advancedTabField) {
                             $('#' + generalTabField + ', #' + advancedTabField)
-                                .bind('focus blur change keyup click', filler)
-                                .bind('keyup change blur', disabler)
+                                .on('focus blur change keyup click', filler)
+                                .on('keyup change blur', disabler)
                                 .trigger('change');
                         });
 

app/code/Magento/Customer/view/frontend/web/js/block-submit-on-send.js

@@ -20,7 +20,7 @@ define([
             }
             this.isValid = true;
         });
-        dataForm.bind('invalid-form.validate', function () {
+        dataForm.on('invalid-form.validate', function () {
             $(this).find(':submit').prop('disabled', false);
             this.isValid = false;
         });

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/grid/columns/image/actions.js

@@ -61,7 +61,7 @@ define([
 
             if (!this.allowedActions.includes('delete')) {
                 $.async('.media-gallery-delete-assets', function () {
-                    $('.media-gallery-delete-assets').unbind('click').addClass('action-disabled');
+                    $('.media-gallery-delete-assets').off('click').addClass('action-disabled');
                 });
             }
 

app/code/Magento/Swatches/view/adminhtml/web/js/product-attributes.js

@@ -431,10 +431,10 @@ define([
                 tableBody = $(),
                 activePanel = $();
 
-            $('#frontend_input').bind('change', function () {
+            $('#frontend_input').on('change', function () {
                 swatchProductAttributes.bindAttributeInputType();
             });
-            $('#is_filterable').bind('change', function () {
+            $('#is_filterable').on('change', function () {
                 swatchProductAttributes.switchIsFilterable();
             });
 

app/code/Magento/Theme/view/adminhtml/templates/tabs/css.phtml

@@ -34,7 +34,7 @@ require([
         add: function (e, data) {
             var uploadButton = $('#css_uploader_button');
             /** Unbind click event on file change */
-            uploadButton.unbind('click');
+            uploadButton.off('click');
             uploadButton.removeAttr('disabled');
 
             uploadButton.click(function () {

app/code/Magento/Theme/view/adminhtml/templates/tabs/js.phtml

@@ -124,7 +124,7 @@ require([
     $('#js_files_uploader').click(function () {
         /** Unbind click event on file change */
         $('#js-file-uploader').html('');
-        $('#js_uploader_button').unbind('click');
+        $('#js_uploader_button').off('click');
     });
 
 

app/code/Magento/Ui/view/base/web/js/dynamic-rows/dnd.js

@@ -138,8 +138,8 @@ define([
                 $table.offset().top - originRecord.offset().top + $table.children('thead').outerHeight();
             drEl.maxYpos = drEl.minYpos + $table.children('tbody').outerHeight() - originRecord.outerHeight();
             $tableWrapper.append(recordNode);
-            this.body.bind('mousemove touchmove', this.mousemoveHandler);
-            this.body.bind('mouseup touchend', this.mouseupHandler);
+            this.body.on('mousemove touchmove', this.mousemoveHandler);
+            this.body.on('mouseup touchend', this.mouseupHandler);
         },
 
         /**
@@ -199,8 +199,8 @@ define([
 
             drEl.originRow.removeClass(this.draggableElementClass);
 
-            this.body.unbind('mousemove touchmove', this.mousemoveHandler);
-            this.body.unbind('mouseup touchend', this.mouseupHandler);
+            this.body.off('mousemove touchmove', this.mousemoveHandler);
+            this.body.off('mouseup touchend', this.mouseupHandler);
 
             this.draggableElement = {};
         },

app/code/Magento/Ui/view/base/web/js/grid/resize.js

@@ -444,8 +444,8 @@ define([
             cfg.curResizeElem.model.width = $(cfg.curResizeElem.elems[0]).outerWidth();
             cfg.depResizeElem.model.width = $(cfg.depResizeElem.elems[0]).outerWidth();
             body.addClass(this.inResizeClass);
-            body.bind('mousemove', this.mousemoveHandler);
-            $(window).bind('mouseup', this.mouseupHandler);
+            body.on('mousemove', this.mousemoveHandler);
+            $(window).on('mouseup', this.mouseupHandler);
         },
 
         /**
@@ -528,8 +528,8 @@ define([
             this.store('storageColumnsData');
 
             body.removeClass(this.inResizeClass);
-            body.unbind('mousemove', this.mousemoveHandler);
-            $(window).unbind('mouseup', this.mouseupHandler);
+            body.off('mousemove', this.mousemoveHandler);
+            $(window).off('mouseup', this.mouseupHandler);
         },
 
         /**

app/code/Magento/Ui/view/base/web/js/modal/alert.js

@@ -44,7 +44,7 @@ define([
          */
         closeModal: function () {
             this.options.actions.always();
-            this.element.bind('alertclosed', _.bind(this._remove, this));
+            this.element.on('alertclosed', _.bind(this._remove, this));
 
             return this._super();
         }

app/code/Magento/Ui/view/base/web/js/modal/confirm.js

@@ -95,7 +95,7 @@ define([
                 this.options.actions.cancel(event);
             }
             this.options.actions.always(event);
-            this.element.bind('confirmclosed', _.bind(this._remove, this));
+            this.element.on('confirmclosed', _.bind(this._remove, this));
 
             return this._super();
         }