Merge pull request #1270 from magento-south/PRS

MAGETWO-69029: Remove obsolete link "Show more" on Dashboard page on Advance Reporting block
MAGETWO-60352: [Github] Wrong error message in cart after entering invalid discount code #7230
MAGETWO-66510: Javascript error prevents adding/removing categories from existing catalog price rule condition
MAGETWO-59207: Checkbox return to stock doesn't work if Automatically Return Credit Memo Item to Stock Yes
MAGETWO-70201: Update Readme for Analytics modules. Final
MAGETWO-57835: [Github] Cannot save customer dob attribute if admin interface locale is en_GB #6323

Author: rganin

app/code/Magento/Analytics/README.md

@@ -14,11 +14,6 @@
         <div class="dashboard-advanced-reports-content">
             <?= $block->escapeHtml(__('Gain new insights and take command of your business\' performance,' .
                 ' using our dynamic product, order, and customer reports tailored to your customer data.')) ?>
-            <a href="<?= $block->escapeUrl($block->getUrl('analytics/reports/show')) ?>"
-               target="_blank"
-               data-index="analytics-service-info-link">
-                <?= $block->escapeHtml(__('View details')) ?>
-            </a>
         </div>
     </div>
     <div class="dashboard-advanced-reports-actions">

app/code/Magento/Analytics/view/adminhtml/templates/dashboard/section.phtml

@@ -70,6 +70,17 @@ protected function setUp()
             ->getMock();
 
         $this->dataProviderMock = $this->getMockForAbstractClass(DataProviderInterface::class);
+
+        $this->contextMock->expects($this->any())
+            ->method('getNamespace')
+            ->willReturn(DateRange::NAME);
+        $this->contextMock->expects($this->any())
+            ->method('addComponentDefinition')
+            ->with(DateRange::NAME, ['extends' => DateRange::NAME]);
+
+        $this->contextMock->expects($this->any())
+            ->method('getDataProvider')
+            ->willReturn($this->dataProviderMock);
     }
 
     /**
@@ -84,29 +95,15 @@ protected function setUp()
      */
     public function testPrepare($name, $filterData, $expectedCondition)
     {
-        /** @var FormDate PHPUnit_Framework_MockObject_MockObject|$uiComponent */
-        $uiComponent = $this->getMockBuilder(FormDate::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        $uiComponent->expects($this->any())
-            ->method('getContext')
-            ->willReturn($this->contextMock);
-
-        $this->contextMock->expects($this->any())
-            ->method('getNamespace')
-            ->willReturn(DateRange::NAME);
-        $this->contextMock->expects($this->any())
-            ->method('addComponentDefinition')
-            ->with(DateRange::NAME, ['extends' => DateRange::NAME]);
-
         $this->contextMock->expects($this->any())
             ->method('getFiltersParams')
             ->willReturn($filterData);
 
-        $this->contextMock->expects($this->any())
-            ->method('getDataProvider')
-            ->willReturn($this->dataProviderMock);
+        $uiComponent = $this->getMockBuilder(FormDate::class)->disableOriginalConstructor()->getMock();
+
+        $uiComponent->expects($this->any())
+            ->method('getContext')
+            ->willReturn($this->contextMock);
 
         if ($expectedCondition !== null) {
             if (is_string($filterData[$name])) {
@@ -118,11 +115,11 @@ public function testPrepare($name, $filterData, $expectedCondition)
                 $uiComponent->method('convertDate')
                     ->willReturnMap([
                         [
-                            $filterData[$name]['from'], 0, 0, 0,
+                            $filterData[$name]['from'],
                             new \DateTime($filterData[$name]['from'], new \DateTimeZone('UTC'))
                         ],
                         [
-                            $filterData[$name]['to'], 23, 59, 59,
+                            $filterData[$name]['to'],
                             new \DateTime($filterData[$name]['to'] . ' 23:59:00', new \DateTimeZone('UTC'))
                         ],
                     ]);
@@ -161,6 +158,23 @@ public function testPrepare($name, $filterData, $expectedCondition)
                         ->with($filterMock);
                     break;
             }
+        } else {
+            $uiComponent->method('convertDate')
+                ->willReturnMap([
+                    [
+                        $filterData[$name]['from'],
+                        new \DateTime($filterData[$name]['from'], new \DateTimeZone('UTC'))
+                    ],
+                    [
+                        $filterData[$name]['to'],
+                        new \DateTime($filterData[$name]['to'] . ' 23:59:00', new \DateTimeZone('UTC'))
+                    ],
+                ]);
+
+            $filterMock = $this->getFilterMockWithoutExpectedCondition();
+            $this->dataProviderMock->expects(static::exactly(2))
+                ->method('addFilter')
+                ->with($filterMock);
         }
 
         $this->uiComponentFactory->expects($this->any())
@@ -212,6 +226,31 @@ private function getFilterMock($name, $expectedType, $expectedDate, &$i)
         return $filterMock;
     }
 
+    /**
+     * Gets Filter mock without expected condition
+     *
+     * @return Filter|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private function getFilterMockWithoutExpectedCondition()
+    {
+        $this->filterBuilderMock->expects(static::exactly(2))
+            ->method('setConditionType')
+            ->willReturnSelf();
+        $this->filterBuilderMock->expects(static::exactly(2))
+            ->method('setField')
+            ->willReturnSelf();
+        $this->filterBuilderMock->expects(static::exactly(2))
+            ->method('setValue')
+            ->willReturnSelf();
+
+        $filterMock = $this->getMock(Filter::class);
+        $this->filterBuilderMock->expects(static::exactly(2))
+            ->method('create')
+            ->willReturn($filterMock);
+
+        return $filterMock;
+    }
+
     /**
      * @return array
      */

app/code/Magento/Braintree/Test/Unit/Ui/Component/Report/Filters/Type/DateRangeTest.php

@@ -1,4 +1,3 @@
-## Overview
+# Magento_CatalogAnalytics module
 
-The Magento_CatalogAnalytics module provides products data for integration with
-[Magento Business Intelligence](https://magento.com/products/business-intelligence).
+The Magento_CatalogAnalytics module configures data definitions for a data collection related to the Catalog module entities to be used in [Advanced Reporting](http://devdocs.magento.com/guides/v2.2/advanced-reporting/modules.html).

app/code/Magento/CatalogAnalytics/README.md

@@ -8,6 +8,7 @@
 use Magento\Backend\Block\Widget\Form;
 use Magento\Backend\Block\Widget\Form\Generic;
 use Magento\Ui\Component\Layout\Tabs\TabInterface;
+use Magento\Rule\Model\Condition\AbstractCondition;
 
 class Conditions extends Generic implements TabInterface
 {
@@ -146,14 +147,16 @@ protected function addTabToForm($model, $fieldsetId = 'conditions_fieldset', $fo
         $form = $this->_formFactory->create();
         $form->setHtmlIdPrefix('rule_');
 
+        $conditionsFieldSetId = $model->getConditionsFieldSetId($formName);
+
         $newChildUrl = $this->getUrl(
-            'catalog_rule/promo_catalog/newConditionHtml/form/' . $model->getConditionsFieldSetId($formName),
+            'catalog_rule/promo_catalog/newConditionHtml/form/' . $conditionsFieldSetId,
             ['form_namespace' => $formName]
         );
 
         $renderer = $this->_rendererFieldset->setTemplate('Magento_CatalogRule::promo/fieldset.phtml')
             ->setNewChildUrl($newChildUrl)
-            ->setFieldSetId($model->getConditionsFieldSetId($formName));
+            ->setFieldSetId($conditionsFieldSetId);
 
         $fieldset = $form->addFieldset(
             $fieldsetId,
@@ -175,22 +178,24 @@ protected function addTabToForm($model, $fieldsetId = 'conditions_fieldset', $fo
             ->setRenderer($this->_conditions);
 
         $form->setValues($model->getData());
-        $this->setConditionFormName($model->getConditions(), $formName);
+        $this->setConditionFormName($model->getConditions(), $formName, $conditionsFieldSetId);
         return $form;
     }
 
     /**
-     * @param \Magento\Rule\Model\Condition\AbstractCondition $conditions
+     * @param AbstractCondition $conditions
      * @param string $formName
+     * @param string $jsFormName
      * @return void
      */
-    private function setConditionFormName(\Magento\Rule\Model\Condition\AbstractCondition $conditions, $formName)
+    private function setConditionFormName(AbstractCondition $conditions, $formName, $jsFormName)
     {
         $conditions->setFormName($formName);
-        $conditions->setJsFormObject($formName);
+        $conditions->setJsFormObject($jsFormName);
+
         if ($conditions->getConditions() && is_array($conditions->getConditions())) {
             foreach ($conditions->getConditions() as $condition) {
-                $this->setConditionFormName($condition, $formName);
+                $this->setConditionFormName($condition, $formName, $jsFormName);
             }
         }
     }

app/code/Magento/CatalogRule/Block/Adminhtml/Promo/Catalog/Edit/Tab/Conditions.php

@@ -124,7 +124,6 @@ public function execute()
                                 $escaper->escapeHtml($couponCode)
                             )
                         );
-                        $this->cart->save();
                     }
                 }
             } else {

app/code/Magento/Checkout/Controller/Cart/CouponPost.php

@@ -230,6 +230,7 @@
             <settings>
                 <timezone>false</timezone>
                 <dateFormat>MMM d, y</dateFormat>
+                <skipTime>true</skipTime>
                 <filter>dateRange</filter>
                 <dataType>date</dataType>
                 <label translate="true">Date of Birth</label>

app/code/Magento/Customer/view/adminhtml/ui_component/customer_listing.xml

@@ -1,4 +1,3 @@
-## Overview
+# Magento_CustomerAnalytics module
 
-The Magento_CustomerAnalytics module provides customers data for integration with
-[Magento Business Intelligence](https://magento.com/products/business-intelligence).
+The Magento_CustomerAnalytics module configures data definitions for a data collection related to the Customer module entities to be used in [Advanced Reporting](http://devdocs.magento.com/guides/v2.2/advanced-reporting/modules.html).

app/code/Magento/CustomerAnalytics/README.md

@@ -1,4 +1,3 @@
-## Overview
+# Magento_QuoteAnalytics
 
-The Magento_QuoteAnalytics module provides quotes data for integration with
-[Magento Business Intelligence](https://magento.com/products/business-intelligence).
+The Magento_QuoteAnalytics module configures data definitions for a data collection related to the Quote module entities to be used in [Advanced Reporting](http://devdocs.magento.com/guides/v2.2/advanced-reporting/modules.html).

app/code/Magento/QuoteAnalytics/README.md

@@ -1,4 +1,3 @@
-## Overview
+# Magento_ReviewAnalytics module
 
-The Magento_ReviewAnalytics module provides reviews data for integration with
-[Magento Business Intelligence](https://magento.com/products/business-intelligence).
+The Magento_ReviewAnalytics module configures data definitions for a data collection related to the Review module entities to be used in [Advanced Reporting](http://devdocs.magento.com/guides/v2.2/advanced-reporting/modules.html).