Skip to content

Commit f6f3d25

Browse files
committed
MC-36203: Integration failures when using GD 2.3.0
- Backport fix from 2.4
1 parent 0df6fcd commit f6f3d25

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

dev/tests/integration/testsuite/Magento/Framework/Image/Adapter/InterfaceTest.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,18 @@ protected function _isFormatSupported($image, $adapter)
108108
* Mark test as skipped if not
109109
*
110110
* @param string $adapterType
111-
* @return \Magento\Framework\Image\Adapter\AdapterInterface
111+
* @return \Magento\Framework\Image\Adapter\AdapterInterface|null
112112
*/
113113
protected function _getAdapter($adapterType)
114114
{
115+
$adapter = null;
115116
try {
116117
$objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
117118
$adapter = $objectManager->get(\Magento\Framework\Image\AdapterFactory::class)->create($adapterType);
118-
return $adapter;
119119
} catch (\Exception $e) {
120120
$this->markTestSkipped($e->getMessage());
121121
}
122+
return $adapter;
122123
}
123124

124125
/**
@@ -667,7 +668,7 @@ public function createPngFromStringDataProvider()
667668
[
668669
['x' => 5, 'y' => 8],
669670
'expectedColor1' => ['red' => 0, 'green' => 0, 'blue' => 0],
670-
['x' => 0, 'y' => 14],
671+
['x' => 0, 'y' => 11],
671672
'expectedColor2' => ['red' => 255, 'green' => 255, 'blue' => 255],
672673
\Magento\Framework\Image\Adapter\AdapterInterface::ADAPTER_GD2,
673674
],
@@ -679,9 +680,9 @@ public function createPngFromStringDataProvider()
679680
\Magento\Framework\Image\Adapter\AdapterInterface::ADAPTER_IM
680681
],
681682
[
682-
['x' => 1, 'y' => 14],
683+
['x' => 1, 'y' => 11],
683684
'expectedColor1' => ['red' => 255, 'green' => 255, 'blue' => 255],
684-
['x' => 5, 'y' => 12],
685+
['x' => 5, 'y' => 11],
685686
'expectedColor2' => ['red' => 0, 'green' => 0, 'blue' => 0],
686687
\Magento\Framework\Image\Adapter\AdapterInterface::ADAPTER_GD2
687688
],

0 commit comments

Comments
 (0)