Skip to content

Commit f6d4542

Browse files
authored
Merge pull request #8628 from magento-lynx/AC-10521
AC-10521: Exclude `Adminhtml` area changes in the static test to notify developer of missing GraphQl changes
2 parents 308de2f + 4931a6d commit f6d4542

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

dev/tests/static/testsuite/Magento/Test/GraphQl/LiveCodeTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ public function testModulesRequireGraphQLChange(): void
8282
$modulesRequireGraphQLChange,
8383
"The view layer changes have been detected in the " .
8484
str_replace("GraphQl", "", $graphQlModules) . " module. " .
85-
"The " . $graphQlModules ." module is expected to be updated to reflect these changes."
85+
"The " . $graphQlModules ." module is expected to be updated to reflect these changes. " .
86+
"The test failure can be ignored if the changes can not be covered with GraphQL API."
8687
);
8788
}
8889

@@ -145,7 +146,7 @@ private static function getModuleName(string $filePath): string
145146
private static function isViewLayerClass(string $filePath): bool
146147
{
147148
$className = self::getClassNameWithNamespace($filePath);
148-
if (!$className) {
149+
if (!$className || str_contains(strtolower($className), 'adminhtml')) {
149150
return false;
150151
}
151152

0 commit comments

Comments
 (0)