Improve Extensibility of Service URL Generation

pykettk · web-flow · commit f67baedc2d87 · 2023-04-20T10:01:54.000+01:00
There are some legitimate cases for wanting to customise this function. Let's encourage people to do so in a more maintainable way i.e. via plugins instead of preferences.
diff --git a/app/code/Magento/Store/Model/Argument/Interpreter/ServiceUrl.php b/app/code/Magento/Store/Model/Argument/Interpreter/ServiceUrl.php
@@ -65,7 +65,7 @@ public function __construct(
      *
      * @return string
      */
-    private function getServiceUrl()
+    public function getServiceUrl()
     {
         $store = $this->storeRepository->getById($this->storeManager->getStore()->getId());
         return $this->url->getUrl(

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ public function __construct(`
`65`	`65`	`*`
`66`	`66`	`* @return string`
`67`	`67`	`*/`
`68`		`- private function getServiceUrl()`
	`68`	`+ public function getServiceUrl()`
`69`	`69`	`{`
`70`	`70`	`$store = $this->storeRepository->getById($this->storeManager->getStore()->getId());`
`71`	`71`	`return $this->url->getUrl(`