ACP2E-3067: Magento discards most New Relic cron transactions #34108

Author: abukatar

app/code/Magento/NewRelicReporting/Model/NewRelicWrapper.php

@@ -14,6 +14,8 @@
  */
 class NewRelicWrapper
 {
+    private const NEWRELIC_APPNAME = 'newrelic.appname';
+
     /**
      * Wrapper for 'newrelic_add_custom_parameter' function
      *
@@ -69,6 +71,19 @@ public function setTransactionName(string $transactionName): void
         }
     }
 
+    /**
+     * Wrapper to start background transaction
+     *
+     * @return void
+     */
+    public function startBackgroundTransaction()
+    {
+        if ($this->isExtensionInstalled()) {
+            newrelic_start_transaction(ini_get(self::NEWRELIC_APPNAME));
+            newrelic_background_job();
+        }
+    }
+
     /**
      * Wrapper for 'newrelic_end_transaction'
      *

app/code/Magento/NewRelicReporting/Plugin/StatPlugin.php

@@ -64,6 +64,7 @@ public function beforeStart(Stat $schedule, ...$args): array
         $timerName = current($args);
 
         if ($this->isCronJob($timerName)) {
+            $this->newRelicWrapper->startBackgroundTransaction();
             $this->newRelicWrapper->setTransactionName(
                 sprintf('Cron %s', $timerName)
             );

app/code/Magento/NewRelicReporting/Test/Unit/Plugin/StatPluginTest.php

@@ -55,6 +55,9 @@ protected function setUp(): void
      */
     public function testNewRelicTransactionNameIsNotSetIfNotCronjobPattern()
     {
+        $this->newRelicWrapperMock
+            ->expects($this->never())
+            ->method('startBackgroundTransaction');
         $this->newRelicWrapperMock
             ->expects($this->never())
             ->method('setTransactionName');
@@ -71,6 +74,9 @@ public function testNewRelicTransactionNameIsNotSetIfNotCronjobPattern()
      */
     public function testNewRelicTransactionNameIsSetForCronjobNamePattern()
     {
+        $this->newRelicWrapperMock
+            ->expects($this->once())
+            ->method('startBackgroundTransaction');
         $this->newRelicWrapperMock
             ->expects($this->once())
             ->method('setTransactionName');
@@ -90,7 +96,7 @@ private function getNewRelicWrapperMock(): NewRelicWrapper
         if (null === $this->newRelicWrapperMock) {
             $this->newRelicWrapperMock = $this->getMockBuilder(NewRelicWrapper::class)
                 ->disableOriginalConstructor()
-                ->setMethods(['setTransactionName', 'endTransaction'])
+                ->setMethods(['setTransactionName', 'endTransaction', 'startBackgroundTransaction'])
                 ->getMock();
         }
 

app/code/Magento/NewRelicReporting/etc/di.xml

@@ -46,14 +46,6 @@
     <type name="Magento\Framework\Profiler\Driver\Standard\Stat">
         <plugin name="newrelic-describe-cronjobs" type="Magento\NewRelicReporting\Plugin\StatPlugin"/>
     </type>
-    <type name="Magento\NewRelicReporting\Plugin\CommandPlugin">
-        <arguments>
-            <argument name="skipCommands" xsi:type="array">
-                <item xsi:type="boolean" name="cron:run">true</item>
-                <item xsi:type="boolean" name="server:run">true</item>
-            </argument>
-        </arguments>
-    </type>
     <type name="Magento\NewRelicReporting\Model\Apm\Deployments">
         <arguments>
             <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Json</argument>