B2B-1663: Add Primary Key on Magento CE DB Tables

Author: joanhe

app/code/Magento/Catalog/etc/db_schema.xml

@@ -1693,7 +1693,7 @@
         <constraint xsi:type="foreign" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_ENTT_ID_CAT_PRD_ENTT_ENTT_ID"
                     table="catalog_product_entity_media_gallery_value_to_entity" column="entity_id"
                     referenceTable="catalog_product_entity" referenceColumn="entity_id" onDelete="CASCADE"/>
-        <constraint xsi:type="unique" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_VAL_ID_ENTT_ID">
+        <constraint xsi:type="primary" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_VAL_ID_ENTT_ID">
             <column name="value_id"/>
             <column name="entity_id"/>
         </constraint>

app/code/Magento/Catalog/etc/db_schema_whitelist.json

@@ -1020,6 +1020,7 @@
             "entity_id": true
         },
         "constraint": {
+            "PRIMARY": true,
             "FK_A6C6C8FAA386736921D3A7C4B50B1185": true,
             "CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_ENTT_ID_CAT_PRD_ENTT_ENTT_ID": true,
             "CAT_PRD_ENTT_MDA_GLR_VAL_TO_ENTT_VAL_ID_ENTT_ID": true

app/code/Magento/Integration/etc/db_schema.xml

@@ -84,17 +84,13 @@
         <constraint xsi:type="foreign" referenceId="OAUTH_NONCE_CONSUMER_ID_OAUTH_CONSUMER_ENTITY_ID" table="oauth_nonce"
                     column="consumer_id" referenceTable="oauth_consumer" referenceColumn="entity_id"
                     onDelete="CASCADE"/>
-        <constraint xsi:type="unique" referenceId="OAUTH_NONCE_NONCE_CONSUMER_ID">
+        <constraint xsi:type="primary" referenceId="OAUTH_NONCE_NONCE_CONSUMER_ID">
             <column name="nonce"/>
             <column name="consumer_id"/>
         </constraint>
         <index referenceId="OAUTH_NONCE_TIMESTAMP" indexType="btree">
             <column name="timestamp"/>
         </index>
-        <constraint xsi:type="primary" referenceId="PRIMARY">
-            <column name="nonce"/>
-            <column name="consumer_id"/>
-        </constraint>
     </table>
     <table name="integration" resource="default" engine="innodb" comment="integration">
         <column xsi:type="int" name="integration_id" unsigned="true" nullable="false" identity="true"

app/code/Magento/LoginAsCustomerAssistance/etc/db_schema.xml

@@ -12,10 +12,7 @@
         <constraint xsi:type="foreign" referenceId="LOGIN_AS_CUSTOMER_ASSISTANCE_ALLOWED_CUSTOMER_ID_CUSTOMER_ENTITY_ENTITY_ID"
                     table="login_as_customer_assistance_allowed" column="customer_id" referenceTable="customer_entity"
                     referenceColumn="entity_id" onDelete="CASCADE"/>
-        <constraint xsi:type="unique" referenceId="LOGIN_AS_CUSTOMER_ASSISTANCE_ALLOWED_CUSTOMER_ID">
-            <column name="customer_id"/>
-        </constraint>
-        <constraint xsi:type="primary" referenceId="PRIMARY">
+        <constraint xsi:type="primary" referenceId="LOGIN_AS_CUSTOMER_ASSISTANCE_ALLOWED_CUSTOMER_ID">
             <column name="customer_id"/>
         </constraint>
     </table>

app/code/Magento/ProductVideo/etc/db_schema.xml

@@ -25,11 +25,7 @@
         <constraint xsi:type="foreign" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_VIDEO_STORE_ID_STORE_STORE_ID"
                     table="catalog_product_entity_media_gallery_value_video" column="store_id" referenceTable="store"
                     referenceColumn="store_id" onDelete="CASCADE"/>
-        <constraint xsi:type="unique" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_VIDEO_VAL_ID_STORE_ID">
-            <column name="value_id"/>
-            <column name="store_id"/>
-        </constraint>
-        <constraint xsi:type="primary" referenceId="PRIMARY">
+        <constraint xsi:type="primary" referenceId="CAT_PRD_ENTT_MDA_GLR_VAL_VIDEO_VAL_ID_STORE_ID">
             <column name="value_id"/>
             <column name="store_id"/>
         </constraint>

app/code/Magento/Widget/etc/db_schema.xml

@@ -70,11 +70,7 @@
         <constraint xsi:type="foreign" referenceId="WIDGET_INSTANCE_PAGE_LYT_LYT_UPDATE_ID_LYT_UPDATE_LYT_UPDATE_ID"
                     table="widget_instance_page_layout" column="layout_update_id" referenceTable="layout_update"
                     referenceColumn="layout_update_id" onDelete="CASCADE"/>
-        <constraint xsi:type="unique" referenceId="WIDGET_INSTANCE_PAGE_LAYOUT_LAYOUT_UPDATE_ID_PAGE_ID">
-            <column name="layout_update_id"/>
-            <column name="page_id"/>
-        </constraint>
-        <constraint xsi:type="primary" referenceId="PRIMARY">
+        <constraint xsi:type="primary" referenceId="WIDGET_INSTANCE_PAGE_LAYOUT_LAYOUT_UPDATE_ID_PAGE_ID">
             <column name="layout_update_id"/>
             <column name="page_id"/>
         </constraint>

dev/tests/static/testsuite/Magento/Test/Integrity/DBSchema/_files/primary_key_exemption_list.txt

@@ -1,3 +1,2 @@
-catalog_product_entity_media_gallery_value_to_entity
 catalog_url_rewrite_product_category
 queue_poison_pill